[GitHub] [spark] panbingkun commented on a diff in pull request #41309: [SPARK-43791][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_1336

["panbingkun (via GitHub)" <gi...@apache.org>]

panbingkun commented on code in PR #41309:
URL: https://github.com/apache/spark/pull/41309#discussion_r1205151416


##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala:
##########
@@ -2977,15 +2977,15 @@ class DataSourceV2SQLSuiteV1Filter
         exception = intercept[AnalysisException] {
           sql("SELECT * FROM parquet.`/the/path` VERSION AS OF 1")
         },
-        errorClass = "_LEGACY_ERROR_TEMP_1336",
+        errorClass = "UNSUPPORTED_FEATURE.TIME_TRAVEL",
         sqlState = None,
         parameters = Map("target" -> "path-based tables"))

Review Comment:
   My first private version was like this:
   
   <img width="321" alt="image" src="https://github.com/apache/spark/assets/15246973/7cb5d949-7a05-4f4c-a49c-ea91860ddeb9">
   But I feel that these subclasses only have different target types for operation, and these types can be extracted, I have my doubts.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org