You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/11 13:10:54 UTC

[GitHub] [spark] WeichenXu123 commented on pull request #31693: [SPARK-34448][ML] Binary logistic regression incorrectly computes the intercept and coefficients with small var features

WeichenXu123 commented on pull request #31693:
URL: https://github.com/apache/spark/pull/31693#issuecomment-796724756


   @zhengruifeng 
   ```
   prediction diff:
   avg(abs(diff_raw_prediction)) = 0.007523936579265968
   max(abs(diff_raw_prediction)) = 0.045657305342184706
   ```
   
   Because raw-prediction may be a small value, Could you provide the following instead:
   ```
   avg(abs(diff_raw_prediction)/raw_prediction_from_center_model)
   max(abs(diff_raw_prediction)/raw_prediction_from_center_model) 
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org