You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/11/26 15:57:03 UTC

[GitHub] [ignite] ptupitsyn commented on a change in pull request #9610: IGNITE-15921 Thin client: drop connection on invalid handshake without allocating buffer

ptupitsyn commented on a change in pull request #9610:
URL: https://github.com/apache/ignite/pull/9610#discussion_r757599200



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/ClientMessage.java
##########
@@ -35,6 +35,18 @@
     /** */
     private static final long serialVersionUID = -4609408156037304495L;
 
+    /** */
+    private static final int MAX_HANDSHAKE_SIZE = 1024 * 1024;

Review comment:
       We should pick a limit and stick to it. Current limit is essentially 2 GiB, but having a password or user attributes this large does not make sense, and may cause all sorts of performance issues.
   
   If 1 MiB is too low, let's pick 10 MiB or 64 MiB, but no more than that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org