[GitHub] [iceberg] kbendick commented on a change in pull request #4005: Core: Add delete_file_count for PartitionsTable

[GitBox <gi...@apache.org>]

kbendick commented on a change in pull request #4005:
URL: https://github.com/apache/iceberg/pull/4005#discussion_r795024511



##########
File path: core/src/main/java/org/apache/iceberg/PartitionsTable.java
##########
@@ -167,16 +172,25 @@ Partition get(StructLike key) {
     private final StructLike key;
     private long recordCount;
     private int fileCount;
+    private int deleteFileCount;
 
     Partition(StructLike key) {
       this.key = key;
       this.recordCount = 0;
       this.fileCount = 0;

Review comment:
       If we're going to add this, likely we should also make this `dataFileCount`.
   
   But I would hold off on updating that part, as this is a somewhat larger change to the spec and we should ensure that it's going to be considered in its current form before making smaller updates like that (so you don't spend time unnecessarily).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org