Re: [Trinidad] should event handlers be rendered for disabled components?

[Matt Cooper <mc...@apache.org>]

+1 to making the change and doing so in the central location

On a related note...  There's a similar attribute that input components have
called "readOnly".  When this attribute is true, the component is more
interactive than when disabled is true.  If a component is not disabled but
is readOnly, those events should still be added (same as it is today).

Thanks,
Matt

On Thu, Dec 10, 2009 at 12:56 PM, Andrew Robinson <
andrew.rw.robinson@gmail.com> wrote:

> While implementing the client behaviors on the Trinidad 2 branch I
> noticed something that does not sit right with me. I noticed that the
> on* attributes (onclick, onmouseover, etc.) are rendered by the
> renderEventHandlers method called from renderAllAttributes in the
> XhtmlRenderer. Nowhere do I see that the renderer is checking the
> disabled attribute, if present, to bypass the event handlers for
> disabled components except manually in the button and link renderers.
>
> I filed this ticket:
> https://issues.apache.org/jira/browse/TRINIDAD-1658
>
> I think that we should consider making a disabled check in
> renderAllAttributes and skipping the call to renderEventHandlers when
> the component is disable instead of handling this in a per-component
> renderer case.
>
> Opinions?
>
> -Andrew
>