You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/17 16:38:50 UTC
[GitHub] [airflow] hinnefe2 opened a new pull request, #24530: Filter on XCOM key name when calculating map lengths in MappedOperator
hinnefe2 opened a new pull request, #24530:
URL: https://github.com/apache/airflow/pull/24530
MappedOperator determines how many downstream task instances to create
by counting XCOMs associated with upstream mapped tasks. The current
implementation assumes each upstream mapped task has a single XCOM. When
upstream tasks push additional XCOMs beyond the default one then
MappedOperator will generate too many downstream task instances. This
change updates the XCOM counting query to only consider XCOMs with a key
matching the `XCOM_RETURN_KEY` constant.
closes: https://github.com/apache/airflow/issues/24487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #24530: Filter on XCOM key name when calculating map lengths in MappedOperator
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #24530:
URL: https://github.com/apache/airflow/pull/24530#issuecomment-1159050383
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #24530: Filter XCOM by key when calculating map lengths
Posted by GitBox <gi...@apache.org>.
uranusjr merged PR #24530:
URL: https://github.com/apache/airflow/pull/24530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hinnefe2 commented on pull request #24530: Filter on XCOM key name when calculating map lengths in MappedOperator
Posted by GitBox <gi...@apache.org>.
hinnefe2 commented on PR #24530:
URL: https://github.com/apache/airflow/pull/24530#issuecomment-1170486444
Thanks for the nudge. I'm having a little trouble getting the test to work as intended but I'll sort that out on Slack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hinnefe2 commented on pull request #24530: Filter XCOM by key when calculating map lengths
Posted by GitBox <gi...@apache.org>.
hinnefe2 commented on PR #24530:
URL: https://github.com/apache/airflow/pull/24530#issuecomment-1198563886
🎉 Thanks for the help getting this across the finish line!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #24530: Filter on XCOM key name when calculating map lengths in MappedOperator
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #24530:
URL: https://github.com/apache/airflow/pull/24530#issuecomment-1196427041
I’m going to make the call since this is straightfoward enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #24530: Filter on XCOM key name when calculating map lengths in MappedOperator
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on PR #24530:
URL: https://github.com/apache/airflow/pull/24530#issuecomment-1169063735
@hinnefe2, gentle ping. It'd be great to get this into 2.3.3. That test file is the right spot. If you have further questions/get stuck, feel free to ping us in #development on Slack!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hinnefe2 commented on pull request #24530: Filter on XCOM key name when calculating map lengths in MappedOperator
Posted by GitBox <gi...@apache.org>.
hinnefe2 commented on PR #24530:
URL: https://github.com/apache/airflow/pull/24530#issuecomment-1162360216
Sure, I'll put a test or two in `tests/models/test_mappedoperator.py` unless somebody points out a better place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #24530: Filter on XCOM key name when calculating map lengths in MappedOperator
Posted by GitBox <gi...@apache.org>.
uranusjr commented on code in PR #24530:
URL: https://github.com/apache/airflow/pull/24530#discussion_r922955823
##########
tests/test_utils/mock_operators.py:
##########
@@ -161,3 +161,17 @@ def __init__(self, **kwargs):
def execute(self, context: Context):
pass
+
+
+class XCOMPushOperator(BaseOperator):
+ """
+ Operator which pushes an extra XCOM value along with the default XCOM_RETURN_KEY
+ """
+
+ def __init__(self, return_value, **kwargs):
+ super().__init__(do_xcom_push=True, **kwargs)
+ self.return_value = return_value
+
+ def execute(self, context: Context):
+ context['task_instance'].xcom_push(key='extra_key', value="extra_value")
+ return self.return_value
Review Comment:
Since there’s only one test that needs this class, I’d put it in the test instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #24530: Filter XCOM by key when calculating map lengths
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #24530:
URL: https://github.com/apache/airflow/pull/24530#issuecomment-1196427437
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org