[GitHub] [couchdb] tonysun83 commented on a diff in pull request #3979: use undefined for timed out responses

[GitBox <gi...@apache.org>]

tonysun83 commented on code in PR #3979:
URL: https://github.com/apache/couchdb/pull/3979#discussion_r862971057


##########
src/fabric/src/fabric_doc_update.erl:
##########
@@ -39,10 +39,15 @@ go(DbName, AllDocs0, Opts) ->
     Acc0 = {length(Workers), length(AllDocs), list_to_integer(W), GroupedDocs, dict:new()},
     Timeout = fabric_util:request_timeout(),
     try rexi_utils:recv(Workers, #shard.ref, fun handle_message/3, Acc0, infinity, Timeout) of
+        {ok, {_, []}} ->
+            erlang:error({internal_server_error, "No Responses For Document Update"});

Review Comment:
   hmmm good point, I didn't consider that. What if we added:
   
   ```
   {ok, {_, []}} when length(AllDocs) > 0
   ```
   ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org