You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@airavata.apache.org by "ShivangMishra (via GitHub)" <gi...@apache.org> on 2024/04/01 05:57:31 UTC
[PR] Validation logic to wait until the consul port 8500 is open before starting mft (issue #128) [airavata-mft]
ShivangMishra opened a new pull request, #131:
URL: https://github.com/apache/airavata-mft/pull/131
With this change, issue #128 is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Validation logic to wait until the consul port 8500 is open before starting mft (issue #128) [airavata-mft]
Posted by "ShivangMishra (via GitHub)" <gi...@apache.org>.
ShivangMishra commented on PR #131:
URL: https://github.com/apache/airavata-mft/pull/131#issuecomment-2029515610
@smarru @DImuthuUpe could you please review and merge this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Validation logic to wait until the consul port 8500 is open before starting mft (issue #128) [airavata-mft]
Posted by "DImuthuUpe (via GitHub)" <gi...@apache.org>.
DImuthuUpe commented on PR #131:
URL: https://github.com/apache/airavata-mft/pull/131#issuecomment-2034978206
Looks great. Thanks @ShivangMishra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Validation logic to wait until the consul port 8500 is open before starting mft (issue #128) [airavata-mft]
Posted by "DImuthuUpe (via GitHub)" <gi...@apache.org>.
DImuthuUpe merged PR #131:
URL: https://github.com/apache/airavata-mft/pull/131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Validation logic to wait until the consul port 8500 is open before starting mft (issue #128) [airavata-mft]
Posted by "ShivangMishra (via GitHub)" <gi...@apache.org>.
ShivangMishra commented on code in PR #131:
URL: https://github.com/apache/airavata-mft/pull/131#discussion_r1549248067
##########
python-cli/mft_cli/airavata_mft_cli/bootstrap.py:
##########
@@ -160,6 +164,10 @@ def start_mft():
zip_path = os.path.join(os.path.expanduser('~'), ".mft/Standalone-Service-0.01-bin.zip")
download_and_unarchive(url, zip_path)
+ while not is_port_open(8500):
+ print("Waiting for Consul to start...")
+ time.sleep(1)
Review Comment:
Yes sure. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Validation logic to wait until the consul port 8500 is open before starting mft (issue #128) [airavata-mft]
Posted by "DImuthuUpe (via GitHub)" <gi...@apache.org>.
DImuthuUpe commented on code in PR #131:
URL: https://github.com/apache/airavata-mft/pull/131#discussion_r1546484997
##########
python-cli/mft_cli/airavata_mft_cli/bootstrap.py:
##########
@@ -160,6 +164,10 @@ def start_mft():
zip_path = os.path.join(os.path.expanduser('~'), ".mft/Standalone-Service-0.01-bin.zip")
download_and_unarchive(url, zip_path)
+ while not is_port_open(8500):
+ print("Waiting for Consul to start...")
+ time.sleep(1)
Review Comment:
@ShivangMishra Can you make this only run for 20 seconds and if the port is not open by then, throw an error message and exit the program?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org