You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/09/16 11:11:56 UTC
[GitHub] [skywalking-agent-test-tool] harvies opened a new pull request #24: Update pom.xml
harvies opened a new pull request #24:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/24
Support jdk1.9
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-agent-test-tool] kezhenxu94 commented on pull request #24: Update pom.xml
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #24:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/24#issuecomment-693373705
It's just a test tool, why bother to add this? Do you build this tool locally and only have JDK9 installed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-agent-test-tool] kezhenxu94 commented on a change in pull request #24: Update pom.xml
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #24:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/24#discussion_r489509177
##########
File path: mock-collector/pom.xml
##########
@@ -187,4 +187,19 @@
</plugin>
</plugins>
</build>
+ <profiles>
+ <profile>
+ <id>java9</id>
+ <activation>
+ <jdk>[1.9,]</jdk>
Review comment:
This is automatically detected and activated, so it's transparent to the users, they don't need to care about the JDK version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-agent-test-tool] wu-sheng commented on pull request #24: Update pom.xml
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #24:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/24#issuecomment-693383355
Why merge this? We are asking for jdk8 compiling im the doc. And as a test tool, we don't need multiple JDK supports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-agent-test-tool] harvies commented on a change in pull request #24: Update pom.xml
Posted by GitBox <gi...@apache.org>.
harvies commented on a change in pull request #24:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/24#discussion_r490271039
##########
File path: mock-collector/pom.xml
##########
@@ -187,4 +187,19 @@
</plugin>
</plugins>
</build>
+ <profiles>
+ <profile>
+ <id>java9</id>
+ <activation>
+ <jdk>[1.9,]</jdk>
Review comment:
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-agent-test-tool] kezhenxu94 merged pull request #24: Update pom.xml
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #24:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/24
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-agent-test-tool] wu-sheng commented on pull request #24: Update pom.xml
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #24:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/24#issuecomment-693473405
@harvies To verify this PR is no harm, could you update the main repo commit id?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-agent-test-tool] harvies commented on pull request #24: Update pom.xml
Posted by GitBox <gi...@apache.org>.
harvies commented on pull request #24:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/24#issuecomment-695193825
> @harvies To verify this PR is no harm, could you update the main repo commit id?
Please see https://github.com/apache/skywalking/pull/5522
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-agent-test-tool] wu-sheng commented on pull request #24: Update pom.xml
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #24:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/24#issuecomment-693388988
If this PR is required, the document should be updated to tell users, you need a `-p` in the maven command.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-agent-test-tool] harvies commented on pull request #24: Update pom.xml
Posted by GitBox <gi...@apache.org>.
harvies commented on pull request #24:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/24#issuecomment-693381633
> It's just a test tool, why bother to add this? Do you build this tool locally and only have JDK9 installed?
There are multiple jdk installed locally, the default is jdk11.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org