You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/10/07 18:58:39 UTC
[GitHub] [zookeeper] ctubbsii opened a new pull request #1489: ZOOKEEPER-3962: Add an .asf.yaml file
ctubbsii opened a new pull request #1489:
URL: https://github.com/apache/zookeeper/pull/1489
Create an .asf.yaml file to specify certain github repository settings,
such as description, topic, URL, etc.
This file can also be later used to add automation for building the
project's website, in whole or in part.
See https://cwiki.apache.org/confluence/display/INFRA/git+-+.asf.yaml+features
for more information on available features.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1489: ZOOKEEPER-3962: Add an .asf.yaml file
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1489:
URL: https://github.com/apache/zookeeper/pull/1489#issuecomment-706177206
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat commented on pull request #1489: ZOOKEEPER-3962: Add an .asf.yaml file
Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1489:
URL: https://github.com/apache/zookeeper/pull/1489#issuecomment-706174136
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1489: ZOOKEEPER-3962: Add an .asf.yaml file
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1489:
URL: https://github.com/apache/zookeeper/pull/1489#issuecomment-706177206
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ctubbsii commented on pull request #1489: ZOOKEEPER-3962: Add an .asf.yaml file
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1489:
URL: https://github.com/apache/zookeeper/pull/1489#issuecomment-705957794
@symat Did my previous explanation about the choice to remove the 'java' label satisfy your 'nit'? Or do you still want me to add it, before it gets merged? I don't want this PR to sit here too long, because the longer it takes to merge, the less useful it will be to Hacktoberfest participants (and the project, which has an interest in attracting contributors).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ctubbsii commented on pull request #1489: ZOOKEEPER-3962: Add an .asf.yaml file
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1489:
URL: https://github.com/apache/zookeeper/pull/1489#issuecomment-705141697
By the way, this would only need to be applied to the master/default branch to take effect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ctubbsii commented on pull request #1489: ZOOKEEPER-3962: Add an .asf.yaml file
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1489:
URL: https://github.com/apache/zookeeper/pull/1489#issuecomment-705392730
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] asfgit closed pull request #1489: ZOOKEEPER-3962: Add an .asf.yaml file
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1489:
URL: https://github.com/apache/zookeeper/pull/1489
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ctubbsii commented on pull request #1489: ZOOKEEPER-3962: Add an .asf.yaml file
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1489:
URL: https://github.com/apache/zookeeper/pull/1489#issuecomment-705392730
> LGTM
> nit: we also have "java" label now on the github repo. Is there a limit on the number of the labels? If not, then we can add "java" back.
We can add more.
However, I consciously removed that one, because these labels are supposed to indicate the topic, or subject matter, for a repo. Although the project is written mostly in Java, "Java" isn't a subject of the project. GitHub has other mechanisms to search by language. It's best not to overuse tags, and the "java" topic is prone to overuse... to the point where it is effectively useless for searching. (FWIW, I debated with myself over including the "database" topic, because it is also too generic to be that useful... however, I added that because it is the ASF project category at https://projects.apache.org/project.html?zookeeper )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat commented on pull request #1489: ZOOKEEPER-3962: Add an .asf.yaml file
Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1489:
URL: https://github.com/apache/zookeeper/pull/1489#issuecomment-706174136
sure, I'm happy to merge this as it is. (I agree, let's drop "java", thanks for the explanation)
@eolivelli @nkalmar PTAL (we still need one more +1)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org