You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by stocks alex <al...@apache.org> on 2020/07/12 04:51:13 UTC

[VOTE]: Accept dubbogo/getty donation

Hi guys,

This is a formal vote to bring dubbogo/getty[1], which is depended
by apache/dubbo-go, to Apache Dubbo project.

What's more, the copyright of this repo is owned by myself and it has been
written since 2016.

Please vote:

[ ] +1 Accept
[ ] +0 No Opinion
[ ] -1 Reject because...

[1] https://github.com/dubbogo/getty

Re: [VOTE]: Accept dubbogo/getty donation

Posted by YiXian Zou <yi...@gmail.com>.
+1 Accept

stocks alex <al...@apache.org> 于2020年7月12日周日 下午12:51写道:

> Hi guys,
>
> This is a formal vote to bring dubbogo/getty[1], which is depended
> by apache/dubbo-go, to Apache Dubbo project.
>
> What's more, the copyright of this repo is owned by myself and it has been
> written since 2016.
>
> Please vote:
>
> [ ] +1 Accept
> [ ] +0 No Opinion
> [ ] -1 Reject because...
>
> [1] https://github.com/dubbogo/getty
>

Re: [VOTE]: Accept dubbogo/getty donation

Posted by stocks alex <al...@apache.org>.
what's more, we also the license of github.com/dubbogo/getty's dependency
libs, all of them are compatible with APL v2.

stocks alex <al...@apache.org> 于2020年7月21日周二 下午10:28写道:

> to Mr Justin Mclean,
>
> all contributors as follows except [JerryZhou343](
> https://github.com/JerryZhou343) has signed the ICLA.
>
> https://github.com/alexstocks
> https://github.com/fangyincheng
> https://github.com/pantianying
> https://github.com/wongoo
> https://github.com/zouyx
> https://github.com/gaoxinge
> https://github.com/watermelo
> https://github.com/u0x01
> https://github.com/wenxuwan
>
> I can not contact with JerryZhou343 who just has one commit
> https://github.com/dubbogo/getty/commit/0c47783532dd2dc9995d8ebd850dcda09856e939 .
> As u see, this commit is very little.
>
> If u agree with me that we do not need JerryZhou343's ICLA, all agreement
> including my SGA and the contributors' ICLA has signed.
>
>
> Justin Mclean <ju...@classsoftware.com> 于2020年7月21日周二 下午8:33写道:
>
>> Hi,
>>
>> Before it can be accepted it needs to pass IP clearance as described here
>> [1]
>>
>> Thanks,
>> Justin
>>
>>
>> 1.http://incubator.apache.org/ip-clearance/ip-clearance-template.html
>>
>

Re: [VOTE]: Accept dubbogo/getty donation

Posted by stocks alex <al...@apache.org>.
to Mr Justin,

I have contact with the last contributor  JerryZhou343 whose Chinese name
is Yujie Zhou. And he has signed the ICLA and sent it out to secretary last
day.

Justin Mclean <ju...@classsoftware.com> 于2020年7月22日周三 上午7:56写道:

> Hi,
>
> > all contributors as follows except [JerryZhou343](
> > https://github.com/JerryZhou343) has signed the ICLA.
>
> That seems fine. It would be best to list their names as the ICLA don’t
> list GitHub accounts.
>
> > I can not contact with JerryZhou343 who just has one commit
> >
> https://github.com/dubbogo/getty/commit/0c47783532dd2dc9995d8ebd850dcda09856e939
>
> I don’t think that is a concern.
>
> Thanks,
> Justin

Re: [VOTE]: Accept dubbogo/getty donation

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

That all look fine but don’t forget about the IP clearance form
.http://incubator.apache.org/ip-clearance/ip-clearance-template.html <http://incubator.apache.org/ip-clearance/ip-clearance-template.html>

This need to be completed before any code from this SGA is released.

This may also help:
https://incubator.apache.org/guides/ip_clearance.html

Thanks,
Justin


Re: [VOTE]: Accept dubbogo/getty donation

Posted by Jun Liu <li...@apache.org>.
+1

Thanks Alex for all the donation effort. Looking forward Getty join Apache soon.

Jun

> On Jul 22, 2020, at 10:01 PM, stocks alex <al...@apache.org> wrote:
> 
> To Mr Justin, the contributors info is as follows,
> 
> Github IDChinese NameApache Committer(y/n)ICLA Sign Date
> alexstocks Zhao Xin y March 29, 2019
> fangyincheng Fang Yincheng y March 29, 2019
> pantianying Pan Tianying y Sep, 2019
> wongoo Yang Liu y March 29, 2019
> zouyx Zou Yixian y Feb, 2020
> gaoxinge Gao Xinge y March 29, 2019
> watermelo He Qun n May 21, 2020
> u0x01 Zhou Ziqing n March 29, 2019
> wenxuwan Wang Wenxue n May 21, 2020
> 
> Justin Mclean <ju...@classsoftware.com> 于2020年7月22日周三 上午7:56写道:
> 
>> Hi,
>> 
>>> all contributors as follows except [JerryZhou343](
>>> https://github.com/JerryZhou343) has signed the ICLA.
>> 
>> That seems fine. It would be best to list their names as the ICLA don’t
>> list GitHub accounts.
>> 
>>> I can not contact with JerryZhou343 who just has one commit
>>> 
>> https://github.com/dubbogo/getty/commit/0c47783532dd2dc9995d8ebd850dcda09856e939
>> 
>> I don’t think that is a concern.
>> 
>> Thanks,
>> Justin


Re: [VOTE]: Accept dubbogo/getty donation

Posted by victory <sh...@gmail.com>.
+1

The getty is the core component in dubbo-go.  I look forward to it joining
Apache soon.

stocks alex <al...@apache.org> 于2020年7月22日周三 下午10:07写道:

> to Mr Justin,
>
> IMO we have completed all the agreements. I will show the vote result this
> weekend.
>
> stocks alex <al...@apache.org> 于2020年7月22日周三 下午10:01写道:
>
> > To Mr Justin, the contributors info is as follows,
> >
> > Github IDChinese NameApache Committer(y/n)ICLA Sign Date
> > alexstocks Zhao Xin y March 29, 2019
> > fangyincheng Fang Yincheng y March 29, 2019
> > pantianying Pan Tianying y Sep, 2019
> > wongoo Yang Liu y March 29, 2019
> > zouyx Zou Yixian y Feb, 2020
> > gaoxinge Gao Xinge y March 29, 2019
> > watermelo He Qun n May 21, 2020
> > u0x01 Zhou Ziqing n March 29, 2019
> > wenxuwan Wang Wenxue n May 21, 2020
> >
> > Justin Mclean <ju...@classsoftware.com> 于2020年7月22日周三 上午7:56写道:
> >
> >> Hi,
> >>
> >> > all contributors as follows except [JerryZhou343](
> >> > https://github.com/JerryZhou343) has signed the ICLA.
> >>
> >> That seems fine. It would be best to list their names as the ICLA don’t
> >> list GitHub accounts.
> >>
> >> > I can not contact with JerryZhou343 who just has one commit
> >> >
> >>
> https://github.com/dubbogo/getty/commit/0c47783532dd2dc9995d8ebd850dcda09856e939
> >>
> >> I don’t think that is a concern.
> >>
> >> Thanks,
> >> Justin
> >
> >
>


-- 

Best Regard!
cvitory

Re: [VOTE]: Accept dubbogo/getty donation

Posted by stocks alex <al...@apache.org>.
to Mr Justin,

IMO we have completed all the agreements. I will show the vote result this
weekend.

stocks alex <al...@apache.org> 于2020年7月22日周三 下午10:01写道:

> To Mr Justin, the contributors info is as follows,
>
> Github IDChinese NameApache Committer(y/n)ICLA Sign Date
> alexstocks Zhao Xin y March 29, 2019
> fangyincheng Fang Yincheng y March 29, 2019
> pantianying Pan Tianying y Sep, 2019
> wongoo Yang Liu y March 29, 2019
> zouyx Zou Yixian y Feb, 2020
> gaoxinge Gao Xinge y March 29, 2019
> watermelo He Qun n May 21, 2020
> u0x01 Zhou Ziqing n March 29, 2019
> wenxuwan Wang Wenxue n May 21, 2020
>
> Justin Mclean <ju...@classsoftware.com> 于2020年7月22日周三 上午7:56写道:
>
>> Hi,
>>
>> > all contributors as follows except [JerryZhou343](
>> > https://github.com/JerryZhou343) has signed the ICLA.
>>
>> That seems fine. It would be best to list their names as the ICLA don’t
>> list GitHub accounts.
>>
>> > I can not contact with JerryZhou343 who just has one commit
>> >
>> https://github.com/dubbogo/getty/commit/0c47783532dd2dc9995d8ebd850dcda09856e939
>>
>> I don’t think that is a concern.
>>
>> Thanks,
>> Justin
>
>

Re: [VOTE]: Accept dubbogo/getty donation

Posted by stocks alex <al...@apache.org>.
To Mr Justin, the contributors info is as follows,

Github IDChinese NameApache Committer(y/n)ICLA Sign Date
alexstocks Zhao Xin y March 29, 2019
fangyincheng Fang Yincheng y March 29, 2019
pantianying Pan Tianying y Sep, 2019
wongoo Yang Liu y March 29, 2019
zouyx Zou Yixian y Feb, 2020
gaoxinge Gao Xinge y March 29, 2019
watermelo He Qun n May 21, 2020
u0x01 Zhou Ziqing n March 29, 2019
wenxuwan Wang Wenxue n May 21, 2020

Justin Mclean <ju...@classsoftware.com> 于2020年7月22日周三 上午7:56写道:

> Hi,
>
> > all contributors as follows except [JerryZhou343](
> > https://github.com/JerryZhou343) has signed the ICLA.
>
> That seems fine. It would be best to list their names as the ICLA don’t
> list GitHub accounts.
>
> > I can not contact with JerryZhou343 who just has one commit
> >
> https://github.com/dubbogo/getty/commit/0c47783532dd2dc9995d8ebd850dcda09856e939
>
> I don’t think that is a concern.
>
> Thanks,
> Justin

Re: [VOTE]: Accept dubbogo/getty donation

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> all contributors as follows except [JerryZhou343](
> https://github.com/JerryZhou343) has signed the ICLA.

That seems fine. It would be best to list their names as the ICLA don’t list GitHub accounts.

> I can not contact with JerryZhou343 who just has one commit
> https://github.com/dubbogo/getty/commit/0c47783532dd2dc9995d8ebd850dcda09856e939

I don’t think that is a concern.

Thanks,
Justin

Re: [VOTE]: Accept dubbogo/getty donation

Posted by stocks alex <al...@apache.org>.
to Mr Justin Mclean,

all contributors as follows except [JerryZhou343](
https://github.com/JerryZhou343) has signed the ICLA.

https://github.com/alexstocks
https://github.com/fangyincheng
https://github.com/pantianying
https://github.com/wongoo
https://github.com/zouyx
https://github.com/gaoxinge
https://github.com/watermelo
https://github.com/u0x01
https://github.com/wenxuwan

I can not contact with JerryZhou343 who just has one commit
https://github.com/dubbogo/getty/commit/0c47783532dd2dc9995d8ebd850dcda09856e939
.
As u see, this commit is very little.

If u agree with me that we do not need JerryZhou343's ICLA, all agreement
including my SGA and the contributors' ICLA has signed.


Justin Mclean <ju...@classsoftware.com> 于2020年7月21日周二 下午8:33写道:

> Hi,
>
> Before it can be accepted it needs to pass IP clearance as described here
> [1]
>
> Thanks,
> Justin
>
>
> 1.http://incubator.apache.org/ip-clearance/ip-clearance-template.html
>

Re: [VOTE]: Accept dubbogo/getty donation

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

Before it can be accepted it needs to pass IP clearance as described here [1]

Thanks,
Justin


1.http://incubator.apache.org/ip-clearance/ip-clearance-template.html

Re: [VOTE]: Accept dubbogo/getty donation

Posted by stocks alex <al...@apache.org>.
to Mr Justin Mclean,

I have signed the SGA and sent it to the secretary which has been accepted
by Matt Sicker today.

*I will let the contributors sign the ICLA this week.*

Justin Mclean <ju...@classsoftware.com> 于2020年7月21日周二 下午2:31写道:

> Hi,
>
> Has twas the grant handled? I don’t see it listed here. [1] Do we have
> signed ICLA’s for all contribitors?
>
> Thanks,
> Justin
>
> 1. https://incubator.apache.org/ip-clearance/

Re: [VOTE]: Accept dubbogo/getty donation

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

Has twas the grant handled? I don’t see it listed here. [1] Do we have signed ICLA’s for all contribitors?

Thanks,
Justin

1. https://incubator.apache.org/ip-clearance/

Re: [VOTE]: Accept dubbogo/getty donation

Posted by Ian Luo <ia...@gmail.com>.
Justin,

Would you mind shine some light on this particular issue? I am not sure if
a IP clearance report is necessary.

Thanks,
-Ian.


On Mon, Jul 20, 2020 at 9:39 PM stocks alex <al...@apache.org> wrote:

> Hi guys, I have sent out my SGA last Saturday. And What's more, I have got
> enough vote tickets, What should I do now?
>
> Ian Luo <ia...@gmail.com> 于2020年7月15日周三 下午10:20写道:
>
> > +1
> >
> > On Wed, Jul 15, 2020 at 10:48 AM Jun Liu <li...@apache.org> wrote:
> >
> > > I think it’s better if can sort out all the IP CLEARANCE things before
> > > reach consensus on this vote.
> > >
> > > Jun
> > >
> > > > On Jul 13, 2020, at 10:13 PM, Justin Mclean <
> justin@classsoftware.com>
> > > wrote:
> > > >
> > > > Hi,
> > > >
> > > >> I know what u mean. However, this is a vote email. If we completed
> the
> > > vote
> > > >> process, and then we start to sign the ICLA OR  SGA as I know.
> > > >
> > > > IMO it would be better if these issues were sorted out before a vote
> is
> > > called - but that is up to the PPMC to work out.
> > > >
> > > > Thanks,
> > > > Justin
> > > >
> > >
> > >
> >
>

Re: [VOTE]: Accept dubbogo/getty donation

Posted by stocks alex <al...@apache.org>.
Hi guys, I have sent out my SGA last Saturday. And What's more, I have got
enough vote tickets, What should I do now?

Ian Luo <ia...@gmail.com> 于2020年7月15日周三 下午10:20写道:

> +1
>
> On Wed, Jul 15, 2020 at 10:48 AM Jun Liu <li...@apache.org> wrote:
>
> > I think it’s better if can sort out all the IP CLEARANCE things before
> > reach consensus on this vote.
> >
> > Jun
> >
> > > On Jul 13, 2020, at 10:13 PM, Justin Mclean <ju...@classsoftware.com>
> > wrote:
> > >
> > > Hi,
> > >
> > >> I know what u mean. However, this is a vote email. If we completed the
> > vote
> > >> process, and then we start to sign the ICLA OR  SGA as I know.
> > >
> > > IMO it would be better if these issues were sorted out before a vote is
> > called - but that is up to the PPMC to work out.
> > >
> > > Thanks,
> > > Justin
> > >
> >
> >
>

Re: [VOTE]: Accept dubbogo/getty donation

Posted by Ian Luo <ia...@gmail.com>.
+1

On Wed, Jul 15, 2020 at 10:48 AM Jun Liu <li...@apache.org> wrote:

> I think it’s better if can sort out all the IP CLEARANCE things before
> reach consensus on this vote.
>
> Jun
>
> > On Jul 13, 2020, at 10:13 PM, Justin Mclean <ju...@classsoftware.com>
> wrote:
> >
> > Hi,
> >
> >> I know what u mean. However, this is a vote email. If we completed the
> vote
> >> process, and then we start to sign the ICLA OR  SGA as I know.
> >
> > IMO it would be better if these issues were sorted out before a vote is
> called - but that is up to the PPMC to work out.
> >
> > Thanks,
> > Justin
> >
>
>

Re: [VOTE]: Accept dubbogo/getty donation

Posted by Jun Liu <li...@apache.org>.
I think it’s better if can sort out all the IP CLEARANCE things before reach consensus on this vote. 

Jun

> On Jul 13, 2020, at 10:13 PM, Justin Mclean <ju...@classsoftware.com> wrote:
> 
> Hi,
> 
>> I know what u mean. However, this is a vote email. If we completed the vote
>> process, and then we start to sign the ICLA OR  SGA as I know.
> 
> IMO it would be better if these issues were sorted out before a vote is called - but that is up to the PPMC to work out.
> 
> Thanks,
> Justin
> 


Re: [VOTE]: Accept dubbogo/getty donation

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

A software grant is required in this case please see [1].

Thanks,
Justin


1. https://www.apache.org/licenses/contributor-agreements.html#grants


Re: [VOTE]: Accept dubbogo/getty donation

Posted by stocks alex <al...@apache.org>.
To Mr Justin,

As the dubbo-go, this repo is owned by myself at the beginning. So we
dubbo-go contributors do not need to sign SGA. We just need to sign the
ICLA as the passed processes.

all of the contributors of getty are listed as follows,

[apache committer]
https://github.com/alexstocks
https://github.com/fangyincheng
https://github.com/pantianying
https://github.com/wongoo
https://github.com/zouyx
https://github.com/gaoxinge [in progress, has signed the ICLA]

[non-apache-committer but dubbo-go contributors]
https://github.com/watermelo
https://github.com/u0x01
https://github.com/wenxuwan
https://github.com/JerryZhou343

As discussed in the above emails, apache committers do not need to sign the
ICLA. AND I have discussed with the above four guys, they all agree with
me, and are willing to donate this repo. After the vote, they will send
their ICLA.

Yours sincerely,
Alex

Justin Mclean <ju...@classsoftware.com> 于2020年7月13日周一 下午10:13写道:

> Hi,
>
> > I know what u mean. However, this is a vote email. If we completed the
> vote
> > process, and then we start to sign the ICLA OR  SGA as I know.
>
> IMO it would be better if these issues were sorted out before a vote is
> called - but that is up to the PPMC to work out.
>
> Thanks,
> Justin
>
>

Re: [VOTE]: Accept dubbogo/getty donation

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> I know what u mean. However, this is a vote email. If we completed the vote
> process, and then we start to sign the ICLA OR  SGA as I know.

IMO it would be better if these issues were sorted out before a vote is called - but that is up to the PPMC to work out.

Thanks,
Justin


Re: [VOTE]: Accept dubbogo/getty donation

Posted by stocks alex <al...@apache.org>.
to Mr Justin,

I know what u mean. However, this is a vote email. If we completed the vote
process, and then we start to sign the ICLA OR  SGA as I know.

Justin Mclean <ju...@classsoftware.com> 于2020年7月13日周一 下午12:50写道:

> HI,
>
> For any contribution of significant size a SGA is required and IP
> clearance undertaken. If it this repo [1] then an individual does not own
> copyright of all of the code. Each contributor or their employer owns
> copyright in their own contributions unless they have stated otherwise. If
> their employer own the copyright we need permission from them.
>
> Thanks,
> Justin
>
> 1. https://github.com/dubbogo/getty/graphs/contributors

Re: [VOTE]: Accept dubbogo/getty donation

Posted by Justin Mclean <ju...@classsoftware.com>.
HI,

For any contribution of significant size a SGA is required and IP clearance undertaken. If it this repo [1] then an individual does not own copyright of all of the code. Each contributor or their employer owns copyright in their own contributions unless they have stated otherwise. If their employer own the copyright we need permission from them.

Thanks,
Justin

1. https://github.com/dubbogo/getty/graphs/contributors

Re: [VOTE]: Accept dubbogo/getty donation

Posted by joezou <jo...@apache.org>.
+1 Accept
Sorry for wrong sender for the previous reply

stocks alex <al...@apache.org> 于2020年7月12日周日 下午12:51写道:

> Hi guys,
>
> This is a formal vote to bring dubbogo/getty[1], which is depended
> by apache/dubbo-go, to Apache Dubbo project.
>
> What's more, the copyright of this repo is owned by myself and it has been
> written since 2016.
>
> Please vote:
>
> [ ] +1 Accept
> [ ] +0 No Opinion
> [ ] -1 Reject because...
>
> [1] https://github.com/dubbogo/getty
>

Re: [VOTE]: Accept dubbogo/getty donation

Posted by Jun Liu <li...@apache.org>.
Hi, Alex

For contributors contributed considerable codes but are not Dubbo committers, we should have them with ICLA[1] signed before donation. As this project is owned by you yourself, I think no SGA is needed, your personal ICLA would be fine.
 
1. http://dubbo.apache.org/en-us/docs/developers/contributor-guide/cla-signing-guide_dev.html

Jun

> On Jul 12, 2020, at 12:51 PM, stocks alex <al...@apache.org> wrote:
> 
> Hi guys,
> 
> This is a formal vote to bring dubbogo/getty[1], which is depended
> by apache/dubbo-go, to Apache Dubbo project.
> 
> What's more, the copyright of this repo is owned by myself and it has been
> written since 2016.
> 
> Please vote:
> 
> [ ] +1 Accept
> [ ] +0 No Opinion
> [ ] -1 Reject because...
> 
> [1] https://github.com/dubbogo/getty


Re: [VOTE]: Accept dubbogo/getty donation

Posted by stocks alex <al...@apache.org>.
Yeah, all those contributors are from dubbo/dubbo-go contributors. Almost
all of those codes are from github.com/alexstocks/getty.  Some differences
btw the two repos is from the adaptive codes for apache/dubbo-go.

Ian Luo <ia...@gmail.com> 于2020年7月13日周一 上午10:20写道:

> +1 to accept. I believe all major contributors all come from dubbo
> comitter, but Alex, pls. double check.
>
> Thanks,
> -Ian.
>
> On Sun, Jul 12, 2020 at 12:51 PM stocks alex <al...@apache.org>
> wrote:
>
> > Hi guys,
> >
> > This is a formal vote to bring dubbogo/getty[1], which is depended
> > by apache/dubbo-go, to Apache Dubbo project.
> >
> > What's more, the copyright of this repo is owned by myself and it has
> been
> > written since 2016.
> >
> > Please vote:
> >
> > [ ] +1 Accept
> > [ ] +0 No Opinion
> > [ ] -1 Reject because...
> >
> > [1] https://github.com/dubbogo/getty
> >
>

Re: [VOTE]: Accept dubbogo/getty donation

Posted by Ian Luo <ia...@gmail.com>.
+1 to accept. I believe all major contributors all come from dubbo
comitter, but Alex, pls. double check.

Thanks,
-Ian.

On Sun, Jul 12, 2020 at 12:51 PM stocks alex <al...@apache.org> wrote:

> Hi guys,
>
> This is a formal vote to bring dubbogo/getty[1], which is depended
> by apache/dubbo-go, to Apache Dubbo project.
>
> What's more, the copyright of this repo is owned by myself and it has been
> written since 2016.
>
> Please vote:
>
> [ ] +1 Accept
> [ ] +0 No Opinion
> [ ] -1 Reject because...
>
> [1] https://github.com/dubbogo/getty
>

Re: [VOTE]: Accept dubbogo/getty donation

Posted by Justin Mclean <ju...@classsoftware.com>.
HI,

I assume this will be donated as a software grant?

Thanks,
Justin

Re: [VOTE]: Accept dubbogo/getty donation

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

And I see a few other contributors [1] How has the IP of their contribution been handled?

Thanks,
Justin


1. https://github.com/dubbogo/getty/graphs/contributors

Re: [VOTE]: Accept dubbogo/getty donation

Posted by xinming he <xi...@apache.org>.
+1 Accept

stocks alex <al...@apache.org> 于2020年7月12日周日 下午12:51写道:

> Hi guys,
>
> This is a formal vote to bring dubbogo/getty[1], which is depended
> by apache/dubbo-go, to Apache Dubbo project.
>
> What's more, the copyright of this repo is owned by myself and it has been
> written since 2016.
>
> Please vote:
>
> [ ] +1 Accept
> [ ] +0 No Opinion
> [ ] -1 Reject because...
>
> [1] https://github.com/dubbogo/getty
>