You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/29 06:38:57 UTC

[GitHub] [apisix] tzssangglass edited a comment on pull request #2886: feat: provide the ability to view plug-in types

tzssangglass edited a comment on pull request #2886:
URL: https://github.com/apache/apisix/pull/2886#issuecomment-735350940


   yes, i get the CI tip. 
   but the following case can be tested successfully in my local, and CI tested failed
   ```
   --- response_body eval
   qr/{"priority":0,"type":"other","name":"example-plugin","schema":{"properties":{"i":{"minimum":0,"type":"number"},"port":{"type":"integer"},"ip":{"type":"string"},"t":{"minItems":1,"type":"array"},"s":{"type":"string"}},"required":\["i"\],"type":"object"},"version":0.1}/
   ```
   
   and in order to pass the CI test, I need to change it like this
   ```
   --- response_body eval
   qr/\{"priority":0,"type":"other","name":"example-plugin","schema":\{"properties":\{"i":\{"minimum":0,"type":"number"\},"port":\{"type":"integer"\},"ip":\{"type":"string"\},"t":\{"minItems":1,"type":"array"\},"s":\{"type":"string"\}\},"required":\["i"\],"type":"object"\},"version":0.1\}/
   ```
   
   I want my local test results to be consistent with CI, what care needs to be taken.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org