You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Adrian Cole <no...@github.com> on 2014/10/29 06:12:18 UTC
[jclouds-labs-google] Use AutoValue to reduce bulk of Google Storage
value types. (#68)
One serialization test doesn't work (still looking at it). Then, I'll look at live tests. Anyway, looking like the sheers cut over 2.5K lines!
You can merge this Pull Request by running:
git pull https://github.com/adriancole/jclouds-labs-google adrian.auto-gce
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-google/pull/68
-- Commit Summary --
* Use AutoValue to reduce bulk of Google Storage value types.
-- File Changes --
M google-cloud-storage/pom.xml (6)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/GoogleCloudStorageApiMetadata.java (3)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/binders/MultipartUploadBinder.java (6)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/GCSBlobStore.java (38)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/functions/BucketToStorageMetadata.java (2)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/functions/ObjectListToStorageMetadata.java (11)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/functions/ObjectToBlobMetadata.java (45)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/strategy/internal/SequentialMultipartUploadStrategy.java (15)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/config/GoogleCloudStorageParserModule.java (16)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/Bucket.java (321)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/BucketAccessControls.java (118)
D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/DefaultObjectAccessControls.java (180)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/DomainResourceReferences.java (4)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/GCSObject.java (397)
D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/ListBucketAccessControls.java (112)
D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/ListDefaultObjectAccessControls.java (112)
D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/ListObjectAccessControls.java (112)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/ListPage.java (101)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/ObjectAccessControls.java (152)
A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/Owner.java (34)
A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/ProjectTeam.java (55)
D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/Resource.java (169)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/ResumableUpload.java (112)
D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/internal/Action.java (90)
D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/internal/BucketCors.java (147)
D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/internal/BucketLifeCycle.java (102)
D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/internal/Condition.java (150)
D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/internal/Logging.java (102)
D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/internal/Owner.java (99)
D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/internal/ProjectTeam.java (116)
D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/internal/Rule.java (110)
D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/internal/Versioning.java (94)
D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/internal/Website.java (102)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/templates/BucketAccessControlsTemplate.java (48)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/templates/BucketTemplate.java (99)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/templates/ComposeObjectTemplate.java (59)
D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/templates/DefaultObjectAccessControlsTemplate.java (65)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/templates/ObjectAccessControlsTemplate.java (46)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/templates/ObjectTemplate.java (82)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/BucketAccessControlsApi.java (7)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/DefaultObjectAccessControlsApi.java (51)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/ObjectAccessControlsApi.java (23)
R google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/internal/DomainUtils.java (2)
A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/internal/NullSafeCopies.java (39)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/parser/ParseToResumableUpload.java (11)
D google-cloud-storage/src/main/resources/META-INF/services/org.jclouds.apis.ApiMetadata (18)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/BucketAccessControlsApiExpectTest.java (10)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/BucketAccessControlsApiLiveTest.java (29)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/BucketApiExpectTest.java (2)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/BucketApiLiveTest.java (81)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/DefaultObjectAccessControlsApiExpectTest.java (16)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/DefaultObjectAccessControlsApiLiveTest.java (45)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/ObjectAccessControlsApiExpectTest.java (21)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/ObjectApiLiveTest.java (131)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/ResumableUploadApiLiveTest.java (40)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/BucketAclGetTest.java (6)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/BucketAclInsertTest.java (8)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/BucketAclListTest.java (30)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/BucketAclUpdateTest.java (7)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/BucketUpdateTest.java (28)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/DefaultObjectAclGetTest.java (14)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/DefaultObjectAclInsertTest.java (9)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/DefaultObjectAclListTest.java (23)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/FullBucketGetTest.java (54)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/NoAclBucketListTest.java (33)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/NoAclBucketTest.java (28)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/ObjectAclGetTest.java (11)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/ObjectAclInsertTest.java (7)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/ObjectAclListTest.java (18)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/ObjectAclUpdateTest.java (6)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-google/pull/68.patch
https://github.com/jclouds/jclouds-labs-google/pull/68.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/68
Re: [jclouds-labs-google] Use AutoValue to reduce bulk of Google
Storage value types. (#68)
Posted by Adrian Cole <no...@github.com>.
@nacx @ccustine warning.. I'll probably finish this in the next day or two.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/68#issuecomment-60875163
Re: [jclouds-labs-google] Use AutoValue to reduce bulk of Google
Storage value types. (#68)
Posted by Adrian Cole <no...@github.com>.
cherry-picked into master
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/68#issuecomment-61124879
Re: [jclouds-labs-google] Use AutoValue to reduce bulk of Google
Storage value types. (#68)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #187](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/187/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/68#issuecomment-60875398
Re: [jclouds-labs-google] Use AutoValue to reduce bulk of Google
Storage value types. (#68)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1585](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1585/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/68#issuecomment-61050016
Re: [jclouds-labs-google] Use AutoValue to reduce bulk of Google
Storage value types. (#68)
Posted by Adrian Cole <no...@github.com>.
@gk5885 biggest auto-savings, yet!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/68#issuecomment-61124487
Re: [jclouds-labs-google] Use AutoValue to reduce bulk of Google
Storage value types. (#68)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1588](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1588/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/68#issuecomment-61116477
Re: [jclouds-labs-google] Use AutoValue to reduce bulk of Google
Storage value types. (#68)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #191](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/191/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/68#issuecomment-61048744
Re: [jclouds-labs-google] Use AutoValue to reduce bulk of Google
Storage value types. (#68)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #193](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/193/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/68#issuecomment-61115441
Re: [jclouds-labs-google] Use AutoValue to reduce bulk of Google
Storage value types. (#68)
Posted by Andrea Turli <no...@github.com>.
lgtm, let's keep on with this diet!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/68#issuecomment-61122182
Re: [jclouds-labs-google] Use AutoValue to reduce bulk of Google
Storage value types. (#68)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1574](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1574/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/68#issuecomment-60875531
Re: [jclouds-labs-google] Use AutoValue to reduce bulk of Google
Storage value types. (#68)
Posted by Adrian Cole <no...@github.com>.
Made a note in https://issues.apache.org/jira/browse/JCLOUDS-750 about the jclouds/jclouds issue I'll need to sort out before this pull request will work without funky stuff. cc @jdaggett
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/68#issuecomment-60948007
Re: [jclouds-labs-google] Use AutoValue to reduce bulk of Google
Storage value types. (#68)
Posted by Adrian Cole <no...@github.com>.
> + public abstract Date timeDeleted();
> + public abstract StorageClass storageClass();
> + public abstract Long size();
> + public abstract String md5Hash();
> + public abstract URI mediaLink();
> + public abstract Map<String, String> metadata();
> + public abstract String contentEncoding();
> + public abstract String contentDisposition();
> + public abstract String contentLanguage();
> + public abstract String cacheControl();
> + public abstract List<ObjectAccessControls> acl();
> + public abstract Owner owner();
> + public abstract String crc32c();
> + public abstract Integer componentCount();
> +
> + public HashCode md5HashCode() {
ps not sure how much value these are. probably better to isolate these to call-site, namely converting to blob (since we require HashCode now there), and tests.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/68/files#r19520565
Re: [jclouds-labs-google] Use AutoValue to reduce bulk of Google
Storage value types. (#68)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1584](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1584/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/68#issuecomment-61048981
Re: [jclouds-labs-google] Use AutoValue to reduce bulk of Google
Storage value types. (#68)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #192](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/192/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/68#issuecomment-61049872