(cloudberry) 14/18: Fix up stale gp_default_storage_options comment (#15518)

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

maxyang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudberry.git

commit 1f7de781f434dd6a2a00c6ef90693d2664471d57
Author: David Kimura <dk...@vmware.com>
AuthorDate: Fri May 12 09:28:06 2023 -0700

    Fix up stale gp_default_storage_options comment (#15518)
    
    After Postgres 12 merge the GUC to set default table type was moved to
    default_table_access_method as hinted by the error message.
    
      SET gp_default_storage_options='appendonly=true';
      ERROR:  invalid storage option "appendonly"
      HINT:  For table access methods use "default_table_access_method" instead.
    
    Instead seems one should run:
    
      SET default_table_access_method='ao_row';
    
    Remove the stale comment that suggested otherwise.
---
 src/backend/utils/misc/guc_gp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/utils/misc/guc_gp.c b/src/backend/utils/misc/guc_gp.c
index ff8d828569..e881e05a01 100644
--- a/src/backend/utils/misc/guc_gp.c
+++ b/src/backend/utils/misc/guc_gp.c
@@ -431,7 +431,7 @@ bool		gp_reject_internal_tcp_conn = true;
 bool		gp_enable_segment_copy_checking = true;
 /*
  * Default storage options GUC.  Value is comma-separated name=value
- * pairs.  E.g. "appendonly=true,orientation=column"
+ * pairs.  E.g. "blocksize=32768,compresstype=none,checksum=true"
  */
 char	   *gp_default_storage_options = NULL;
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org