[GitHub] [iceberg] singhpk234 commented on a diff in pull request #7068: Spark 3.3: Use ProcedureInput in AddFilesProcedure

["singhpk234 (via GitHub)" <gi...@apache.org>]

singhpk234 commented on code in PR #7068:
URL: https://github.com/apache/iceberg/pull/7068#discussion_r1132879023


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/procedures/ProcedureInput.java:
##########
@@ -167,6 +167,11 @@ public Identifier ident(ProcedureParameter param) {
     return catalogAndIdent.identifier();
   }
 
+  public Identifier ident(ProcedureParameter param, CatalogPlugin defaultCatalog) {

Review Comment:
   [minor] can we use this function in L158, to re-use it ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org