You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/22 14:30:00 UTC

[GitHub] [spark] srowen commented on pull request #30484: [SPARK-33532][SQL] Remove unreachable branch in SpecificParquetRecordReaderBase.initialize method

srowen commented on pull request #30484:
URL: https://github.com/apache/spark/pull/30484#issuecomment-749567216


   At least for testing purposes here, you could add a check that it isn't null. Then at least tests would tell us whether that is true in tests. We may or may not leave in the check as an assert or something. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org