You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Sohan Jain <so...@fb.com> on 2011/08/04 19:05:08 UTC

Re: Review Request: HIVE-2319: Calling alter_table after changing partition key comment throws an exception

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1213/
-----------------------------------------------------------

(Updated 2011-08-04 17:05:08.413032)


Review request for hive and Paul Yang.


Changes
-------

Removed a change in TestMetaStoreEventListener.java that somehow snuck in this diff.


Summary
-------

Altering a table's partition key comments raises an InvalidOperationException. The partition key name and type should not be mutable, but the comment should be able to get changed.


This addresses bug HIVE-2319.
    https://issues.apache.org/jira/browse/HIVE-2319


Diffs (updated)
-----

  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1153927 
  trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 1153927 

Diff: https://reviews.apache.org/r/1213/diff


Testing
-------

Added some test cases to HiveMetaStore that pass.


Thanks,

Sohan