[incubator-superset] 01/01: fix: don't show filter popover on explore view load

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch metrics_no_popover
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit 526405d7a397b4e6cfaeef228e65a1580691fbbf
Author: Maxime Beauchemin <ma...@gmail.com>
AuthorDate: Tue Dec 3 00:14:55 2019 -0800

    fix: don't show filter popover on explore view load
    
    There's this confusing "feature" that I thought was a bug that shows the
    metric popover opened when entering the explore view when the filter
    comes from an active dashboard filter, based on the "fromFormData"
    attribute of the filter.
    
    The popover is confusing and often shows as misaligned with the actual
    element it's supposed to float over when overflowing.
---
 superset/assets/src/explore/components/AdhocFilterOption.jsx | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/superset/assets/src/explore/components/AdhocFilterOption.jsx b/superset/assets/src/explore/components/AdhocFilterOption.jsx
index 8b6adf6..0c9ce81 100644
--- a/superset/assets/src/explore/components/AdhocFilterOption.jsx
+++ b/superset/assets/src/explore/components/AdhocFilterOption.jsx
@@ -45,7 +45,7 @@ export default class AdhocFilterOption extends React.PureComponent {
     this.onPopoverResize = this.onPopoverResize.bind(this);
     this.onOverlayEntered = this.onOverlayEntered.bind(this);
     this.onOverlayExited = this.onOverlayExited.bind(this);
-    this.state = { overlayShown: !this.props.adhocFilter.fromFormData };
+    this.state = { overlayShown: false };
   }
 
   onPopoverResize() {
@@ -90,7 +90,6 @@ export default class AdhocFilterOption extends React.PureComponent {
         overlay={overlay}
         rootClose
         shouldUpdatePosition
-        defaultOverlayShown={!adhocFilter.fromFormData}
         onEntered={this.onOverlayEntered}
         onExited={this.onOverlayExited}
       >