You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2010/01/12 05:06:54 UTC
[jira] Created: (CASSANDRA-688) cache refinements
cache refinements
-----------------
Key: CASSANDRA-688
URL: https://issues.apache.org/jira/browse/CASSANDRA-688
Project: Cassandra
Issue Type: Improvement
Components: Core
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Priority: Minor
Fix For: 0.9
(continued from CASSANDRA-678)
- instrument keycache in a way that doesn't make performance suck
- add Ryan's suggestion of absolute row count config option
- adjust cache size live
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-688) cache refinements
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801622#action_12801622 ]
Jonathan Ellis commented on CASSANDRA-688:
------------------------------------------
part of moving classes from utils package to cache package, apparently
> cache refinements
> -----------------
>
> Key: CASSANDRA-688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-688
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-move-cache-classes-to-cassandra.cache-package.txt, 0002-extract-InstrumentingCache-from-jmx-code.txt, 0003-add-JMXAggregatingCache-to-present-all-the-SSTR-keycac.txt, 0004-change-RowsCachedFraction-option-to-RowsCached-specifi.txt, 0005-allow-setting-row-cache-size-from-jmx.txt, 0006-approximate-capacity-setting-in-key-cache-by-adjusting.txt
>
>
> (continued from CASSANDRA-678)
> - instrument keycache in a way that doesn't make performance suck
> - add Ryan's suggestion of absolute row count config option
> - adjust cache size live
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-688) cache refinements
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802239#action_12802239 ]
Hudson commented on CASSANDRA-688:
----------------------------------
Integrated in Cassandra #328 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/328/])
approximate capacity setting in key cache by adjusting each sstable cache by the desired ratio
patch by jbellis; reviewed by goffinet for
allow setting row cache size from jmx
patch by jbellis; reviewed by goffinet for
change RowsCachedFraction option to RowsCached, specified either as an absolute number or as a percentage of rows in the CF
patch by jbellis; reviewed by goffinet for
add JMXAggregatingCache to present all the SSTR keycaches in one mbean
patch by jbellis; reviewed by goffinet for
extract InstrumentingCache from jmx code
patch by jbellis; reviewed by goffinet for
move cache classes to cassandra.cache package.
patch by jbellis; reviewed by goffinet for
> cache refinements
> -----------------
>
> Key: CASSANDRA-688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-688
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 0001-move-cache-classes-to-cassandra.cache-package.txt, 0002-extract-InstrumentingCache-from-jmx-code.txt, 0003-add-JMXAggregatingCache-to-present-all-the-SSTR-keycac.txt, 0004-change-RowsCachedFraction-option-to-RowsCached-specifi.txt, 0005-allow-setting-row-cache-size-from-jmx.txt, 0006-approximate-capacity-setting-in-key-cache-by-adjusting.txt
>
>
> (continued from CASSANDRA-678)
> - instrument keycache in a way that doesn't make performance suck
> - add Ryan's suggestion of absolute row count config option
> - adjust cache size live
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-688) cache refinements
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-688:
-------------------------------------
rows are per cf, keys are per sstable.
the mbean report (and allows setting) the key totals per-cf too, so the sstable business is mostly an implementation detail.
> cache refinements
> -----------------
>
> Key: CASSANDRA-688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-688
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-move-cache-classes-to-cassandra.cache-package.txt, 0002-extract-InstrumentingCache-from-jmx-code.txt, 0003-add-JMXAggregatingCache-to-present-all-the-SSTR-keycac.txt, 0004-change-RowsCachedFraction-option-to-RowsCached-specifi.txt, 0005-allow-setting-row-cache-size-from-jmx.txt, 0006-approximate-capacity-setting-in-key-cache-by-adjusting.txt
>
>
> (continued from CASSANDRA-678)
> - instrument keycache in a way that doesn't make performance suck
> - add Ryan's suggestion of absolute row count config option
> - adjust cache size live
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-688) cache refinements
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-688:
-------------------------------------
Attachment: 0006-approximate-capacity-setting-in-key-cache-by-adjusting.txt
0005-allow-setting-row-cache-size-from-jmx.txt
0004-change-RowsCachedFraction-option-to-RowsCached-specifi.txt
0003-add-JMXAggregatingCache-to-present-all-the-SSTR-keycac.txt
0002-extract-InstrumentingCache-from-jmx-code.txt
0001-move-cache-classes-to-cassandra.cache-package.txt
> cache refinements
> -----------------
>
> Key: CASSANDRA-688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-688
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-move-cache-classes-to-cassandra.cache-package.txt, 0002-extract-InstrumentingCache-from-jmx-code.txt, 0003-add-JMXAggregatingCache-to-present-all-the-SSTR-keycac.txt, 0004-change-RowsCachedFraction-option-to-RowsCached-specifi.txt, 0005-allow-setting-row-cache-size-from-jmx.txt, 0006-approximate-capacity-setting-in-key-cache-by-adjusting.txt
>
>
> (continued from CASSANDRA-678)
> - instrument keycache in a way that doesn't make performance suck
> - add Ryan's suggestion of absolute row count config option
> - adjust cache size live
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-688) cache refinements
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801652#action_12801652 ]
Jonathan Ellis commented on CASSANDRA-688:
------------------------------------------
right, capacity is editable, that's how jconsole exposes settables that have a corresponding getter
> cache refinements
> -----------------
>
> Key: CASSANDRA-688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-688
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-move-cache-classes-to-cassandra.cache-package.txt, 0002-extract-InstrumentingCache-from-jmx-code.txt, 0003-add-JMXAggregatingCache-to-present-all-the-SSTR-keycac.txt, 0004-change-RowsCachedFraction-option-to-RowsCached-specifi.txt, 0005-allow-setting-row-cache-size-from-jmx.txt, 0006-approximate-capacity-setting-in-key-cache-by-adjusting.txt
>
>
> (continued from CASSANDRA-678)
> - instrument keycache in a way that doesn't make performance suck
> - add Ryan's suggestion of absolute row count config option
> - adjust cache size live
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CASSANDRA-688) cache refinements
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800314#action_12800314 ]
Jonathan Ellis edited comment on CASSANDRA-688 at 1/14/10 7:24 PM:
-------------------------------------------------------------------
rows are per cf, keys are per sstable.
the mbean reports (and allows setting) the key totals per-cf too, so the sstable business is mostly an implementation detail.
was (Author: jbellis):
rows are per cf, keys are per sstable.
the mbean report (and allows setting) the key totals per-cf too, so the sstable business is mostly an implementation detail.
> cache refinements
> -----------------
>
> Key: CASSANDRA-688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-688
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-move-cache-classes-to-cassandra.cache-package.txt, 0002-extract-InstrumentingCache-from-jmx-code.txt, 0003-add-JMXAggregatingCache-to-present-all-the-SSTR-keycac.txt, 0004-change-RowsCachedFraction-option-to-RowsCached-specifi.txt, 0005-allow-setting-row-cache-size-from-jmx.txt, 0006-approximate-capacity-setting-in-key-cache-by-adjusting.txt
>
>
> (continued from CASSANDRA-678)
> - instrument keycache in a way that doesn't make performance suck
> - add Ryan's suggestion of absolute row count config option
> - adjust cache size live
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-688) cache refinements
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801646#action_12801646 ]
Jonathan Ellis commented on CASSANDRA-688:
------------------------------------------
it's in db -> caches in JConsole
> cache refinements
> -----------------
>
> Key: CASSANDRA-688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-688
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-move-cache-classes-to-cassandra.cache-package.txt, 0002-extract-InstrumentingCache-from-jmx-code.txt, 0003-add-JMXAggregatingCache-to-present-all-the-SSTR-keycac.txt, 0004-change-RowsCachedFraction-option-to-RowsCached-specifi.txt, 0005-allow-setting-row-cache-size-from-jmx.txt, 0006-approximate-capacity-setting-in-key-cache-by-adjusting.txt
>
>
> (continued from CASSANDRA-678)
> - instrument keycache in a way that doesn't make performance suck
> - add Ryan's suggestion of absolute row count config option
> - adjust cache size live
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-688) cache refinements
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801650#action_12801650 ]
Chris Goffinet commented on CASSANDRA-688:
------------------------------------------
Yes, that's where I first looked. Am I missing something then? Only thing under listed I see is:
DB -> Caches -> <Keyspace> -> <CF>RowCache ->
Size, Capacity, HitRate
No operations or way to setCapacity.
> cache refinements
> -----------------
>
> Key: CASSANDRA-688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-688
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-move-cache-classes-to-cassandra.cache-package.txt, 0002-extract-InstrumentingCache-from-jmx-code.txt, 0003-add-JMXAggregatingCache-to-present-all-the-SSTR-keycac.txt, 0004-change-RowsCachedFraction-option-to-RowsCached-specifi.txt, 0005-allow-setting-row-cache-size-from-jmx.txt, 0006-approximate-capacity-setting-in-key-cache-by-adjusting.txt
>
>
> (continued from CASSANDRA-678)
> - instrument keycache in a way that doesn't make performance suck
> - add Ryan's suggestion of absolute row count config option
> - adjust cache size live
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-688) cache refinements
Posted by "Nate McCall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801033#action_12801033 ]
Nate McCall commented on CASSANDRA-688:
---------------------------------------
Great addition! Just a nitpicky documentation issue - the changes in storage-conf.xml are worded to suggest that only values between 0-1 are acceptable for RowsCached whereas in the one example the value is 1000 and 10% in another. Values between 0-1, integers and percentages all appear to work as expected.
Perhaps changing the comment like so might make it more clear:
> cache refinements
> -----------------
>
> Key: CASSANDRA-688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-688
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-move-cache-classes-to-cassandra.cache-package.txt, 0002-extract-InstrumentingCache-from-jmx-code.txt, 0003-add-JMXAggregatingCache-to-present-all-the-SSTR-keycac.txt, 0004-change-RowsCachedFraction-option-to-RowsCached-specifi.txt, 0005-allow-setting-row-cache-size-from-jmx.txt, 0006-approximate-capacity-setting-in-key-cache-by-adjusting.txt
>
>
> (continued from CASSANDRA-678)
> - instrument keycache in a way that doesn't make performance suck
> - add Ryan's suggestion of absolute row count config option
> - adjust cache size live
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-688) cache refinements
Posted by "Ryan King (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800322#action_12800322 ]
Ryan King commented on CASSANDRA-688:
-------------------------------------
Sorry, I misread the patches then. This is awesome.
> cache refinements
> -----------------
>
> Key: CASSANDRA-688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-688
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-move-cache-classes-to-cassandra.cache-package.txt, 0002-extract-InstrumentingCache-from-jmx-code.txt, 0003-add-JMXAggregatingCache-to-present-all-the-SSTR-keycac.txt, 0004-change-RowsCachedFraction-option-to-RowsCached-specifi.txt, 0005-allow-setting-row-cache-size-from-jmx.txt, 0006-approximate-capacity-setting-in-key-cache-by-adjusting.txt
>
>
> (continued from CASSANDRA-678)
> - instrument keycache in a way that doesn't make performance suck
> - add Ryan's suggestion of absolute row count config option
> - adjust cache size live
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-688) cache refinements
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801653#action_12801653 ]
Chris Goffinet commented on CASSANDRA-688:
------------------------------------------
Sigh, stupid thing :-) Under operations, it clearly shows as textbox, and being able to set. I have reviewed the patches, please remove the lakshman part and we can commit this. Let's add nodeprobe support in CASSANDRA-708
> cache refinements
> -----------------
>
> Key: CASSANDRA-688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-688
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-move-cache-classes-to-cassandra.cache-package.txt, 0002-extract-InstrumentingCache-from-jmx-code.txt, 0003-add-JMXAggregatingCache-to-present-all-the-SSTR-keycac.txt, 0004-change-RowsCachedFraction-option-to-RowsCached-specifi.txt, 0005-allow-setting-row-cache-size-from-jmx.txt, 0006-approximate-capacity-setting-in-key-cache-by-adjusting.txt
>
>
> (continued from CASSANDRA-678)
> - instrument keycache in a way that doesn't make performance suck
> - add Ryan's suggestion of absolute row count config option
> - adjust cache size live
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-688) cache refinements
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800101#action_12800101 ]
Jonathan Ellis commented on CASSANDRA-688:
------------------------------------------
06
approximate capacity setting in key cache by adjusting each sstable cache by the desired ratio
05
allow setting row cache size from jmx
04
change RowsCachedFraction option to RowsCached, specified either as an absolute number or as a percentage of rows in the
03
add JMXAggregatingCache to present all the SSTR keycaches in one mbean
02
extract InstrumentingCache from jmx code
01
move cache classes to cassandra.cache package
> cache refinements
> -----------------
>
> Key: CASSANDRA-688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-688
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-move-cache-classes-to-cassandra.cache-package.txt, 0002-extract-InstrumentingCache-from-jmx-code.txt, 0003-add-JMXAggregatingCache-to-present-all-the-SSTR-keycac.txt, 0004-change-RowsCachedFraction-option-to-RowsCached-specifi.txt, 0005-allow-setting-row-cache-size-from-jmx.txt, 0006-approximate-capacity-setting-in-key-cache-by-adjusting.txt
>
>
> (continued from CASSANDRA-678)
> - instrument keycache in a way that doesn't make performance suck
> - add Ryan's suggestion of absolute row count config option
> - adjust cache size live
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-688) cache refinements
Posted by "Ryan King (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800282#action_12800282 ]
Ryan King commented on CASSANDRA-688:
-------------------------------------
I've only looked through the patches briefly, and being able to set the capacity by rows is certainly an improvement, but it would be nice if it weren't per-SSTable, but per CF. I know that the cache-per-CF thing didn't work well, so maybe this isn't possible.
> cache refinements
> -----------------
>
> Key: CASSANDRA-688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-688
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-move-cache-classes-to-cassandra.cache-package.txt, 0002-extract-InstrumentingCache-from-jmx-code.txt, 0003-add-JMXAggregatingCache-to-present-all-the-SSTR-keycac.txt, 0004-change-RowsCachedFraction-option-to-RowsCached-specifi.txt, 0005-allow-setting-row-cache-size-from-jmx.txt, 0006-approximate-capacity-setting-in-key-cache-by-adjusting.txt
>
>
> (continued from CASSANDRA-678)
> - instrument keycache in a way that doesn't make performance suck
> - add Ryan's suggestion of absolute row count config option
> - adjust cache size live
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-688) cache refinements
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801627#action_12801627 ]
Chris Goffinet commented on CASSANDRA-688:
------------------------------------------
Can you add nodeprobe support for this? I also noticed using JConsole, the MBean for JMXInstrumentedCache is never exposed anywhere? Can we namespace it in similar fashion of how we do other operations?
> cache refinements
> -----------------
>
> Key: CASSANDRA-688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-688
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-move-cache-classes-to-cassandra.cache-package.txt, 0002-extract-InstrumentingCache-from-jmx-code.txt, 0003-add-JMXAggregatingCache-to-present-all-the-SSTR-keycac.txt, 0004-change-RowsCachedFraction-option-to-RowsCached-specifi.txt, 0005-allow-setting-row-cache-size-from-jmx.txt, 0006-approximate-capacity-setting-in-key-cache-by-adjusting.txt
>
>
> (continued from CASSANDRA-678)
> - instrument keycache in a way that doesn't make performance suck
> - add Ryan's suggestion of absolute row count config option
> - adjust cache size live
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CASSANDRA-688) cache refinements
Posted by "Nate McCall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801033#action_12801033 ]
Nate McCall edited comment on CASSANDRA-688 at 1/16/10 12:36 AM:
-----------------------------------------------------------------
Great addition! Just a nitpicky documentation issue - the changes in storage-conf.xml are worded to suggest that only values between 0-1 are acceptable for RowsCached whereas in the one example the value is 1000 and 10% in another. Values between 0-1, integers and percentages all appear to work as expected.
Perhaps changing the comment like so might make it more clear:
~ The optional RowsCached attribute specifies the number of rows
~ whose entire contents we cache in memory, either as a fixed number
~ of rows, a percent of rows in the ColumnFamily, or as with key caching,
~ a value between 0 and 1. Do not use this on ColumnFamilies with
~ large rows, or ColumnFamilies with high write:read ratios.
~ The default 0 disables it entirely.
Thanks again, this is going to be a huge help.
was (Author: zznate):
Great addition! Just a nitpicky documentation issue - the changes in storage-conf.xml are worded to suggest that only values between 0-1 are acceptable for RowsCached whereas in the one example the value is 1000 and 10% in another. Values between 0-1, integers and percentages all appear to work as expected.
Perhaps changing the comment like so might make it more clear:
> cache refinements
> -----------------
>
> Key: CASSANDRA-688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-688
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-move-cache-classes-to-cassandra.cache-package.txt, 0002-extract-InstrumentingCache-from-jmx-code.txt, 0003-add-JMXAggregatingCache-to-present-all-the-SSTR-keycac.txt, 0004-change-RowsCachedFraction-option-to-RowsCached-specifi.txt, 0005-allow-setting-row-cache-size-from-jmx.txt, 0006-approximate-capacity-setting-in-key-cache-by-adjusting.txt
>
>
> (continued from CASSANDRA-678)
> - instrument keycache in a way that doesn't make performance suck
> - add Ryan's suggestion of absolute row count config option
> - adjust cache size live
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-688) cache refinements
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801538#action_12801538 ]
Chris Goffinet commented on CASSANDRA-688:
------------------------------------------
Jonathan, what is this? ;-)
+/**
+ * Created by IntelliJ IDEA.
+ * User: lakshman
+ * Date: Aug 16, 2005
+ * Time: 1:08:58 PM
+ * To change this template use File | Settings | File Templates.
+ */
> cache refinements
> -----------------
>
> Key: CASSANDRA-688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-688
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-move-cache-classes-to-cassandra.cache-package.txt, 0002-extract-InstrumentingCache-from-jmx-code.txt, 0003-add-JMXAggregatingCache-to-present-all-the-SSTR-keycac.txt, 0004-change-RowsCachedFraction-option-to-RowsCached-specifi.txt, 0005-allow-setting-row-cache-size-from-jmx.txt, 0006-approximate-capacity-setting-in-key-cache-by-adjusting.txt
>
>
> (continued from CASSANDRA-678)
> - instrument keycache in a way that doesn't make performance suck
> - add Ryan's suggestion of absolute row count config option
> - adjust cache size live
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-688) cache refinements
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801050#action_12801050 ]
Jonathan Ellis commented on CASSANDRA-688:
------------------------------------------
Thanks for catching that.
> cache refinements
> -----------------
>
> Key: CASSANDRA-688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-688
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-move-cache-classes-to-cassandra.cache-package.txt, 0002-extract-InstrumentingCache-from-jmx-code.txt, 0003-add-JMXAggregatingCache-to-present-all-the-SSTR-keycac.txt, 0004-change-RowsCachedFraction-option-to-RowsCached-specifi.txt, 0005-allow-setting-row-cache-size-from-jmx.txt, 0006-approximate-capacity-setting-in-key-cache-by-adjusting.txt
>
>
> (continued from CASSANDRA-678)
> - instrument keycache in a way that doesn't make performance suck
> - add Ryan's suggestion of absolute row count config option
> - adjust cache size live
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-688) cache refinements
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801180#action_12801180 ]
Jonathan Ellis commented on CASSANDRA-688:
------------------------------------------
I doubt it.
> cache refinements
> -----------------
>
> Key: CASSANDRA-688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-688
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-move-cache-classes-to-cassandra.cache-package.txt, 0002-extract-InstrumentingCache-from-jmx-code.txt, 0003-add-JMXAggregatingCache-to-present-all-the-SSTR-keycac.txt, 0004-change-RowsCachedFraction-option-to-RowsCached-specifi.txt, 0005-allow-setting-row-cache-size-from-jmx.txt, 0006-approximate-capacity-setting-in-key-cache-by-adjusting.txt
>
>
> (continued from CASSANDRA-678)
> - instrument keycache in a way that doesn't make performance suck
> - add Ryan's suggestion of absolute row count config option
> - adjust cache size live
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-688) cache refinements
Posted by "Nate McCall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801128#action_12801128 ]
Nate McCall commented on CASSANDRA-688:
---------------------------------------
Would it make sense to expose ConcurrentLinkedHashMap's EvictionPolicy as an additional configuration option?
> cache refinements
> -----------------
>
> Key: CASSANDRA-688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-688
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-move-cache-classes-to-cassandra.cache-package.txt, 0002-extract-InstrumentingCache-from-jmx-code.txt, 0003-add-JMXAggregatingCache-to-present-all-the-SSTR-keycac.txt, 0004-change-RowsCachedFraction-option-to-RowsCached-specifi.txt, 0005-allow-setting-row-cache-size-from-jmx.txt, 0006-approximate-capacity-setting-in-key-cache-by-adjusting.txt
>
>
> (continued from CASSANDRA-678)
> - instrument keycache in a way that doesn't make performance suck
> - add Ryan's suggestion of absolute row count config option
> - adjust cache size live
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.