You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "CRZbulabula (via GitHub)" <gi...@apache.org> on 2023/02/03 03:42:30 UTC
[GitHub] [iotdb] CRZbulabula opened a new pull request, #8971: [IOTDB-5451] Support cluster Database heterogeneous by ALTER SQL
CRZbulabula opened a new pull request, #8971:
URL: https://github.com/apache/iotdb/pull/8971
**Major Improvement:**
Our cluster does not currently support the Database heterogeneous scenario. Therefore, this PR will support the Database heterogeneous, which including different RegionGroupNum by ALTER SQL.
I've added test cases in IoTDBDatabaseRegionControlIT.
You can see [this](https://apache-iotdb.feishu.cn/docx/Pm1mdwGm0oftHbx6FYgcAZV3nCf) doc for main modification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] CRZbulabula merged pull request #8971: [IOTDB-5451] Support cluster Database heterogeneous by ALTER SQL
Posted by "CRZbulabula (via GitHub)" <gi...@apache.org>.
CRZbulabula merged PR #8971:
URL: https://github.com/apache/iotdb/pull/8971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8971: [IOTDB-5451] Support cluster Database heterogeneous by ALTER SQL
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #8971:
URL: https://github.com/apache/iotdb/pull/8971#issuecomment-1414837231
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=8971)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=CODE_SMELL) [24 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8971&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8971&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8971&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8971&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8971: [IOTDB-5451] Support cluster Database heterogeneous by ALTER SQL
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #8971:
URL: https://github.com/apache/iotdb/pull/8971#issuecomment-1420079988
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=8971)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=CODE_SMELL) [23 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8971&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8971&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8971&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8971&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8971: [IOTDB-5451] Support cluster Database heterogeneous by ALTER SQL
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #8971:
URL: https://github.com/apache/iotdb/pull/8971#issuecomment-1420284619
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=8971)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=CODE_SMELL) [24 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8971&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8971&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8971&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8971&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8971&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] OneSizeFitsQuorum commented on a diff in pull request #8971: [IOTDB-5451] Support cluster Database heterogeneous by ALTER SQL
Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum commented on code in PR #8971:
URL: https://github.com/apache/iotdb/pull/8971#discussion_r1099617485
##########
confignode/src/main/java/org/apache/iotdb/confignode/consensus/request/write/storagegroup/DatabaseSchemaPlan.java:
##########
@@ -28,17 +29,17 @@
import java.nio.ByteBuffer;
import java.util.Objects;
-public class SetStorageGroupPlan extends ConfigPhysicalPlan {
+public class DatabaseSchemaPlan extends ConfigPhysicalPlan {
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] CRZbulabula commented on a diff in pull request #8971: [IOTDB-5451] Support cluster Database heterogeneous by ALTER SQL
Posted by "CRZbulabula (via GitHub)" <gi...@apache.org>.
CRZbulabula commented on code in PR #8971:
URL: https://github.com/apache/iotdb/pull/8971#discussion_r1098237184
##########
confignode/src/main/java/org/apache/iotdb/confignode/service/thrift/ConfigNodeRPCServiceProcessor.java:
##########
@@ -275,80 +274,123 @@ public TShowVariablesResp showVariables() {
}
@Override
- public TSStatus setStorageGroup(TSetStorageGroupReq req) throws TException {
- TStorageGroupSchema storageGroupSchema = req.getStorageGroup();
+ public TSStatus setDatabase(TStorageGroupSchema databaseSchema) {
TSStatus errorResp = null;
// Set default configurations if necessary
- if (!storageGroupSchema.isSetTTL()) {
- storageGroupSchema.setTTL(CommonDescriptor.getInstance().getConfig().getDefaultTTLInMs());
- } else if (storageGroupSchema.getTTL() <= 0) {
+ if (!databaseSchema.isSetTTL()) {
+ databaseSchema.setTTL(CommonDescriptor.getInstance().getConfig().getDefaultTTLInMs());
+ } else if (databaseSchema.getTTL() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage("Failed to create database. The TTL should be positive.");
}
- if (!storageGroupSchema.isSetSchemaReplicationFactor()) {
- storageGroupSchema.setSchemaReplicationFactor(
- CONFIG_NODE_CONFIG.getSchemaReplicationFactor());
- } else if (storageGroupSchema.getSchemaReplicationFactor() <= 0) {
+ if (!databaseSchema.isSetSchemaReplicationFactor()) {
+ databaseSchema.setSchemaReplicationFactor(CONFIG_NODE_CONFIG.getSchemaReplicationFactor());
+ } else if (databaseSchema.getSchemaReplicationFactor() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage(
"Failed to create database. The schemaReplicationFactor should be positive.");
}
- if (!storageGroupSchema.isSetDataReplicationFactor()) {
- storageGroupSchema.setDataReplicationFactor(CONFIG_NODE_CONFIG.getDataReplicationFactor());
- } else if (storageGroupSchema.getDataReplicationFactor() <= 0) {
+ if (!databaseSchema.isSetDataReplicationFactor()) {
+ databaseSchema.setDataReplicationFactor(CONFIG_NODE_CONFIG.getDataReplicationFactor());
+ } else if (databaseSchema.getDataReplicationFactor() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage(
"Failed to create database. The dataReplicationFactor should be positive.");
}
- if (!storageGroupSchema.isSetTimePartitionInterval()) {
- storageGroupSchema.setTimePartitionInterval(CONFIG_NODE_CONFIG.getTimePartitionInterval());
- } else if (storageGroupSchema.getTimePartitionInterval() <= 0) {
+ if (!databaseSchema.isSetTimePartitionInterval()) {
+ databaseSchema.setTimePartitionInterval(CONFIG_NODE_CONFIG.getTimePartitionInterval());
+ } else if (databaseSchema.getTimePartitionInterval() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage(
"Failed to create database. The timePartitionInterval should be positive.");
}
- if (!storageGroupSchema.isSetMinSchemaRegionGroupNum()) {
- storageGroupSchema.setMinSchemaRegionGroupNum(
+ if (!databaseSchema.isSetMinSchemaRegionGroupNum()) {
+ databaseSchema.setMinSchemaRegionGroupNum(
CONFIG_NODE_CONFIG.getDefaultSchemaRegionGroupNumPerDatabase());
- } else if (storageGroupSchema.getMinSchemaRegionGroupNum() <= 0) {
+ } else if (databaseSchema.getMinSchemaRegionGroupNum() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage(
"Failed to create database. The schemaRegionGroupNum should be positive.");
}
- if (!storageGroupSchema.isSetMinDataRegionGroupNum()) {
- storageGroupSchema.setMinDataRegionGroupNum(
+ if (!databaseSchema.isSetMinDataRegionGroupNum()) {
+ databaseSchema.setMinDataRegionGroupNum(
CONFIG_NODE_CONFIG.getDefaultDataRegionGroupNumPerDatabase());
- } else if (storageGroupSchema.getMinDataRegionGroupNum() <= 0) {
+ } else if (databaseSchema.getMinDataRegionGroupNum() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage("Failed to create database. The dataRegionGroupNum should be positive.");
}
if (errorResp != null) {
- LOGGER.warn("Execute SetStorageGroupRequest {} with result {}", req, errorResp);
+ LOGGER.warn("Execute SetDatabase: {} with result: {}", databaseSchema, errorResp);
return errorResp;
}
// The maxRegionGroupNum is equal to the minRegionGroupNum when initialize
- storageGroupSchema.setMaxSchemaRegionGroupNum(storageGroupSchema.getMinSchemaRegionGroupNum());
- storageGroupSchema.setMaxDataRegionGroupNum(storageGroupSchema.getMinDataRegionGroupNum());
+ databaseSchema.setMaxSchemaRegionGroupNum(databaseSchema.getMinSchemaRegionGroupNum());
+ databaseSchema.setMaxDataRegionGroupNum(databaseSchema.getMinDataRegionGroupNum());
- SetStorageGroupPlan setReq = new SetStorageGroupPlan(storageGroupSchema);
- TSStatus resp = configManager.setStorageGroup(setReq);
+ DatabaseSchemaPlan setPlan =
+ new DatabaseSchemaPlan(ConfigPhysicalPlanType.CreateDatabase, databaseSchema);
+ TSStatus resp = configManager.setDatabase(setPlan);
// Print log to record the ConfigNode that performs the set SetStorageGroupRequest
- LOGGER.info("Execute SetStorageGroupRequest {} with result {}", req, resp);
+ LOGGER.info("Execute SetDatabase: {} with result: {}", databaseSchema, resp);
+
+ return resp;
+ }
+
+ @Override
+ public TSStatus alterDatabase(TStorageGroupSchema databaseSchema) {
+ TSStatus errorResp = null;
+
+ // TODO: Support alter the following fields
+ if (databaseSchema.isSetTTL()) {
+ errorResp =
+ new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
+ .setMessage("Failed to alter database. Doesn't support ALTER TTL yet.");
+ }
+ if (databaseSchema.isSetSchemaReplicationFactor()) {
+ errorResp =
+ new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
Review Comment:
I want to print a log for this unsupport scenario. If I return here, the log print will be repeated for several times.
##########
confignode/src/main/java/org/apache/iotdb/confignode/service/thrift/ConfigNodeRPCServiceProcessor.java:
##########
@@ -275,80 +274,123 @@ public TShowVariablesResp showVariables() {
}
@Override
- public TSStatus setStorageGroup(TSetStorageGroupReq req) throws TException {
- TStorageGroupSchema storageGroupSchema = req.getStorageGroup();
+ public TSStatus setDatabase(TStorageGroupSchema databaseSchema) {
TSStatus errorResp = null;
// Set default configurations if necessary
- if (!storageGroupSchema.isSetTTL()) {
- storageGroupSchema.setTTL(CommonDescriptor.getInstance().getConfig().getDefaultTTLInMs());
- } else if (storageGroupSchema.getTTL() <= 0) {
+ if (!databaseSchema.isSetTTL()) {
+ databaseSchema.setTTL(CommonDescriptor.getInstance().getConfig().getDefaultTTLInMs());
+ } else if (databaseSchema.getTTL() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage("Failed to create database. The TTL should be positive.");
}
- if (!storageGroupSchema.isSetSchemaReplicationFactor()) {
- storageGroupSchema.setSchemaReplicationFactor(
- CONFIG_NODE_CONFIG.getSchemaReplicationFactor());
- } else if (storageGroupSchema.getSchemaReplicationFactor() <= 0) {
+ if (!databaseSchema.isSetSchemaReplicationFactor()) {
+ databaseSchema.setSchemaReplicationFactor(CONFIG_NODE_CONFIG.getSchemaReplicationFactor());
+ } else if (databaseSchema.getSchemaReplicationFactor() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage(
"Failed to create database. The schemaReplicationFactor should be positive.");
}
- if (!storageGroupSchema.isSetDataReplicationFactor()) {
- storageGroupSchema.setDataReplicationFactor(CONFIG_NODE_CONFIG.getDataReplicationFactor());
- } else if (storageGroupSchema.getDataReplicationFactor() <= 0) {
+ if (!databaseSchema.isSetDataReplicationFactor()) {
+ databaseSchema.setDataReplicationFactor(CONFIG_NODE_CONFIG.getDataReplicationFactor());
+ } else if (databaseSchema.getDataReplicationFactor() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage(
"Failed to create database. The dataReplicationFactor should be positive.");
}
- if (!storageGroupSchema.isSetTimePartitionInterval()) {
- storageGroupSchema.setTimePartitionInterval(CONFIG_NODE_CONFIG.getTimePartitionInterval());
- } else if (storageGroupSchema.getTimePartitionInterval() <= 0) {
+ if (!databaseSchema.isSetTimePartitionInterval()) {
+ databaseSchema.setTimePartitionInterval(CONFIG_NODE_CONFIG.getTimePartitionInterval());
+ } else if (databaseSchema.getTimePartitionInterval() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage(
"Failed to create database. The timePartitionInterval should be positive.");
}
- if (!storageGroupSchema.isSetMinSchemaRegionGroupNum()) {
- storageGroupSchema.setMinSchemaRegionGroupNum(
+ if (!databaseSchema.isSetMinSchemaRegionGroupNum()) {
+ databaseSchema.setMinSchemaRegionGroupNum(
CONFIG_NODE_CONFIG.getDefaultSchemaRegionGroupNumPerDatabase());
- } else if (storageGroupSchema.getMinSchemaRegionGroupNum() <= 0) {
+ } else if (databaseSchema.getMinSchemaRegionGroupNum() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage(
"Failed to create database. The schemaRegionGroupNum should be positive.");
}
- if (!storageGroupSchema.isSetMinDataRegionGroupNum()) {
- storageGroupSchema.setMinDataRegionGroupNum(
+ if (!databaseSchema.isSetMinDataRegionGroupNum()) {
+ databaseSchema.setMinDataRegionGroupNum(
CONFIG_NODE_CONFIG.getDefaultDataRegionGroupNumPerDatabase());
- } else if (storageGroupSchema.getMinDataRegionGroupNum() <= 0) {
+ } else if (databaseSchema.getMinDataRegionGroupNum() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage("Failed to create database. The dataRegionGroupNum should be positive.");
}
if (errorResp != null) {
- LOGGER.warn("Execute SetStorageGroupRequest {} with result {}", req, errorResp);
+ LOGGER.warn("Execute SetDatabase: {} with result: {}", databaseSchema, errorResp);
return errorResp;
}
// The maxRegionGroupNum is equal to the minRegionGroupNum when initialize
- storageGroupSchema.setMaxSchemaRegionGroupNum(storageGroupSchema.getMinSchemaRegionGroupNum());
- storageGroupSchema.setMaxDataRegionGroupNum(storageGroupSchema.getMinDataRegionGroupNum());
+ databaseSchema.setMaxSchemaRegionGroupNum(databaseSchema.getMinSchemaRegionGroupNum());
+ databaseSchema.setMaxDataRegionGroupNum(databaseSchema.getMinDataRegionGroupNum());
- SetStorageGroupPlan setReq = new SetStorageGroupPlan(storageGroupSchema);
- TSStatus resp = configManager.setStorageGroup(setReq);
+ DatabaseSchemaPlan setPlan =
+ new DatabaseSchemaPlan(ConfigPhysicalPlanType.CreateDatabase, databaseSchema);
+ TSStatus resp = configManager.setDatabase(setPlan);
// Print log to record the ConfigNode that performs the set SetStorageGroupRequest
- LOGGER.info("Execute SetStorageGroupRequest {} with result {}", req, resp);
+ LOGGER.info("Execute SetDatabase: {} with result: {}", databaseSchema, resp);
+
+ return resp;
+ }
+
+ @Override
+ public TSStatus alterDatabase(TStorageGroupSchema databaseSchema) {
+ TSStatus errorResp = null;
+
+ // TODO: Support alter the following fields
+ if (databaseSchema.isSetTTL()) {
+ errorResp =
Review Comment:
I want to print a log for this unsupport scenario. If I return here, the log print will be repeated for several times.
##########
confignode/src/main/java/org/apache/iotdb/confignode/consensus/request/write/storagegroup/DatabaseSchemaPlan.java:
##########
@@ -28,17 +29,17 @@
import java.nio.ByteBuffer;
import java.util.Objects;
-public class SetStorageGroupPlan extends ConfigPhysicalPlan {
+public class DatabaseSchemaPlan extends ConfigPhysicalPlan {
Review Comment:
I suppose no. Because the DatabaseSchemaPlan will be used in CreateDatabase or AlterDatabase. Both verb `set` or `update` can't not match these two scenarios in the same time.
##########
confignode/src/main/java/org/apache/iotdb/confignode/consensus/request/ConfigPhysicalPlanType.java:
##########
@@ -44,6 +45,7 @@ public enum ConfigPhysicalPlanType {
PreDeleteStorageGroup((short) 207),
GetStorageGroup((short) 208),
Review Comment:
Renamed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] OneSizeFitsQuorum commented on a diff in pull request #8971: [IOTDB-5451] Support cluster Database heterogeneous by ALTER SQL
Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum commented on code in PR #8971:
URL: https://github.com/apache/iotdb/pull/8971#discussion_r1099618782
##########
confignode/src/main/java/org/apache/iotdb/confignode/service/thrift/ConfigNodeRPCServiceProcessor.java:
##########
@@ -275,80 +274,123 @@ public TShowVariablesResp showVariables() {
}
@Override
- public TSStatus setStorageGroup(TSetStorageGroupReq req) throws TException {
- TStorageGroupSchema storageGroupSchema = req.getStorageGroup();
+ public TSStatus setDatabase(TStorageGroupSchema databaseSchema) {
TSStatus errorResp = null;
// Set default configurations if necessary
- if (!storageGroupSchema.isSetTTL()) {
- storageGroupSchema.setTTL(CommonDescriptor.getInstance().getConfig().getDefaultTTLInMs());
- } else if (storageGroupSchema.getTTL() <= 0) {
+ if (!databaseSchema.isSetTTL()) {
+ databaseSchema.setTTL(CommonDescriptor.getInstance().getConfig().getDefaultTTLInMs());
+ } else if (databaseSchema.getTTL() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage("Failed to create database. The TTL should be positive.");
}
- if (!storageGroupSchema.isSetSchemaReplicationFactor()) {
- storageGroupSchema.setSchemaReplicationFactor(
- CONFIG_NODE_CONFIG.getSchemaReplicationFactor());
- } else if (storageGroupSchema.getSchemaReplicationFactor() <= 0) {
+ if (!databaseSchema.isSetSchemaReplicationFactor()) {
+ databaseSchema.setSchemaReplicationFactor(CONFIG_NODE_CONFIG.getSchemaReplicationFactor());
+ } else if (databaseSchema.getSchemaReplicationFactor() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage(
"Failed to create database. The schemaReplicationFactor should be positive.");
}
- if (!storageGroupSchema.isSetDataReplicationFactor()) {
- storageGroupSchema.setDataReplicationFactor(CONFIG_NODE_CONFIG.getDataReplicationFactor());
- } else if (storageGroupSchema.getDataReplicationFactor() <= 0) {
+ if (!databaseSchema.isSetDataReplicationFactor()) {
+ databaseSchema.setDataReplicationFactor(CONFIG_NODE_CONFIG.getDataReplicationFactor());
+ } else if (databaseSchema.getDataReplicationFactor() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage(
"Failed to create database. The dataReplicationFactor should be positive.");
}
- if (!storageGroupSchema.isSetTimePartitionInterval()) {
- storageGroupSchema.setTimePartitionInterval(CONFIG_NODE_CONFIG.getTimePartitionInterval());
- } else if (storageGroupSchema.getTimePartitionInterval() <= 0) {
+ if (!databaseSchema.isSetTimePartitionInterval()) {
+ databaseSchema.setTimePartitionInterval(CONFIG_NODE_CONFIG.getTimePartitionInterval());
+ } else if (databaseSchema.getTimePartitionInterval() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage(
"Failed to create database. The timePartitionInterval should be positive.");
}
- if (!storageGroupSchema.isSetMinSchemaRegionGroupNum()) {
- storageGroupSchema.setMinSchemaRegionGroupNum(
+ if (!databaseSchema.isSetMinSchemaRegionGroupNum()) {
+ databaseSchema.setMinSchemaRegionGroupNum(
CONFIG_NODE_CONFIG.getDefaultSchemaRegionGroupNumPerDatabase());
- } else if (storageGroupSchema.getMinSchemaRegionGroupNum() <= 0) {
+ } else if (databaseSchema.getMinSchemaRegionGroupNum() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage(
"Failed to create database. The schemaRegionGroupNum should be positive.");
}
- if (!storageGroupSchema.isSetMinDataRegionGroupNum()) {
- storageGroupSchema.setMinDataRegionGroupNum(
+ if (!databaseSchema.isSetMinDataRegionGroupNum()) {
+ databaseSchema.setMinDataRegionGroupNum(
CONFIG_NODE_CONFIG.getDefaultDataRegionGroupNumPerDatabase());
- } else if (storageGroupSchema.getMinDataRegionGroupNum() <= 0) {
+ } else if (databaseSchema.getMinDataRegionGroupNum() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage("Failed to create database. The dataRegionGroupNum should be positive.");
}
if (errorResp != null) {
- LOGGER.warn("Execute SetStorageGroupRequest {} with result {}", req, errorResp);
+ LOGGER.warn("Execute SetDatabase: {} with result: {}", databaseSchema, errorResp);
return errorResp;
}
// The maxRegionGroupNum is equal to the minRegionGroupNum when initialize
- storageGroupSchema.setMaxSchemaRegionGroupNum(storageGroupSchema.getMinSchemaRegionGroupNum());
- storageGroupSchema.setMaxDataRegionGroupNum(storageGroupSchema.getMinDataRegionGroupNum());
+ databaseSchema.setMaxSchemaRegionGroupNum(databaseSchema.getMinSchemaRegionGroupNum());
+ databaseSchema.setMaxDataRegionGroupNum(databaseSchema.getMinDataRegionGroupNum());
- SetStorageGroupPlan setReq = new SetStorageGroupPlan(storageGroupSchema);
- TSStatus resp = configManager.setStorageGroup(setReq);
+ DatabaseSchemaPlan setPlan =
+ new DatabaseSchemaPlan(ConfigPhysicalPlanType.CreateDatabase, databaseSchema);
+ TSStatus resp = configManager.setDatabase(setPlan);
// Print log to record the ConfigNode that performs the set SetStorageGroupRequest
- LOGGER.info("Execute SetStorageGroupRequest {} with result {}", req, resp);
+ LOGGER.info("Execute SetDatabase: {} with result: {}", databaseSchema, resp);
+
+ return resp;
+ }
+
+ @Override
+ public TSStatus alterDatabase(TStorageGroupSchema databaseSchema) {
+ TSStatus errorResp = null;
+
+ // TODO: Support alter the following fields
+ if (databaseSchema.isSetTTL()) {
+ errorResp =
Review Comment:
It's a trivial issue, so I'm OK with both~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] OneSizeFitsQuorum commented on a diff in pull request #8971: [IOTDB-5451] Support cluster Database heterogeneous by ALTER SQL
Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum commented on code in PR #8971:
URL: https://github.com/apache/iotdb/pull/8971#discussion_r1098125113
##########
confignode/src/main/java/org/apache/iotdb/confignode/consensus/request/ConfigPhysicalPlanType.java:
##########
@@ -44,6 +45,7 @@ public enum ConfigPhysicalPlanType {
PreDeleteStorageGroup((short) 207),
GetStorageGroup((short) 208),
Review Comment:
When to rename these fields to `database`?
##########
confignode/src/main/java/org/apache/iotdb/confignode/service/thrift/ConfigNodeRPCServiceProcessor.java:
##########
@@ -275,80 +274,123 @@ public TShowVariablesResp showVariables() {
}
@Override
- public TSStatus setStorageGroup(TSetStorageGroupReq req) throws TException {
- TStorageGroupSchema storageGroupSchema = req.getStorageGroup();
+ public TSStatus setDatabase(TStorageGroupSchema databaseSchema) {
TSStatus errorResp = null;
// Set default configurations if necessary
- if (!storageGroupSchema.isSetTTL()) {
- storageGroupSchema.setTTL(CommonDescriptor.getInstance().getConfig().getDefaultTTLInMs());
- } else if (storageGroupSchema.getTTL() <= 0) {
+ if (!databaseSchema.isSetTTL()) {
+ databaseSchema.setTTL(CommonDescriptor.getInstance().getConfig().getDefaultTTLInMs());
+ } else if (databaseSchema.getTTL() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage("Failed to create database. The TTL should be positive.");
}
- if (!storageGroupSchema.isSetSchemaReplicationFactor()) {
- storageGroupSchema.setSchemaReplicationFactor(
- CONFIG_NODE_CONFIG.getSchemaReplicationFactor());
- } else if (storageGroupSchema.getSchemaReplicationFactor() <= 0) {
+ if (!databaseSchema.isSetSchemaReplicationFactor()) {
+ databaseSchema.setSchemaReplicationFactor(CONFIG_NODE_CONFIG.getSchemaReplicationFactor());
+ } else if (databaseSchema.getSchemaReplicationFactor() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage(
"Failed to create database. The schemaReplicationFactor should be positive.");
}
- if (!storageGroupSchema.isSetDataReplicationFactor()) {
- storageGroupSchema.setDataReplicationFactor(CONFIG_NODE_CONFIG.getDataReplicationFactor());
- } else if (storageGroupSchema.getDataReplicationFactor() <= 0) {
+ if (!databaseSchema.isSetDataReplicationFactor()) {
+ databaseSchema.setDataReplicationFactor(CONFIG_NODE_CONFIG.getDataReplicationFactor());
+ } else if (databaseSchema.getDataReplicationFactor() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage(
"Failed to create database. The dataReplicationFactor should be positive.");
}
- if (!storageGroupSchema.isSetTimePartitionInterval()) {
- storageGroupSchema.setTimePartitionInterval(CONFIG_NODE_CONFIG.getTimePartitionInterval());
- } else if (storageGroupSchema.getTimePartitionInterval() <= 0) {
+ if (!databaseSchema.isSetTimePartitionInterval()) {
+ databaseSchema.setTimePartitionInterval(CONFIG_NODE_CONFIG.getTimePartitionInterval());
+ } else if (databaseSchema.getTimePartitionInterval() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage(
"Failed to create database. The timePartitionInterval should be positive.");
}
- if (!storageGroupSchema.isSetMinSchemaRegionGroupNum()) {
- storageGroupSchema.setMinSchemaRegionGroupNum(
+ if (!databaseSchema.isSetMinSchemaRegionGroupNum()) {
+ databaseSchema.setMinSchemaRegionGroupNum(
CONFIG_NODE_CONFIG.getDefaultSchemaRegionGroupNumPerDatabase());
- } else if (storageGroupSchema.getMinSchemaRegionGroupNum() <= 0) {
+ } else if (databaseSchema.getMinSchemaRegionGroupNum() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage(
"Failed to create database. The schemaRegionGroupNum should be positive.");
}
- if (!storageGroupSchema.isSetMinDataRegionGroupNum()) {
- storageGroupSchema.setMinDataRegionGroupNum(
+ if (!databaseSchema.isSetMinDataRegionGroupNum()) {
+ databaseSchema.setMinDataRegionGroupNum(
CONFIG_NODE_CONFIG.getDefaultDataRegionGroupNumPerDatabase());
- } else if (storageGroupSchema.getMinDataRegionGroupNum() <= 0) {
+ } else if (databaseSchema.getMinDataRegionGroupNum() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage("Failed to create database. The dataRegionGroupNum should be positive.");
}
if (errorResp != null) {
- LOGGER.warn("Execute SetStorageGroupRequest {} with result {}", req, errorResp);
+ LOGGER.warn("Execute SetDatabase: {} with result: {}", databaseSchema, errorResp);
return errorResp;
}
// The maxRegionGroupNum is equal to the minRegionGroupNum when initialize
- storageGroupSchema.setMaxSchemaRegionGroupNum(storageGroupSchema.getMinSchemaRegionGroupNum());
- storageGroupSchema.setMaxDataRegionGroupNum(storageGroupSchema.getMinDataRegionGroupNum());
+ databaseSchema.setMaxSchemaRegionGroupNum(databaseSchema.getMinSchemaRegionGroupNum());
+ databaseSchema.setMaxDataRegionGroupNum(databaseSchema.getMinDataRegionGroupNum());
- SetStorageGroupPlan setReq = new SetStorageGroupPlan(storageGroupSchema);
- TSStatus resp = configManager.setStorageGroup(setReq);
+ DatabaseSchemaPlan setPlan =
+ new DatabaseSchemaPlan(ConfigPhysicalPlanType.CreateDatabase, databaseSchema);
+ TSStatus resp = configManager.setDatabase(setPlan);
// Print log to record the ConfigNode that performs the set SetStorageGroupRequest
- LOGGER.info("Execute SetStorageGroupRequest {} with result {}", req, resp);
+ LOGGER.info("Execute SetDatabase: {} with result: {}", databaseSchema, resp);
+
+ return resp;
+ }
+
+ @Override
+ public TSStatus alterDatabase(TStorageGroupSchema databaseSchema) {
+ TSStatus errorResp = null;
+
+ // TODO: Support alter the following fields
+ if (databaseSchema.isSetTTL()) {
+ errorResp =
+ new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
+ .setMessage("Failed to alter database. Doesn't support ALTER TTL yet.");
+ }
+ if (databaseSchema.isSetSchemaReplicationFactor()) {
+ errorResp =
+ new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
Review Comment:
same
##########
confignode/src/main/java/org/apache/iotdb/confignode/service/thrift/ConfigNodeRPCServiceProcessor.java:
##########
@@ -275,80 +274,123 @@ public TShowVariablesResp showVariables() {
}
@Override
- public TSStatus setStorageGroup(TSetStorageGroupReq req) throws TException {
- TStorageGroupSchema storageGroupSchema = req.getStorageGroup();
+ public TSStatus setDatabase(TStorageGroupSchema databaseSchema) {
TSStatus errorResp = null;
// Set default configurations if necessary
- if (!storageGroupSchema.isSetTTL()) {
- storageGroupSchema.setTTL(CommonDescriptor.getInstance().getConfig().getDefaultTTLInMs());
- } else if (storageGroupSchema.getTTL() <= 0) {
+ if (!databaseSchema.isSetTTL()) {
+ databaseSchema.setTTL(CommonDescriptor.getInstance().getConfig().getDefaultTTLInMs());
+ } else if (databaseSchema.getTTL() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage("Failed to create database. The TTL should be positive.");
}
- if (!storageGroupSchema.isSetSchemaReplicationFactor()) {
- storageGroupSchema.setSchemaReplicationFactor(
- CONFIG_NODE_CONFIG.getSchemaReplicationFactor());
- } else if (storageGroupSchema.getSchemaReplicationFactor() <= 0) {
+ if (!databaseSchema.isSetSchemaReplicationFactor()) {
+ databaseSchema.setSchemaReplicationFactor(CONFIG_NODE_CONFIG.getSchemaReplicationFactor());
+ } else if (databaseSchema.getSchemaReplicationFactor() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage(
"Failed to create database. The schemaReplicationFactor should be positive.");
}
- if (!storageGroupSchema.isSetDataReplicationFactor()) {
- storageGroupSchema.setDataReplicationFactor(CONFIG_NODE_CONFIG.getDataReplicationFactor());
- } else if (storageGroupSchema.getDataReplicationFactor() <= 0) {
+ if (!databaseSchema.isSetDataReplicationFactor()) {
+ databaseSchema.setDataReplicationFactor(CONFIG_NODE_CONFIG.getDataReplicationFactor());
+ } else if (databaseSchema.getDataReplicationFactor() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage(
"Failed to create database. The dataReplicationFactor should be positive.");
}
- if (!storageGroupSchema.isSetTimePartitionInterval()) {
- storageGroupSchema.setTimePartitionInterval(CONFIG_NODE_CONFIG.getTimePartitionInterval());
- } else if (storageGroupSchema.getTimePartitionInterval() <= 0) {
+ if (!databaseSchema.isSetTimePartitionInterval()) {
+ databaseSchema.setTimePartitionInterval(CONFIG_NODE_CONFIG.getTimePartitionInterval());
+ } else if (databaseSchema.getTimePartitionInterval() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage(
"Failed to create database. The timePartitionInterval should be positive.");
}
- if (!storageGroupSchema.isSetMinSchemaRegionGroupNum()) {
- storageGroupSchema.setMinSchemaRegionGroupNum(
+ if (!databaseSchema.isSetMinSchemaRegionGroupNum()) {
+ databaseSchema.setMinSchemaRegionGroupNum(
CONFIG_NODE_CONFIG.getDefaultSchemaRegionGroupNumPerDatabase());
- } else if (storageGroupSchema.getMinSchemaRegionGroupNum() <= 0) {
+ } else if (databaseSchema.getMinSchemaRegionGroupNum() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage(
"Failed to create database. The schemaRegionGroupNum should be positive.");
}
- if (!storageGroupSchema.isSetMinDataRegionGroupNum()) {
- storageGroupSchema.setMinDataRegionGroupNum(
+ if (!databaseSchema.isSetMinDataRegionGroupNum()) {
+ databaseSchema.setMinDataRegionGroupNum(
CONFIG_NODE_CONFIG.getDefaultDataRegionGroupNumPerDatabase());
- } else if (storageGroupSchema.getMinDataRegionGroupNum() <= 0) {
+ } else if (databaseSchema.getMinDataRegionGroupNum() <= 0) {
errorResp =
new TSStatus(TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode())
.setMessage("Failed to create database. The dataRegionGroupNum should be positive.");
}
if (errorResp != null) {
- LOGGER.warn("Execute SetStorageGroupRequest {} with result {}", req, errorResp);
+ LOGGER.warn("Execute SetDatabase: {} with result: {}", databaseSchema, errorResp);
return errorResp;
}
// The maxRegionGroupNum is equal to the minRegionGroupNum when initialize
- storageGroupSchema.setMaxSchemaRegionGroupNum(storageGroupSchema.getMinSchemaRegionGroupNum());
- storageGroupSchema.setMaxDataRegionGroupNum(storageGroupSchema.getMinDataRegionGroupNum());
+ databaseSchema.setMaxSchemaRegionGroupNum(databaseSchema.getMinSchemaRegionGroupNum());
+ databaseSchema.setMaxDataRegionGroupNum(databaseSchema.getMinDataRegionGroupNum());
- SetStorageGroupPlan setReq = new SetStorageGroupPlan(storageGroupSchema);
- TSStatus resp = configManager.setStorageGroup(setReq);
+ DatabaseSchemaPlan setPlan =
+ new DatabaseSchemaPlan(ConfigPhysicalPlanType.CreateDatabase, databaseSchema);
+ TSStatus resp = configManager.setDatabase(setPlan);
// Print log to record the ConfigNode that performs the set SetStorageGroupRequest
- LOGGER.info("Execute SetStorageGroupRequest {} with result {}", req, resp);
+ LOGGER.info("Execute SetDatabase: {} with result: {}", databaseSchema, resp);
+
+ return resp;
+ }
+
+ @Override
+ public TSStatus alterDatabase(TStorageGroupSchema databaseSchema) {
+ TSStatus errorResp = null;
+
+ // TODO: Support alter the following fields
+ if (databaseSchema.isSetTTL()) {
+ errorResp =
Review Comment:
You can return just here? It seems there's no need to double-check the others.
##########
confignode/src/main/java/org/apache/iotdb/confignode/consensus/request/write/storagegroup/DatabaseSchemaPlan.java:
##########
@@ -28,17 +29,17 @@
import java.nio.ByteBuffer;
import java.util.Objects;
-public class SetStorageGroupPlan extends ConfigPhysicalPlan {
+public class DatabaseSchemaPlan extends ConfigPhysicalPlan {
Review Comment:
Do we need some verb such as `set` or `update`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org