[GitHub] [tvm] Lunderberg commented on pull request #12891: [TIR][Transform] Clear buffer_map during MakeUnpackedAPI

[GitBox <gi...@apache.org>]

Lunderberg commented on PR #12891:
URL: https://github.com/apache/tvm/pull/12891#issuecomment-1258215543

   @Mousius Thank you, and it looks like that's also being caught in the tests, as this breaks pretty much every ethos-u test at [this line](https://github.com/apache/tvm/blob/main/python/tvm/relay/backend/contrib/ethosu/tir_to_cs_translator.py#L265).  (Also why I intentionally marked this as a draft PR, to catch any impact to workflows that I'm not as familiar with.)
   
   To me, the `buffer_map` is an indicator for how a function should later be lowered, and what buffers should be defined as part of the lowered function.  Once it has been used, then it makes sense for the resulting function to have an empty `buffer_map`, because no further lowering is required.  After #9727, the buffer shape/size could still be accessed by later passes find finding the `BufferLoad` or `BufferStore` object that makes use of a parameter, rather than searching in the `buffer_map` itself.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org