You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2016/02/27 22:59:59 UTC

svn commit: r1732672 - in /tomcat/tc8.0.x/trunk: java/org/apache/catalina/session/LocalStrings.properties java/org/apache/catalina/session/ManagerBase.java webapps/docs/changelog.xml

Author: markt
Date: Sat Feb 27 21:59:58 2016
New Revision: 1732672

URL: http://svn.apache.org/viewvc?rev=1732672&view=rev
Log:
Log a warning message if a user tries to configure the default session timeout via the deprecated (and ignored) Manager.setMaxInactiveInterval() method.

Modified:
    tomcat/tc8.0.x/trunk/java/org/apache/catalina/session/LocalStrings.properties
    tomcat/tc8.0.x/trunk/java/org/apache/catalina/session/ManagerBase.java
    tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc8.0.x/trunk/java/org/apache/catalina/session/LocalStrings.properties
URL: http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/java/org/apache/catalina/session/LocalStrings.properties?rev=1732672&r1=1732671&r2=1732672&view=diff
==============================================================================
--- tomcat/tc8.0.x/trunk/java/org/apache/catalina/session/LocalStrings.properties (original)
+++ tomcat/tc8.0.x/trunk/java/org/apache/catalina/session/LocalStrings.properties Sat Feb 27 21:59:58 2016
@@ -37,6 +37,7 @@ managerBase.sessionAttributeNameFilter=S
 managerBase.sessionAttributeValueClassNameFilter=Skipped session attribute named [{0}] because the value type [{1}] did not match the filter [{2}]
 managerBase.sessionTimeout=Invalid session timeout setting {0}
 managerBase.setContextNotNew=It is illegal to call setContext() to change the Context associated with a Manager if the Manager is not in the NEW state
+managerBase.setMaxInactiveIntervalUnused=Manager.setMaxInactiveInterval() is deprecated and calls to this method are ignored. Session timeouts should be configured in web.xml or via Context.setSessionTimeout(int timeoutInMinutes)
 standardManager.loading=Loading persisted sessions from {0}
 standardManager.loading.exception=Exception while loading persisted sessions
 standardManager.unloading=Saving persisted sessions to {0}

Modified: tomcat/tc8.0.x/trunk/java/org/apache/catalina/session/ManagerBase.java
URL: http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/java/org/apache/catalina/session/ManagerBase.java?rev=1732672&r1=1732671&r2=1732672&view=diff
==============================================================================
--- tomcat/tc8.0.x/trunk/java/org/apache/catalina/session/ManagerBase.java (original)
+++ tomcat/tc8.0.x/trunk/java/org/apache/catalina/session/ManagerBase.java Sat Feb 27 21:59:58 2016
@@ -436,7 +436,7 @@ public abstract class ManagerBase extend
     @Deprecated
     @Override
     public void setMaxInactiveInterval(int interval) {
-        // NO-OP
+        log.warn(sm.getString("managerBase.setMaxInactiveIntervalUnused"));
     }
 
 

Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml?rev=1732672&r1=1732671&r2=1732672&view=diff
==============================================================================
--- tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Sat Feb 27 21:59:58 2016
@@ -114,6 +114,11 @@
       <fix>
         Storeconfig handling for socket properties. (remm)
       </fix>
+      <add>
+        Log a warning message if a user tries to configure the default session
+        timeout via the deprecated (and ignored)
+        <code>Manager.setMaxInactiveInterval()</code> method. (markt)
+      </add>
     </changelog>
   </subsection>
   <subsection name="Coyote">



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org