[GitHub] [trafficserver] ywkaras commented on a change in pull request #6455: regex_revalidate c++ and lifecycle message reload

[GitBox <gi...@apache.org>]

ywkaras commented on a change in pull request #6455:
URL: https://github.com/apache/trafficserver/pull/6455#discussion_r568164085



##########
File path: plugins/regex_revalidate/regex_revalidate.cc
##########
@@ -0,0 +1,729 @@
+/** @file
+
+  @section license License
+
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+ */
+
+#include "ts/ts.h"
+#include "ts/remap.h"
+#include "ts/experimental.h"
+#include "regex.h"
+
+#include <cinttypes>
+#include <cstring>
+#include <ctime>
+#include <getopt.h>
+#include <limits.h>
+#include <sys/types.h>
+#include <sys/stat.h>
+
+#include <algorithm>
+#include <iostream>
+#include <map>
+#include <memory>
+#include <set>
+#include <string>
+#include <string_view>
+#include <vector>
+
+#ifdef HAVE_PCRE_PCRE_H
+#include <pcre/pcre.h>
+#else
+#include <pcre.h>
+#endif
+
+namespace
+{
+constexpr char const *const PLUGIN_NAME = "regex_revalidate";
+constexpr char const *const RELOAD_TAG  = "config_reload";
+constexpr char const *const PRINT_TAG   = "config_print";
+
+#define DEBUG_LOG(fmt, ...) TSDebug(PLUGIN_NAME, "%s:%d " fmt, __func__, __LINE__, ##__VA_ARGS__)
+
+#define ERROR_LOG(fmt, ...)                         \
+  TSError("(%s) " fmt, PLUGIN_NAME, ##__VA_ARGS__); \
+  DEBUG_LOG(fmt, ##__VA_ARGS__)
+
+constexpr TSHRTime const CONFIG_TMOUT = 60000; // ms, 60s
+// constexpr TSHRTime const CONFIG_TMOUT = 5000; // ms, 5

Review comment:
       ick




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org