You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/03 14:03:59 UTC

[GitHub] [airflow] turbaszek opened a new pull request #11259: Use rst lexer to format airflow upgrade check output

turbaszek opened a new pull request #11259:
URL: https://github.com/apache/airflow/pull/11259


   Instead of displaying plain text we can use pygments formatter and lexer
   to improve readability and UX of airflow upgrade_check command.
   
   Before
   <img width="1266" alt="Screenshot 2020-10-03 at 15 50 33" src="https://user-images.githubusercontent.com/9528307/94993381-f217af00-0590-11eb-8781-3fc437dd51e2.png">
   
   
   After
   <img width="1266" alt="Screenshot 2020-10-03 at 16 01 51" src="https://user-images.githubusercontent.com/9528307/94993503-cea13400-0591-11eb-9651-9d557ab7d5db.png">
   
   
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #11259: Use rst lexer to format airflow upgrade check output

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #11259:
URL: https://github.com/apache/airflow/pull/11259#issuecomment-703109966


   What do you think to use rich? It looks a little more user-friendly.
   https://github.com/willmcgugan/rich#markdown


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] turbaszek commented on pull request #11259: Use rst lexer to format airflow upgrade check output

Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #11259:
URL: https://github.com/apache/airflow/pull/11259#issuecomment-703114135


   > What do you think to use rich? It looks a little more user-friendly.
   > https://github.com/willmcgugan/rich#markdown
   
   I think the rich is something that we should consider in future (for multiple commands). For now, I would prefer to stick to what we have and keep it simple.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] turbaszek merged pull request #11259: Use rst lexer to format airflow upgrade check output

Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #11259:
URL: https://github.com/apache/airflow/pull/11259


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on pull request #11259: Use rst lexer to format airflow upgrade check output

Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11259:
URL: https://github.com/apache/airflow/pull/11259#issuecomment-703112662


   Rich is Py 3.6 only though


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org