[GitHub] [shardingsphere] azexcy commented on a diff in pull request #20468: Remove unused sharding scaling rule DistSQL and related configs

[GitBox <gi...@apache.org>]

azexcy commented on code in PR #20468:
URL: https://github.com/apache/shardingsphere/pull/20468#discussion_r952538756


##########
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-distsql/shardingsphere-sharding-distsql-parser/src/main/java/org/apache/shardingsphere/migration/distsql/parser/core/MigrationDistSQLStatementVisitor.java:
##########
@@ -342,9 +207,4 @@ public ASTNode visitAddMigrationSourceResource(final AddMigrationSourceResourceC
     public ASTNode visitDropMigrationSourceResource(final DropMigrationSourceResourceContext ctx) {
         return new DropMigrationSourceResourceStatement(ctx.resourceName().stream().map(ParseTree::getText).map(each -> new IdentifierValue(each).getValue()).collect(Collectors.toList()));
     }
-    
-    @Override
-    public ASTNode visitShowMigrationSourceResources(final ShowMigrationSourceResourcesContext ctx) {
-        return new ShowMigrationSourceResourcesStatement();
-    }

Review Comment:
   still need, it's mistake



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org