[jira] [Commented] (HBASE-21178) [BC break] : Get and Scan operation with a custom converter_class not working

["Ted Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-21178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614584#comment-16614584 ] 

Ted Yu commented on HBASE-21178:
--------------------------------

{code}
782	      converter_class = 'org.apache.hadoop.hbase.util.Bytes' unless converter_class
783	      converter_method = 'toStringBinary' unless converter_method
784	      eval(converter_class).method(converter_method).call(bytes)
{code}
Is it possible that one of converter_class / converter_method is null ?
In that case the conversion should be skipped, right ?

Also, is it possible to add a test with conversion to prevent regression ?

Thanks for the finding.

> [BC break] : Get and Scan operation with a custom converter_class not working
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-21178
>                 URL: https://issues.apache.org/jira/browse/HBASE-21178
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 2.0.0
>            Reporter: Subrat Mishra
>            Assignee: Subrat Mishra
>            Priority: Critical
>         Attachments: HBASE-21178.master.001.patch
>
>
> Consider a simple scenario:
> {code:java}
> create 'foo', {NAME => 'f1'}
> put 'foo','r1','f1:a',1000
> get 'foo','r1',{COLUMNS => ['f1:a:c(org.apache.hadoop.hbase.util.Bytes).len']} 
> scan 'foo',{COLUMNS => ['f1:a:c(org.apache.hadoop.hbase.util.Bytes).len']}{code}
> Both get and scan fails with ERROR
> {code:java}
> ERROR: wrong number of arguments (3 for 1) {code}
> Looks like in table.rb file converter_method expects 3 arguments [(bytes, offset, len)] since version 2.0.0, prior to version 2.0.0 it was taking only 1 argument [(bytes)]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)