[GitHub] [maven-release] slawekjaranowski commented on a diff in pull request #118: [MRELEASE-1087] Catch up

[GitBox <gi...@apache.org>]

slawekjaranowski commented on code in PR #118:
URL: https://github.com/apache/maven-release/pull/118#discussion_r865711326


##########
maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/AbstractReleaseTestCase.java:
##########
@@ -213,7 +213,13 @@ public FileVisitResult visitFile( Path file, BasicFileAttributes attrs )
         for ( MavenProject project  : reactorProjects )
         {
             MavenProject resolvedProject = projectBuilder.build( project.getFile(), buildingRequest ).getProject();
-            
+
+            // FIXME ... setDependencyArtifacts -  set direct dependencies ...
+            // but in org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.createReleaseDependencies
+            // getArtifacts is used ...
+
+            // so we probably also need call setResolvedArtifacts
+

Review Comment:
   And why we need use `setDependencyArtifacts` directly ... 
   code is also strange for me we check:
   ```
   if ( project.getDependencyArtifacts() == null ) 
   ```
   and next on different object
   ```
   resolvedProject.setDependencyArtifacts(....)
   ```
   
   I will check what happens if I call 
   
   ```
   resolvedProject.setResolvedArtifacts( resolvedProject.getDependencyArtifacts() )
   ```
   of course I don't understand it very well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org