[GitHub] [druid] mrmassis commented on issue #5687: Using druid.storage.type=noop get error

[GitBox <gi...@apache.org>]

mrmassis commented on issue #5687:
URL: https://github.com/apache/druid/issues/5687#issuecomment-670782040


   Hi
   In my point of view, what happens is that there is a logic problem in "case" inside the druid.sh. To both overload or coordinator take to the same location.
   In my opinion, the options should be separated:
   
   original druid.sh
   ```
   getConfPath() {
       cluster_conf_base=/tmp/conf/druid/cluster
       case "$1" in
       _common) echo $cluster_conf_base/_common ;;
       historical) echo $cluster_conf_base/data/historical ;;
       middleManager) echo $cluster_conf_base/data/middleManager ;;
       coordinator | overlord) echo $cluster_conf_base/master/coordinator-overlord ;;
       broker) echo $cluster_conf_base/query/broker ;;
       router) echo $cluster_conf_base/query/router ;;
       esac
   }
   ```
   
   My modification:
   
   ```
   getConfPath() {
       cluster_conf_base=/tmp/conf/druid/cluster
       case "$1" in
       _common) echo $cluster_conf_base/cluster/_common ;;
       historical) echo $cluster_conf_base/cluste/data/historical ;;
       middleManager) echo $cluster_conf_base/cluster/data/middleManager ;;
       coordinator) echo $cluster_conf_base/cluster/data/coordinator-overlord ;;
       overlord) echo $cluster_conf_base/cluster/master/overlord ;;
       broker) echo $cluster_conf_base/cluster/query/broker ;;
       router) echo $cluster_conf_base/cluster/query/router ;;
       esac
   }
   ```
   
   The entiry druid.sh and start process (logic and code) must be revised. I can do it ;)
   
   Tkz
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org