You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "J.W. Janssen (JIRA)" <ji...@apache.org> on 2012/09/25 16:00:20 UTC
[jira] [Created] (SHINDIG-1874) Leaky abstraction for
BeanJsonConverter
J.W. Janssen created SHINDIG-1874:
-------------------------------------
Summary: Leaky abstraction for BeanJsonConverter
Key: SHINDIG-1874
URL: https://issues.apache.org/jira/browse/SHINDIG-1874
Project: Shindig
Issue Type: Bug
Components: Java
Affects Versions: 2.5.0-beta4
Reporter: J.W. Janssen
Fix For: 2.5.0-beta5
While trying to get the latest Shindig running in an OSGi environment, I found out that BeanJsonConverter is not properly abstracted away in ApiServlet. There's no reason for this, as nobody uses any other methods than defined on BeanConverter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (SHINDIG-1874) Leaky abstraction for
BeanJsonConverter
Posted by "J.W. Janssen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
J.W. Janssen closed SHINDIG-1874.
---------------------------------
Fix seen. Thanks!
> Leaky abstraction for BeanJsonConverter
> ---------------------------------------
>
> Key: SHINDIG-1874
> URL: https://issues.apache.org/jira/browse/SHINDIG-1874
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0-beta4
> Reporter: J.W. Janssen
> Fix For: 2.5.0-beta5
>
> Attachments: SHINDIG-1874.patch
>
>
> While trying to get the latest Shindig running in an OSGi environment, I found out that BeanJsonConverter is not properly abstracted away in ApiServlet. There's no reason for this, as nobody uses any other methods than defined on BeanConverter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1874) Leaky abstraction for
BeanJsonConverter
Posted by "Stanton Sievers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466486#comment-13466486 ]
Stanton Sievers commented on SHINDIG-1874:
------------------------------------------
Can you please close the review on reviews.apache.org? Thanks!
> Leaky abstraction for BeanJsonConverter
> ---------------------------------------
>
> Key: SHINDIG-1874
> URL: https://issues.apache.org/jira/browse/SHINDIG-1874
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0-beta4
> Reporter: J.W. Janssen
> Fix For: 2.5.0-beta5
>
> Attachments: SHINDIG-1874.patch
>
>
> While trying to get the latest Shindig running in an OSGi environment, I found out that BeanJsonConverter is not properly abstracted away in ApiServlet. There's no reason for this, as nobody uses any other methods than defined on BeanConverter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1874) Leaky abstraction for
BeanJsonConverter
Posted by "J.W. Janssen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463096#comment-13463096 ]
J.W. Janssen commented on SHINDIG-1874:
---------------------------------------
Check, will do.
See: <https://reviews.apache.org/r/7266/>
> Leaky abstraction for BeanJsonConverter
> ---------------------------------------
>
> Key: SHINDIG-1874
> URL: https://issues.apache.org/jira/browse/SHINDIG-1874
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0-beta4
> Reporter: J.W. Janssen
> Fix For: 2.5.0-beta5
>
> Attachments: SHINDIG-1874.patch
>
>
> While trying to get the latest Shindig running in an OSGi environment, I found out that BeanJsonConverter is not properly abstracted away in ApiServlet. There's no reason for this, as nobody uses any other methods than defined on BeanConverter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1874) Leaky abstraction for
BeanJsonConverter
Posted by "Stanton Sievers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462981#comment-13462981 ]
Stanton Sievers commented on SHINDIG-1874:
------------------------------------------
Can you please post your patch to the reviews.apache.org site and add the "shindig" group the review?
I don't foresee any problems with your patch but it's routine to have a proper review and get the dev list involved.
> Leaky abstraction for BeanJsonConverter
> ---------------------------------------
>
> Key: SHINDIG-1874
> URL: https://issues.apache.org/jira/browse/SHINDIG-1874
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0-beta4
> Reporter: J.W. Janssen
> Fix For: 2.5.0-beta5
>
> Attachments: SHINDIG-1874.patch
>
>
> While trying to get the latest Shindig running in an OSGi environment, I found out that BeanJsonConverter is not properly abstracted away in ApiServlet. There's no reason for this, as nobody uses any other methods than defined on BeanConverter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1874) Leaky abstraction for
BeanJsonConverter
Posted by "J.W. Janssen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
J.W. Janssen updated SHINDIG-1874:
----------------------------------
Attachment: SHINDIG-1874.patch
Uploaded a trivial patch for fixing this issue.
> Leaky abstraction for BeanJsonConverter
> ---------------------------------------
>
> Key: SHINDIG-1874
> URL: https://issues.apache.org/jira/browse/SHINDIG-1874
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0-beta4
> Reporter: J.W. Janssen
> Fix For: 2.5.0-beta5
>
> Attachments: SHINDIG-1874.patch
>
>
> While trying to get the latest Shindig running in an OSGi environment, I found out that BeanJsonConverter is not properly abstracted away in ApiServlet. There's no reason for this, as nobody uses any other methods than defined on BeanConverter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SHINDIG-1874) Leaky abstraction for
BeanJsonConverter
Posted by "Stanton Sievers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stanton Sievers resolved SHINDIG-1874.
--------------------------------------
Resolution: Fixed
Committed revision 1390234
> Leaky abstraction for BeanJsonConverter
> ---------------------------------------
>
> Key: SHINDIG-1874
> URL: https://issues.apache.org/jira/browse/SHINDIG-1874
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0-beta4
> Reporter: J.W. Janssen
> Fix For: 2.5.0-beta5
>
> Attachments: SHINDIG-1874.patch
>
>
> While trying to get the latest Shindig running in an OSGi environment, I found out that BeanJsonConverter is not properly abstracted away in ApiServlet. There's no reason for this, as nobody uses any other methods than defined on BeanConverter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (SHINDIG-1874) Leaky abstraction for
BeanJsonConverter
Posted by "Stanton Sievers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462981#comment-13462981 ]
Stanton Sievers edited comment on SHINDIG-1874 at 9/26/12 4:11 AM:
-------------------------------------------------------------------
Can you please post your patch to the reviews.apache.org site and add the "shindig" group to the review?
I don't foresee any problems with your patch but it's routine to have a proper review and get the dev list involved.
was (Author: ssievers):
Can you please post your patch to the reviews.apache.org site and add the "shindig" group the review?
I don't foresee any problems with your patch but it's routine to have a proper review and get the dev list involved.
> Leaky abstraction for BeanJsonConverter
> ---------------------------------------
>
> Key: SHINDIG-1874
> URL: https://issues.apache.org/jira/browse/SHINDIG-1874
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0-beta4
> Reporter: J.W. Janssen
> Fix For: 2.5.0-beta5
>
> Attachments: SHINDIG-1874.patch
>
>
> While trying to get the latest Shindig running in an OSGi environment, I found out that BeanJsonConverter is not properly abstracted away in ApiServlet. There's no reason for this, as nobody uses any other methods than defined on BeanConverter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira