You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/02 15:34:39 UTC
[GitHub] [arrow] rdettai opened a new pull request #8819: ARROW-10789: [Rust][DataFusion] Make TableProvider dynamically typed
rdettai opened a new pull request #8819:
URL: https://github.com/apache/arrow/pull/8819
> The `TableProvider` trait can be used to provide custom datasources to the query plan. It can be useful for usecases like plan serialization to be able to downcast to the concrete implementation, the same way it is done for the `ExecutionPlan` trait.
https://issues.apache.org/jira/browse/ARROW-10789
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8819: ARROW-10789: [Rust][DataFusion] Make TableProvider dynamically typed
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8819:
URL: https://github.com/apache/arrow/pull/8819#issuecomment-737316600
https://issues.apache.org/jira/browse/ARROW-10789
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #8819: ARROW-10789: [Rust][DataFusion] Make TableProvider dynamically typed
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #8819:
URL: https://github.com/apache/arrow/pull/8819
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #8819: ARROW-10789: [Rust][DataFusion] Make TableProvider dynamically typed
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #8819:
URL: https://github.com/apache/arrow/pull/8819#issuecomment-737448384
> is ... more idiomatic?
I personally think what you have in this PR is good. 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rdettai commented on pull request #8819: ARROW-10789: [Rust][DataFusion] Make TableProvider dynamically typed
Posted by GitBox <gi...@apache.org>.
rdettai commented on pull request #8819:
URL: https://github.com/apache/arrow/pull/8819#issuecomment-737378504
I'm wondering if there isn't a more elegant way to do this!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rdettai commented on pull request #8819: ARROW-10789: [Rust][DataFusion] Make TableProvider dynamically typed
Posted by GitBox <gi...@apache.org>.
rdettai commented on pull request #8819:
URL: https://github.com/apache/arrow/pull/8819#issuecomment-737382991
is
```
pub trait AsAny {
fn as_any(&self) -> &dyn Any;
}
impl<T: TableProvider + 'static> AsAny for T {
fn as_any(&self) -> &dyn Any {
self
}
}
```
more idiomatic?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org