You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/20 00:16:52 UTC
[GitHub] [airflow] bhavaniravi opened a new pull request #10415: Add missing deprecated classes
bhavaniravi opened a new pull request #10415:
URL: https://github.com/apache/airflow/pull/10415
closes: #10104
Added missing deprecated classes from airflow 1.10
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] stale[bot] closed pull request #10415: Add missing deprecated classes
Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #10415:
URL: https://github.com/apache/airflow/pull/10415
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #10415: Add missing deprecated classes
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #10415:
URL: https://github.com/apache/airflow/pull/10415#discussion_r473490978
##########
File path: tests/deprecated_classes.py
##########
@@ -1342,6 +1346,10 @@
]
SECRETS = [
+ (
+ 'airflow.providers.google.cloud.secrets.secret_manager.BaseSecretsBackend',
+ 'airflow.secrets.base_secrets.BaseSecretsBackend',
Review comment:
A similar situation is here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #10415: Add missing deprecated classes
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #10415:
URL: https://github.com/apache/airflow/pull/10415#issuecomment-691715120
@bhavaniravi can you please take a look at CI errors?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #10415: Add missing deprecated classes
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #10415:
URL: https://github.com/apache/airflow/pull/10415#issuecomment-677456737
For now, it's enough for us to have tests. When the time is right, we will prepare information for end users in an accessible form based on tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #10415: Add missing deprecated classes
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #10415:
URL: https://github.com/apache/airflow/pull/10415#discussion_r473490482
##########
File path: tests/deprecated_classes.py
##########
@@ -15,6 +15,10 @@
# specific language governing permissions and limitations
# under the License.
HOOKS = [
+ (
Review comment:
This import is not valid. We do not expect users to import BaseHook by:
```
from airflow.hooks.filesystem import BaseHook
```
BaseHook should be imported at all times, as shown below.
```
from airflow.hooks.base_hook import BaseHook
```
There is a broken backwards compatibility here, but we can't prevent API misuse as Python is too flexible
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10415: Add missing deprecated classes
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #10415:
URL: https://github.com/apache/airflow/pull/10415#issuecomment-676824363
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #10415: Add missing deprecated classes
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #10415:
URL: https://github.com/apache/airflow/pull/10415#discussion_r473492061
##########
File path: tests/deprecated_classes.py
##########
@@ -1361,6 +1369,27 @@
]
SENSORS = [
+ (
+ 'airflow.providers.apache.hive.sensors.metastore_partition.SqlSensor',
+ 'airflow.operators.sensors.SqlSensor',
+ ),
+ (
+ 'airflow.sensors.time_delta_sensor.TimeDeltaSensor',
+ 'airflow.operators.sensors.TimeDeltaSensor',
+ ),
Review comment:
All these have not changed either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] michalslowikowski00 commented on pull request #10415: Add missing deprecated classes
Posted by GitBox <gi...@apache.org>.
michalslowikowski00 commented on pull request #10415:
URL: https://github.com/apache/airflow/pull/10415#issuecomment-677437929
Should those change be reflected in this file UPDATING.md @mik-laj?
`https://github.com/apache/airflow/blob/master/UPDATING.md`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org