You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/05/02 17:58:19 UTC
[jira] [Commented] (THRIFT-2505) struct should always be a pointer
to avoid copying of potentially size-unbounded structs
[ https://issues.apache.org/jira/browse/THRIFT-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13987836#comment-13987836 ]
ASF GitHub Bot commented on THRIFT-2505:
----------------------------------------
GitHub user apesternikov opened a pull request:
https://github.com/apache/thrift/pull/116
THRIFT-2505
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apesternikov/thrift go_struct
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/116.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #116
----
commit 69bbf0e2b148cb1f48e24f46d181cc4d5dc35786
Author: Aleksey Pesternikov <ap...@alekseys-mbp.att.net>
Date: 2014-05-02T15:45:15Z
struct should always be a pointer to avoid copying of potentially size-unbounded structs
----
> struct should always be a pointer to avoid copying of potentially size-unbounded structs
> ----------------------------------------------------------------------------------------
>
> Key: THRIFT-2505
> URL: https://issues.apache.org/jira/browse/THRIFT-2505
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
> Reporter: Aleksey Pesternikov
>
> THRIFT-2451 changed the way structs are mapped. Unfortunately that introduced passing structs by value as function arguments and returned values in many places. I'm changing it back to pointers.
--
This message was sent by Atlassian JIRA
(v6.2#6252)