[jira] Commented: (DERBY-3163) Derby JUnit test framework adaptions to run existing tests against replicated databases

["Øystein Grøvlen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567687#action_12567687 ] 

Øystein Grøvlen commented on DERBY-3163:
----------------------------------------

Thanks for the patch, Ole.

1. TestConfiguration: I see several questions and remarks like "This
   looks bogus" in comments that makes me a bit unsure about how ready
   this patch is.  I think some of the comments should be cleaned up.

2. CleanDatabaseTestSetup: 
   a. The added constructor is as far as I can see, not used.  Is
      future use planned?  It is not clear to me when you would use
      this as opposed to the new methods in TestConfiguration.
   
   b. Why are the added fields static?  

   c. setUp() contains two assignments to current.  The first does not
      seem to serve any purpose since, if the variable is used, it
      will always be set a second time before it is used.
 
3. AnsiTrimTest/CreateTableFromQueryTest: It is not clear to me what
   the purpose of the refactoring of the statement executions is.  Is
   this just preparing for future changes?

4. Minor nits: 
   a. Several lines are longer that 80 chars.  

   b. Code that is commented out.


> Derby JUnit test framework adaptions to run existing tests against replicated databases
> ---------------------------------------------------------------------------------------
>
>                 Key: DERBY-3163
>                 URL: https://issues.apache.org/jira/browse/DERBY-3163
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions: 10.4.0.0
>            Reporter: Ole Solberg
>            Assignee: Ole Solberg
>            Priority: Minor
>         Attachments: derby-3163.1-v1.diff.txt, derby-3163.1-v2.diff.txt, derby-3163.2-v1.diff.txt, derby-3163.2-v2.diff.txt
>
>
> Extensions to run existing Apache Derby tests (old test harness tests ("derbyall" kind)
>   and junit tests)
>   This requires
>  - Running existing tests against already started servers on "non-localhost" machines.
>  - verificationclients checking slave vs. master.
>  - ... 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.