You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by sarutak <gi...@git.apache.org> on 2014/08/23 11:29:12 UTC

[GitHub] spark pull request: [SPARK-3192] Some scripts have 2 space indenta...

GitHub user sarutak opened a pull request:

    https://github.com/apache/spark/pull/2104

    [SPARK-3192] Some scripts have 2 space indentation but other scripts have 4 space indentation.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sarutak/spark SPARK-3192

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/2104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2104
    
----
commit be4736bcff503380f254f1e7f8482d00182e236a
Author: Cheng Lian <li...@gmail.com>
Date:   2014-08-14T13:28:44Z

    Report better error message when running JDBC/CLI without hive-thriftserver profile enabled

commit 9c894d34327e608461bbe9be5ae5fcbb4ac6dd44
Author: Cheng Lian <li...@gmail.com>
Date:   2014-08-21T06:15:47Z

    Fixed bin/spark-sql -S option typo

commit a89e66df0085ddac4455654567ee95bc2a4e879a
Author: Cheng Lian <li...@gmail.com>
Date:   2014-08-21T06:40:20Z

    Fixed command line options quotation in scripts

commit 81b43a897b241eca16e75668557ecd81cb25c41a
Author: Cheng Lian <li...@gmail.com>
Date:   2014-08-21T07:18:01Z

    Shorten timeout to more reasonable value

commit 8c6f6581e609ceffc130404b57e3535a869a88e4
Author: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Date:   2014-08-23T09:01:35Z

    Merge branch 'spark-3026' of https://github.com/liancheng/spark into SPARK-2964

commit ffb68fa9a6aa51d08383503b96a33f6e44333fe0
Author: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Date:   2014-08-23T09:13:11Z

    Modified spark-sql and start-thriftserver.sh to use bin/utils.sh

commit 9b63cfc4ce96e58755ee8a8f0bae15c4c849e2e6
Author: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Date:   2014-08-23T09:28:33Z

    Modified indentation of spark-shell

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3192] Some scripts have 2 space indenta...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/2104#issuecomment-53148100
  
      [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19104/consoleFull) for   PR 2104 at commit [`db78419`](https://github.com/apache/spark/commit/db78419bd76a8be22467d40e38b68acb74b18ca7).
     * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3192] Some scripts have 2 space indenta...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/2104#issuecomment-53149178
  
      [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19104/consoleFull) for   PR 2104 at commit [`db78419`](https://github.com/apache/spark/commit/db78419bd76a8be22467d40e38b68acb74b18ca7).
     * This patch **passes** unit tests.
     * This patch merges cleanly.
     * This patch adds the following public classes _(experimental)_:
      * `    $FWDIR/bin/spark-submit --class org.apache.spark.repl.Main "$`
      * `    $FWDIR/bin/spark-submit --class org.apache.spark.repl.Main "$`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3192] Some scripts have 2 space indenta...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/2104


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3192] Some scripts have 2 space indenta...

Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:

    https://github.com/apache/spark/pull/2104#issuecomment-53199130
  
    Thanks - this seems straightforward. I merged this into master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org