You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/29 19:37:31 UTC

[GitHub] [incubator-nuttx] daniel-p-carvalho opened a new pull request #4254: STM32 DAC Driver - Add support to DAC3 for STM32G4 devices

daniel-p-carvalho opened a new pull request #4254:
URL: https://github.com/apache/incubator-nuttx/pull/4254


   ## Summary
   Add support to DAC3 for STM32G4 devices. The nucleo-g431kb:comp configuration was changed to use DAC3CH2 signal on.)
   COMP2 inverting input.
   
   ## Impact
   
   ## Testing
   Tested on nucleo-g431kb board.
   
   ![test_results](https://user-images.githubusercontent.com/59295259/127555074-5da93187-58a6-4964-afda-2e04e7703ca3.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] daniel-p-carvalho closed pull request #4254: STM32 DAC Driver - Add support to DAC3 for STM32G4 devices

Posted by GitBox <gi...@apache.org>.
daniel-p-carvalho closed pull request #4254:
URL: https://github.com/apache/incubator-nuttx/pull/4254


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #4254: STM32 DAC Driver - Add support to DAC3 for STM32G4 devices

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #4254:
URL: https://github.com/apache/incubator-nuttx/pull/4254#issuecomment-889455232


   You don't need to close, just modify it, do a git rebase interactive and push forced ;-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis edited a comment on pull request #4254: STM32 DAC Driver - Add support to DAC3 for STM32G4 devices

Posted by GitBox <gi...@apache.org>.
acassis edited a comment on pull request #4254:
URL: https://github.com/apache/incubator-nuttx/pull/4254#issuecomment-889444416


   Hi @daniel-p-carvalho please update your config:
   
   ```
   ./tools/refresh.sh --silent nucleo-g431kb/comp
    ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #4254: STM32 DAC Driver - Add support to DAC3 for STM32G4 devices

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #4254:
URL: https://github.com/apache/incubator-nuttx/pull/4254#issuecomment-889444416


   Hi @daniel-p-carvalho please update your config:
   
   ```
   ./tools/refresh.sh --silent nucleo-g431kb/comp
    ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] daniel-p-carvalho commented on pull request #4254: STM32 DAC Driver - Add support to DAC3 for STM32G4 devices

Posted by GitBox <gi...@apache.org>.
daniel-p-carvalho commented on pull request #4254:
URL: https://github.com/apache/incubator-nuttx/pull/4254#issuecomment-889462151


   I decided to close it because I made a mess when I did a git rebase. I
   found it easier to create a new branch and import the changes.
   
   Thanks for the help
   
   Daniel Pereira de Carvalho
   
   
   Em qui., 29 de jul. de 2021 às 18:02, Alan Carvalho de Assis <
   ***@***.***> escreveu:
   
   > You don't need to close, just modify it, do a git rebase interactive and
   > push forced ;-)
   >
   > —
   > You are receiving this because you modified the open/close state.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-nuttx/pull/4254#issuecomment-889455232>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AOEMMGYA26VKFA2SBY27C5LT2G6VNANCNFSM5BHDVOMQ>
   > .
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org