You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Brown (Code Review)" <ge...@cloudera.org> on 2017/01/19 18:11:18 UTC
[Impala-ASF-CR] IMPALA-4775: minor adjustments to python test infra logging
Michael Brown has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5746
Change subject: IMPALA-4775: minor adjustments to python test infra logging
......................................................................
IMPALA-4775: minor adjustments to python test infra logging
- Set up log handler to append, not truncate. This was the cause of
IMPALA-4775.
Other improvements:
- Log a thread name, not thread ID. Thread names are more useful.
- Use ISO 8601-like timestamps
I tested that running disrepancy_searcher.py doesn't overwrite its logs
anymore. One such command that could reproduce it is:
tests/comparison/discrepancy_searcher.py \
--use-postgresql \
--query-count 1 \
--db-name tpch_kudu
I also ensured the stress test (concurrent_select.py) still logged to
its file.
Change-Id: I2b7af5b2be20f3c6f38d25612f6888433c62d693
---
M tests/comparison/cli_options.py
M tests/comparison/discrepancy_searcher.py
M tests/stress/concurrent_select.py
3 files changed, 11 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/5746/1
--
To view, visit http://gerrit.cloudera.org:8080/5746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b7af5b2be20f3c6f38d25612f6888433c62d693
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-4775: minor adjustments to python test infra logging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4775: minor adjustments to python test infra logging
......................................................................
IMPALA-4775: minor adjustments to python test infra logging
- Set up log handler to append, not truncate. This was the cause of
IMPALA-4775.
Other improvements:
- Log a thread name, not thread ID. Thread names are more useful.
- Use ISO 8601-like timestamps
I tested that running disrepancy_searcher.py doesn't overwrite its logs
anymore. One such command that could reproduce it is:
tests/comparison/discrepancy_searcher.py \
--use-postgresql \
--query-count 1 \
--db-name tpch_kudu
I also ensured the stress test (concurrent_select.py) still logged to
its file.
Change-Id: I2b7af5b2be20f3c6f38d25612f6888433c62d693
Reviewed-on: http://gerrit.cloudera.org:8080/5746
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M tests/comparison/cli_options.py
M tests/comparison/discrepancy_searcher.py
M tests/stress/concurrent_select.py
3 files changed, 11 insertions(+), 9 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Alex Behm: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/5746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b7af5b2be20f3c6f38d25612f6888433c62d693
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-4775: minor adjustments to python test infra logging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4775: minor adjustments to python test infra logging
......................................................................
Patch Set 1:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/199/
--
To view, visit http://gerrit.cloudera.org:8080/5746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b7af5b2be20f3c6f38d25612f6888433c62d693
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4775: minor adjustments to python test infra logging
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-4775: minor adjustments to python test infra logging
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b7af5b2be20f3c6f38d25612f6888433c62d693
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4775: minor adjustments to python test infra logging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4775: minor adjustments to python test infra logging
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b7af5b2be20f3c6f38d25612f6888433c62d693
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4775: minor adjustments to python test infra logging
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-4775: minor adjustments to python test infra logging
......................................................................
Patch Set 1:
Thank you Alex. Could you please start GVO?
--
To view, visit http://gerrit.cloudera.org:8080/5746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b7af5b2be20f3c6f38d25612f6888433c62d693
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No