You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2023/05/01 15:52:37 UTC

svn commit: r1909542 - /pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/colorpane/CSDeviceN.java

Author: tilman
Date: Mon May  1 15:52:37 2023
New Revision: 1909542

URL: http://svn.apache.org/viewvc?rev=1909542&view=rev
Log:
PDFBOX-4892: simplify code, as suggested by valerybokov

Modified:
    pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/colorpane/CSDeviceN.java

Modified: pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/colorpane/CSDeviceN.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/colorpane/CSDeviceN.java?rev=1909542&r1=1909541&r2=1909542&view=diff
==============================================================================
--- pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/colorpane/CSDeviceN.java (original)
+++ pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/colorpane/CSDeviceN.java Mon May  1 15:52:37 2023
@@ -27,6 +27,7 @@ import javax.swing.JPanel;
 import javax.swing.JScrollPane;
 import javax.swing.JTable;
 import java.io.IOException;
+import java.util.List;
 
 import org.apache.pdfbox.cos.COSArray;
 import org.apache.pdfbox.pdmodel.graphics.color.PDDeviceN;
@@ -62,17 +63,15 @@ public class CSDeviceN
      */
     private DeviceNColorant[] getColorantData() throws IOException
     {
-        int componentCount = deviceN.getNumberOfComponents();
+        List<String> colorantNames = deviceN.getColorantNames();
+        int componentCount = colorantNames.size();
         DeviceNColorant[] colorants = new DeviceNColorant[componentCount];
         for (int i = 0; i < componentCount; i++)
         {
             DeviceNColorant colorant = new DeviceNColorant();
-
-            colorant.setName(deviceN.getColorantNames().get(i));
+            colorant.setName(colorantNames.get(i));
             float[] maximum = new float[componentCount];
-            Arrays.fill(maximum, 0);
             float[] minimum = new float[componentCount];
-            Arrays.fill(minimum, 0);
             maximum[i] = 1;
             colorant.setMaximum(getColorObj(deviceN.toRGB(maximum)));
             colorant.setMinimum(getColorObj(deviceN.toRGB(minimum)));