[jira] [Comment Edited] (SLING-3034) Check contents of healtchecks bundle

["Bertrand Delacretaz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756090#comment-13756090 ] 

Bertrand Delacretaz edited comment on SLING-3034 at 9/2/13 2:02 PM:
--------------------------------------------------------------------

> Maybe we should simply move CompositeHealthCheck, ScriptableHealthCheck and JmxAttributeHealthCheck 
> to the api bundle - as this is kind of an api

We could, and we should then rename that bundle to "core" (again ;-) as it wouldn't be API-only anymore. 

I'd be ok with a core bundle including the API and these relatively core services, and a support bundle with the others.
                
      was (Author: bdelacretaz):
    > Maybe we should simply move CompositeHealthCheck, ScriptableHealthCheck and JmxAttributeHealthCheck 
> to the api bundle - as this is kind of an api

We could, and we should then rename that bundle to "core" as it wouldn't be API-only anymore. 

I'd be ok with a core bundle including the API and these relatively core services, and a support bundle with the others.
                  
> Check contents of healtchecks bundle
> ------------------------------------
>
>                 Key: SLING-3034
>                 URL: https://issues.apache.org/jira/browse/SLING-3034
>             Project: Sling
>          Issue Type: Task
>          Components: Health Check
>            Reporter: Carsten Ziegeler
>             Fix For: healthcheck-api 1.0.0
>
>
> The current healtchecks bundle seems to be a collection of completely different things. I think we should reduce this to the bare minimum as these services are API.
> I think the CompositeHealthCheck is fine, as well as the ScriptableHealthCheck and the JmxAttributeHealthCheck.
> But I think the DefaultLoginsHealthCheck and the SlingRequestStatusHealthCheck should rather be moved out. Checking this stuff might look nice, but it imho it doesn't really provide a huge value. If you want to check the status of a request than you have to go all the way, the client browser would go. Otherwise your server looks fine but still a user does not get anything.
> The OsgiScriptBinding looks like a sample to me, we should rather remove this for now. Bundle information should be availabel as jmx info anyway.
> All services are configuration factories (which is good) but set the name to "org.apache.sling.hc.{classname}". I think we should use the real package name here, I see no good reason to use some fake package name

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira