You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/12/27 07:56:06 UTC
[GitHub] [commons-fileupload] arturobernalg opened a new pull request #50: Minor Improvement:
arturobernalg opened a new pull request #50:
URL: https://github.com/apache/commons-fileupload/pull/50
* Add final
* Remove Unused import
* Remove Unnecessary interface modifier
* Use Standard Charset object
* Fix JavaDoc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] coveralls edited a comment on pull request #50: Minor Improvement:
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #50:
URL: https://github.com/apache/commons-fileupload/pull/50#issuecomment-751437813
[](https://coveralls.io/builds/35954126)
Coverage decreased (-0.01%) to 78.327% when pulling **865ee24f46ed56feeb20713b0cd5c1d0e512cf4e on arturobernalg:feature/minor_improvement** into **80385a158432483a7e195a17df0dd74a5ad4ddb7 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] jochenw commented on pull request #50: Minor Improvement:
Posted by GitBox <gi...@apache.org>.
jochenw commented on pull request #50:
URL: https://github.com/apache/commons-fileupload/pull/50#issuecomment-752135284
Sorry, mismatched this PR with another one on commons-fileupload. However, my opinion remains: 24 affected files is *way* too much for "minor improvements".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] arturobernalg closed pull request #50: Minor Improvement:
Posted by GitBox <gi...@apache.org>.
arturobernalg closed pull request #50:
URL: https://github.com/apache/commons-fileupload/pull/50
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] coveralls commented on pull request #50: Minor Improvement:
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #50:
URL: https://github.com/apache/commons-fileupload/pull/50#issuecomment-751437813
[](https://coveralls.io/builds/35954093)
Coverage increased (+0.09%) to 78.43% when pulling **a34b64f2256b9dcb229da99afd088b9942ffbba0 on arturobernalg:feature/minor_improvement** into **80385a158432483a7e195a17df0dd74a5ad4ddb7 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] arturobernalg commented on pull request #50: Minor Improvement:
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #50:
URL: https://github.com/apache/commons-fileupload/pull/50#issuecomment-752372879
OK, I close the PR and split into 3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] jochenw commented on pull request #50: Minor Improvement:
Posted by GitBox <gi...@apache.org>.
jochenw commented on pull request #50:
URL: https://github.com/apache/commons-fileupload/pull/50#issuecomment-751444533
The fact, that you are changing no less than 2 files here, is an obvious contradiction to a "Minor Improvement". Could you, please, simplify that a lot, until I can inspect your changes one by one? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] coveralls edited a comment on pull request #50: Minor Improvement:
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #50:
URL: https://github.com/apache/commons-fileupload/pull/50#issuecomment-751437813
[](https://coveralls.io/builds/35954098)
Coverage increased (+0.09%) to 78.43% when pulling **a34b64f2256b9dcb229da99afd088b9942ffbba0 on arturobernalg:feature/minor_improvement** into **80385a158432483a7e195a17df0dd74a5ad4ddb7 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] coveralls edited a comment on pull request #50: Minor Improvement:
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #50:
URL: https://github.com/apache/commons-fileupload/pull/50#issuecomment-751437813
[](https://coveralls.io/builds/35954104)
Coverage increased (+0.09%) to 78.43% when pulling **a34b64f2256b9dcb229da99afd088b9942ffbba0 on arturobernalg:feature/minor_improvement** into **80385a158432483a7e195a17df0dd74a5ad4ddb7 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] jochenw edited a comment on pull request #50: Minor Improvement:
Posted by GitBox <gi...@apache.org>.
jochenw edited a comment on pull request #50:
URL: https://github.com/apache/commons-fileupload/pull/50#issuecomment-751444533
The fact, that you are changing no less than 20 files here, is an obvious contradiction to a "Minor Improvement". Could you, please, simplify that a lot, until I can inspect your changes one by one? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] coveralls edited a comment on pull request #50: Minor Improvement:
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #50:
URL: https://github.com/apache/commons-fileupload/pull/50#issuecomment-751437813
[](https://coveralls.io/builds/35954130)
Coverage decreased (-0.01%) to 78.327% when pulling **865ee24f46ed56feeb20713b0cd5c1d0e512cf4e on arturobernalg:feature/minor_improvement** into **80385a158432483a7e195a17df0dd74a5ad4ddb7 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org