You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Mohit Sabharwal <mo...@cloudera.com> on 2014/09/22 23:46:19 UTC

Review Request 25907: HIVE-8224 : Support Char, Varchar in AvroSerDe

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25907/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-8224
    https://issues.apache.org/jira/browse/HIVE-8224


Repository: hive-git


Description
-------

Both Char(n) and Varchar(n) represented as String primitive type in Avro.
Char(n) is persisted without padding, if any.


Diffs
-----

  data/files/avro_charvarchar.txt PRE-CREATION 
  ql/src/test/queries/clientpositive/avro_charvarchar.q PRE-CREATION 
  ql/src/test/results/clientpositive/avro_charvarchar.q.out PRE-CREATION 
  serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java 688b0727402c983341faa859bd889d11e95778e9 
  serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java 69545b046db06fd56f35a0da09d3d6960832484d 
  serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java 2bd48ca5cc8a4cc4b30961511668ae29049de3a1 
  serde/src/java/org/apache/hadoop/hive/serde2/avro/SchemaToTypeInfo.java 23e024fd2c68cfe0d445ba291c9268430d35c9e0 
  serde/src/java/org/apache/hadoop/hive/serde2/avro/TypeInfoToSchema.java 4169558a8467e569bf5adc2433e640c9589d3452 

Diff: https://reviews.apache.org/r/25907/diff/


Testing
-------

Add q-test.


Thanks,

Mohit Sabharwal


Re: Review Request 25907: HIVE-8224 : Support Char, Varchar in AvroSerDe

Posted by Mohit Sabharwal <mo...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25907/
-----------------------------------------------------------

(Updated Sept. 23, 2014, 2:50 a.m.)


Review request for hive.


Changes
-------

Updated with fix to TestTypeInfoToSchema.createAvroStructSchema 


Bugs: HIVE-8224
    https://issues.apache.org/jira/browse/HIVE-8224


Repository: hive-git


Description
-------

Both Char(n) and Varchar(n) represented as String primitive type in Avro.
Char(n) is persisted without padding, if any.


Diffs (updated)
-----

  data/files/avro_charvarchar.txt PRE-CREATION 
  ql/src/test/queries/clientpositive/avro_charvarchar.q PRE-CREATION 
  ql/src/test/results/clientpositive/avro_charvarchar.q.out PRE-CREATION 
  serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java 688b0727402c983341faa859bd889d11e95778e9 
  serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java 69545b046db06fd56f35a0da09d3d6960832484d 
  serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java 2bd48ca5cc8a4cc4b30961511668ae29049de3a1 
  serde/src/java/org/apache/hadoop/hive/serde2/avro/SchemaToTypeInfo.java 23e024fd2c68cfe0d445ba291c9268430d35c9e0 
  serde/src/java/org/apache/hadoop/hive/serde2/avro/TypeInfoToSchema.java 4169558a8467e569bf5adc2433e640c9589d3452 
  serde/src/test/org/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java 0f53e31d32137be89c6e7d0bcdc1b184c0964ad9 
  serde/src/test/resources/avro-struct.avsc c8c83d777ca6088723e6f1e5cd6e6547bc6a9bc3 

Diff: https://reviews.apache.org/r/25907/diff/


Testing
-------

Add q-test.


Thanks,

Mohit Sabharwal