You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/22 19:27:45 UTC

[GitHub] [arrow] dragosmg commented on a diff in pull request #13506: ARROW-16653: [R] All formats are supported with the lubridate `parse_date_time` binding

dragosmg commented on code in PR #13506:
URL: https://github.com/apache/arrow/pull/13506#discussion_r927934525


##########
r/R/dplyr-datetime-helpers.R:
##########
@@ -166,6 +166,18 @@ build_formats <- function(orders) {
   orders <- gsub("[^A-Za-z]", "", orders)
   orders <- gsub("Y", "y", orders)
 
+  invalid_orders <- nchar(gsub("[ymdqIHMS]", "", orders)) > 0

Review Comment:
   You might need to make this more permissive if you want to include the additional formats.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org