You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Hong Tang (JIRA)" <ji...@apache.org> on 2010/07/23 02:48:51 UTC
[jira] Created: (MAPREDUCE-1961) [gridmix3]
ConcurrentModificationException when shutting down Gridmix
[gridmix3] ConcurrentModificationException when shutting down Gridmix
---------------------------------------------------------------------
Key: MAPREDUCE-1961
URL: https://issues.apache.org/jira/browse/MAPREDUCE-1961
Project: Hadoop Map/Reduce
Issue Type: Bug
Reporter: Hong Tang
We observed the following exception occasionally at the end of the Gridmix run:
{code}
Exception in thread "StatsCollectorThread" java.util.ConcurrentModificationException
at java.util.AbstractList$Itr.checkForComodification(AbstractList.java:372)
at java.util.AbstractList$Itr.next(AbstractList.java:343)
at org.apache.hadoop.mapred.gridmix.Statistics$StatCollector.updateAndNotifyClusterStatsListeners(Statistics.java:220)
at org.apache.hadoop.mapred.gridmix.Statistics$StatCollector.run(Statistics.java:205)
{code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (MAPREDUCE-1961) [gridmix3]
ConcurrentModificationException when shutting down Gridmix
Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hong Tang reassigned MAPREDUCE-1961:
------------------------------------
Assignee: Hong Tang
> [gridmix3] ConcurrentModificationException when shutting down Gridmix
> ---------------------------------------------------------------------
>
> Key: MAPREDUCE-1961
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1961
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Hong Tang
> Assignee: Hong Tang
>
> We observed the following exception occasionally at the end of the Gridmix run:
> {code}
> Exception in thread "StatsCollectorThread" java.util.ConcurrentModificationException
> at java.util.AbstractList$Itr.checkForComodification(AbstractList.java:372)
> at java.util.AbstractList$Itr.next(AbstractList.java:343)
> at org.apache.hadoop.mapred.gridmix.Statistics$StatCollector.updateAndNotifyClusterStatsListeners(Statistics.java:220)
> at org.apache.hadoop.mapred.gridmix.Statistics$StatCollector.run(Statistics.java:205)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1961) [gridmix3]
ConcurrentModificationException when shutting down Gridmix
Posted by "Ranjit Mathew (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896501#action_12896501 ]
Ranjit Mathew commented on MAPREDUCE-1961:
------------------------------------------
+1 for the patch.
> [gridmix3] ConcurrentModificationException when shutting down Gridmix
> ---------------------------------------------------------------------
>
> Key: MAPREDUCE-1961
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1961
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Reporter: Hong Tang
> Assignee: Hong Tang
> Attachments: mr-1961-20100723.patch
>
>
> We observed the following exception occasionally at the end of the Gridmix run:
> {code}
> Exception in thread "StatsCollectorThread" java.util.ConcurrentModificationException
> at java.util.AbstractList$Itr.checkForComodification(AbstractList.java:372)
> at java.util.AbstractList$Itr.next(AbstractList.java:343)
> at org.apache.hadoop.mapred.gridmix.Statistics$StatCollector.updateAndNotifyClusterStatsListeners(Statistics.java:220)
> at org.apache.hadoop.mapred.gridmix.Statistics$StatCollector.run(Statistics.java:205)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1961) [gridmix3]
ConcurrentModificationException when shutting down Gridmix
Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hong Tang updated MAPREDUCE-1961:
---------------------------------
Attachment: mr-1961-20100723.patch
Trivial patch that uses CopyOnWriteArrayList to avoid concurrent modification. No unit test included as it is hard to reproduce the synchronization bug through unit tests.
> [gridmix3] ConcurrentModificationException when shutting down Gridmix
> ---------------------------------------------------------------------
>
> Key: MAPREDUCE-1961
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1961
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Hong Tang
> Assignee: Hong Tang
> Attachments: mr-1961-20100723.patch
>
>
> We observed the following exception occasionally at the end of the Gridmix run:
> {code}
> Exception in thread "StatsCollectorThread" java.util.ConcurrentModificationException
> at java.util.AbstractList$Itr.checkForComodification(AbstractList.java:372)
> at java.util.AbstractList$Itr.next(AbstractList.java:343)
> at org.apache.hadoop.mapred.gridmix.Statistics$StatCollector.updateAndNotifyClusterStatsListeners(Statistics.java:220)
> at org.apache.hadoop.mapred.gridmix.Statistics$StatCollector.run(Statistics.java:205)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1961) [gridmix3]
ConcurrentModificationException when shutting down Gridmix
Posted by "Ranjit Mathew (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ranjit Mathew updated MAPREDUCE-1961:
-------------------------------------
Component/s: contrib/gridmix
> [gridmix3] ConcurrentModificationException when shutting down Gridmix
> ---------------------------------------------------------------------
>
> Key: MAPREDUCE-1961
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1961
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Reporter: Hong Tang
> Assignee: Hong Tang
> Attachments: mr-1961-20100723.patch
>
>
> We observed the following exception occasionally at the end of the Gridmix run:
> {code}
> Exception in thread "StatsCollectorThread" java.util.ConcurrentModificationException
> at java.util.AbstractList$Itr.checkForComodification(AbstractList.java:372)
> at java.util.AbstractList$Itr.next(AbstractList.java:343)
> at org.apache.hadoop.mapred.gridmix.Statistics$StatCollector.updateAndNotifyClusterStatsListeners(Statistics.java:220)
> at org.apache.hadoop.mapred.gridmix.Statistics$StatCollector.run(Statistics.java:205)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1961) [gridmix3]
ConcurrentModificationException when shutting down Gridmix
Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891431#action_12891431 ]
Hong Tang commented on MAPREDUCE-1961:
--------------------------------------
It seems that StatsCollectorThread is still active when we call "clusterStatlisteners.clear();" from "Statistics.shutdown()".
A simple fix is to replace "clusterStatlisteners.clear();" with "lusterStatlisteners = new ArrayList<StatListener<ClusterStats>>()".
While we are at it, we probably should also fix the same problem with jobStatListeners.
> [gridmix3] ConcurrentModificationException when shutting down Gridmix
> ---------------------------------------------------------------------
>
> Key: MAPREDUCE-1961
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1961
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Hong Tang
>
> We observed the following exception occasionally at the end of the Gridmix run:
> {code}
> Exception in thread "StatsCollectorThread" java.util.ConcurrentModificationException
> at java.util.AbstractList$Itr.checkForComodification(AbstractList.java:372)
> at java.util.AbstractList$Itr.next(AbstractList.java:343)
> at org.apache.hadoop.mapred.gridmix.Statistics$StatCollector.updateAndNotifyClusterStatsListeners(Statistics.java:220)
> at org.apache.hadoop.mapred.gridmix.Statistics$StatCollector.run(Statistics.java:205)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1961) [gridmix3]
ConcurrentModificationException when shutting down Gridmix
Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896765#action_12896765 ]
Hong Tang commented on MAPREDUCE-1961:
--------------------------------------
test-patch output:
{noformat}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no new tests are needed for this patch.
[exec] Also please list what manual steps were performed to verify this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
{noformat}
bq. -1 tests included
The patch fixes a concurrency bug, and is hard to write unit test to cover. The patch is tested with real benchmark runs and has shown to be effective.
> [gridmix3] ConcurrentModificationException when shutting down Gridmix
> ---------------------------------------------------------------------
>
> Key: MAPREDUCE-1961
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1961
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Reporter: Hong Tang
> Assignee: Hong Tang
> Attachments: mr-1961-20100723.patch
>
>
> We observed the following exception occasionally at the end of the Gridmix run:
> {code}
> Exception in thread "StatsCollectorThread" java.util.ConcurrentModificationException
> at java.util.AbstractList$Itr.checkForComodification(AbstractList.java:372)
> at java.util.AbstractList$Itr.next(AbstractList.java:343)
> at org.apache.hadoop.mapred.gridmix.Statistics$StatCollector.updateAndNotifyClusterStatsListeners(Statistics.java:220)
> at org.apache.hadoop.mapred.gridmix.Statistics$StatCollector.run(Statistics.java:205)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1961) [gridmix3]
ConcurrentModificationException when shutting down Gridmix
Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hong Tang updated MAPREDUCE-1961:
---------------------------------
Status: Open (was: Patch Available)
> [gridmix3] ConcurrentModificationException when shutting down Gridmix
> ---------------------------------------------------------------------
>
> Key: MAPREDUCE-1961
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1961
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Hong Tang
> Assignee: Hong Tang
> Attachments: mr-1961-20100723.patch
>
>
> We observed the following exception occasionally at the end of the Gridmix run:
> {code}
> Exception in thread "StatsCollectorThread" java.util.ConcurrentModificationException
> at java.util.AbstractList$Itr.checkForComodification(AbstractList.java:372)
> at java.util.AbstractList$Itr.next(AbstractList.java:343)
> at org.apache.hadoop.mapred.gridmix.Statistics$StatCollector.updateAndNotifyClusterStatsListeners(Statistics.java:220)
> at org.apache.hadoop.mapred.gridmix.Statistics$StatCollector.run(Statistics.java:205)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1961) [gridmix3]
ConcurrentModificationException when shutting down Gridmix
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926094#action_12926094 ]
Hudson commented on MAPREDUCE-1961:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See [https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/])
> [gridmix3] ConcurrentModificationException when shutting down Gridmix
> ---------------------------------------------------------------------
>
> Key: MAPREDUCE-1961
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1961
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Reporter: Hong Tang
> Assignee: Hong Tang
> Fix For: 0.22.0
>
> Attachments: mr-1961-20100723.patch
>
>
> We observed the following exception occasionally at the end of the Gridmix run:
> {code}
> Exception in thread "StatsCollectorThread" java.util.ConcurrentModificationException
> at java.util.AbstractList$Itr.checkForComodification(AbstractList.java:372)
> at java.util.AbstractList$Itr.next(AbstractList.java:343)
> at org.apache.hadoop.mapred.gridmix.Statistics$StatCollector.updateAndNotifyClusterStatsListeners(Statistics.java:220)
> at org.apache.hadoop.mapred.gridmix.Statistics$StatCollector.run(Statistics.java:205)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1961) [gridmix3]
ConcurrentModificationException when shutting down Gridmix
Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hong Tang updated MAPREDUCE-1961:
---------------------------------
Status: Patch Available (was: Open)
retry hudson
> [gridmix3] ConcurrentModificationException when shutting down Gridmix
> ---------------------------------------------------------------------
>
> Key: MAPREDUCE-1961
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1961
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Hong Tang
> Assignee: Hong Tang
> Attachments: mr-1961-20100723.patch
>
>
> We observed the following exception occasionally at the end of the Gridmix run:
> {code}
> Exception in thread "StatsCollectorThread" java.util.ConcurrentModificationException
> at java.util.AbstractList$Itr.checkForComodification(AbstractList.java:372)
> at java.util.AbstractList$Itr.next(AbstractList.java:343)
> at org.apache.hadoop.mapred.gridmix.Statistics$StatCollector.updateAndNotifyClusterStatsListeners(Statistics.java:220)
> at org.apache.hadoop.mapred.gridmix.Statistics$StatCollector.run(Statistics.java:205)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1961) [gridmix3]
ConcurrentModificationException when shutting down Gridmix
Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hong Tang updated MAPREDUCE-1961:
---------------------------------
Status: Patch Available (was: Open)
> [gridmix3] ConcurrentModificationException when shutting down Gridmix
> ---------------------------------------------------------------------
>
> Key: MAPREDUCE-1961
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1961
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Hong Tang
> Assignee: Hong Tang
> Attachments: mr-1961-20100723.patch
>
>
> We observed the following exception occasionally at the end of the Gridmix run:
> {code}
> Exception in thread "StatsCollectorThread" java.util.ConcurrentModificationException
> at java.util.AbstractList$Itr.checkForComodification(AbstractList.java:372)
> at java.util.AbstractList$Itr.next(AbstractList.java:343)
> at org.apache.hadoop.mapred.gridmix.Statistics$StatCollector.updateAndNotifyClusterStatsListeners(Statistics.java:220)
> at org.apache.hadoop.mapred.gridmix.Statistics$StatCollector.run(Statistics.java:205)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1961) [gridmix3]
ConcurrentModificationException when shutting down Gridmix
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated MAPREDUCE-1961:
-------------------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Fix Version/s: 0.22.0
Resolution: Fixed
+1
I committed this. Thanks, Hong!
> [gridmix3] ConcurrentModificationException when shutting down Gridmix
> ---------------------------------------------------------------------
>
> Key: MAPREDUCE-1961
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1961
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Reporter: Hong Tang
> Assignee: Hong Tang
> Fix For: 0.22.0
>
> Attachments: mr-1961-20100723.patch
>
>
> We observed the following exception occasionally at the end of the Gridmix run:
> {code}
> Exception in thread "StatsCollectorThread" java.util.ConcurrentModificationException
> at java.util.AbstractList$Itr.checkForComodification(AbstractList.java:372)
> at java.util.AbstractList$Itr.next(AbstractList.java:343)
> at org.apache.hadoop.mapred.gridmix.Statistics$StatCollector.updateAndNotifyClusterStatsListeners(Statistics.java:220)
> at org.apache.hadoop.mapred.gridmix.Statistics$StatCollector.run(Statistics.java:205)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.