[GitHub] [accumulo] brianloss commented on a change in pull request #2123: Improve SuspendedTabletsIT reliability

[GitBox <gi...@apache.org>]

brianloss commented on a change in pull request #2123:
URL: https://github.com/apache/accumulo/pull/2123#discussion_r641675932



##########
File path: test/src/main/java/org/apache/accumulo/test/manager/SuspendedTabletsIT.java
##########
@@ -140,6 +193,7 @@ public void shutdownAndResumeTserver() throws Exception {
       }
 
       // remove servers with metadata on them from the list of servers to be shutdown
+      assertEquals("Expecting a single tServer in metadataServerSet", 1, metadataServerSet.size());
       tserverSet.removeAll(metadataServerSet);
 
       assertEquals("Expecting two tServers in shutdown-list", 2, tserverSet.size());

Review comment:
       This isn't a line I changed, but I did notice that the value 2 is hard-coded a bunch of places in the test. If I'm going to fix one, then they should probably all be fixed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org