You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "cbernier2 (via GitHub)" <gi...@apache.org> on 2023/05/19 02:49:16 UTC
[GitHub] [cordova-ios] cbernier2 opened a new pull request, #1326: (ios) fix: memory leak when removing the CDVViewController
cbernier2 opened a new pull request, #1326:
URL: https://github.com/apache/cordova-ios/pull/1326
### Platforms affected
iOS
### Motivation and Context
I am using Cordova inside a React Native application so I often need to destroy and re-create the CDVViewController.
### Description
Since I am using a custom scheme, it is leaking (the CDVViewController is never deallocated despite being remove from its parentViewController)
### Testing
I confirm that by changing strong to weak, the CDVViewController is deallocated as soon as it is removed from its parent view controller.
### Checklist
- [yes] I've run the tests to see all new and existing tests pass
- [no] I added automated test coverage as appropriate for this change
- [yes ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [no ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [no ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] dpogue merged pull request #1326: (ios) fix: memory leak when removing the CDVViewController
Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue merged PR #1326:
URL: https://github.com/apache/cordova-ios/pull/1326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-commenter commented on pull request #1326: (ios) fix: memory leak when removing the CDVViewController
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1326:
URL: https://github.com/apache/cordova-ios/pull/1326#issuecomment-1553940441
## [Codecov](https://app.codecov.io/gh/apache/cordova-ios/pull/1326?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1326](https://app.codecov.io/gh/apache/cordova-ios/pull/1326?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7c5ff48) into [master](https://app.codecov.io/gh/apache/cordova-ios/commit/c000a1b5d9ec587f64d78219167abde4bb21a1c2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c000a1b) will **decrease** coverage by `0.04%`.
> The diff coverage is `66.66%`.
```diff
@@ Coverage Diff @@
## master #1326 +/- ##
==========================================
- Coverage 78.64% 78.61% -0.04%
==========================================
Files 15 15
Lines 1789 1791 +2
==========================================
+ Hits 1407 1408 +1
- Misses 382 383 +1
```
| [Impacted Files](https://app.codecov.io/gh/apache/cordova-ios/pull/1326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [lib/create.js](https://app.codecov.io/gh/apache/cordova-ios/pull/1326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGliL2NyZWF0ZS5qcw==) | `94.59% <66.66%> (-1.24%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] dpogue commented on pull request #1326: (ios) fix: memory leak when removing the CDVViewController
Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue commented on PR #1326:
URL: https://github.com/apache/cordova-ios/pull/1326#issuecomment-1553936327
This sounds like it solves https://github.com/apache/cordova-ios/issues/1071, right?
And then https://github.com/apache/cordova-ios/issues/920 is a different, unrelated memory leak?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] cbernier2 commented on pull request #1326: (ios) fix: memory leak when removing the CDVViewController
Posted by "cbernier2 (via GitHub)" <gi...@apache.org>.
cbernier2 commented on PR #1326:
URL: https://github.com/apache/cordova-ios/pull/1326#issuecomment-1553938474
Oh right, it should fix those 2 issues, at least for me there's no more leak: both the webView and view controller get deallocated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org