You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by nikhilkh <gi...@git.apache.org> on 2016/04/26 07:13:21 UTC

[GitHub] cordova-docs pull request: Use XML entities in attributes

GitHub user nikhilkh opened a pull request:

    https://github.com/apache/cordova-docs/pull/585

    Use XML entities in attributes

    This makes the XML well formed

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nikhilkh/cordova-docs patch-5

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-docs/pull/585.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #585
    
----
commit f9970ce35872e00d405db92e26df2f21c6c53fa5
Author: Nikhil Khandelwal <ni...@microsoft.com>
Date:   2016-04-26T05:12:39Z

    Use XML entities in attributes
    
    This makes the XML well formed

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request: Use XML entities in attributes

Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:

    https://github.com/apache/cordova-docs/pull/585#issuecomment-214635727
  
    These were rendering properly in github's markdown, is this an issue with our own document md->html conversion?
    
    ![image](https://cloud.githubusercontent.com/assets/46134/14808845/821e05b6-0b3d-11e6-8253-ad87d5501875.png)
    
    The previous version was passing online xml validation tools.
    I worry that if we change the docs to be 'proper', developers will use this syntax verbatim and our own code in cordova-lib will not handle it properly. Do you know if we handle this &gt; and > equally?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request: Use XML entities in attributes

Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:

    https://github.com/apache/cordova-docs/pull/585#issuecomment-214846992
  
    It's really an issue with some XML parsers that conform to the spec on "well-formed" XML. In particular, .NET XML parsers used by Visual Studio fail if you do not use entities within attributes.
    
    Our own node code uses element tree which works well with entities in attributes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request: Use XML entities in attributes

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-docs/pull/585


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org