You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2015/05/08 13:07:42 UTC
Review Request 33973: Kerberos service check is named "Create
principals"
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33973/
-----------------------------------------------------------
Review request for Ambari, Emil Anca, John Speidel, Robert Nettleton, and Tom Beerbower.
Bugs: AMBARI-11017
https://issues.apache.org/jira/browse/AMBARI-11017
Repository: ambari
Description
-------
1. Deploy cluster
2. Enable security
3. Run Kerberos service check
In background operations Kerberos service check is named as "Create principals"
#Solution#
Force the request context to be the one indicated in the request by explicity setting it rather than relying on the value from the first stage in the response.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 7b77bfa
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java cd74c22
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java ebe0763
Diff: https://reviews.apache.org/r/33973/diff/
Testing
-------
Manually tested in cluster.
Updated `org/apache/ambari/server/controller/AmbariManagementControllerTest.java`.
#Jenkins test result: PENDING#
Thanks,
Robert Levas
Re: Review Request 33973: Kerberos service check is named "Create
principals"
Posted by Emil Anca <ea...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33973/#review82990
-----------------------------------------------------------
Ship it!
Ship It!
- Emil Anca
On May 8, 2015, 11:09 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33973/
> -----------------------------------------------------------
>
> (Updated May 8, 2015, 11:09 a.m.)
>
>
> Review request for Ambari, Emil Anca, John Speidel, Robert Nettleton, and Tom Beerbower.
>
>
> Bugs: AMBARI-11017
> https://issues.apache.org/jira/browse/AMBARI-11017
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1. Deploy cluster
> 2. Enable security
> 3. Run Kerberos service check
>
> In background operations Kerberos service check is named as "Create principals"
>
> #Solution#
> Force the request context to be the one indicated in the request by explicity setting it rather than relying on the value from the first stage in the response.
> While at it, fixed an error message to help show more information if an error occurs while creating principals in an MIT KDC - ran into an error condtion while testing where this additional information would have been useful.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 7b77bfa
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java cd74c22
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java ebe0763
>
> Diff: https://reviews.apache.org/r/33973/diff/
>
>
> Testing
> -------
>
> Manually tested in cluster.
>
> Updated `org/apache/ambari/server/controller/AmbariManagementControllerTest.java`.
>
> #Jenkins test result: PENDING#
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 33973: Kerberos service check is named "Create
principals"
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33973/#review82994
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On May 8, 2015, 11:09 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33973/
> -----------------------------------------------------------
>
> (Updated May 8, 2015, 11:09 a.m.)
>
>
> Review request for Ambari, Emil Anca, John Speidel, Robert Nettleton, and Tom Beerbower.
>
>
> Bugs: AMBARI-11017
> https://issues.apache.org/jira/browse/AMBARI-11017
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1. Deploy cluster
> 2. Enable security
> 3. Run Kerberos service check
>
> In background operations Kerberos service check is named as "Create principals"
>
> #Solution#
> Force the request context to be the one indicated in the request by explicity setting it rather than relying on the value from the first stage in the response.
> While at it, fixed an error message to help show more information if an error occurs while creating principals in an MIT KDC - ran into an error condtion while testing where this additional information would have been useful.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 7b77bfa
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java cd74c22
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java ebe0763
>
> Diff: https://reviews.apache.org/r/33973/diff/
>
>
> Testing
> -------
>
> Manually tested in cluster.
>
> Updated `org/apache/ambari/server/controller/AmbariManagementControllerTest.java`.
>
> #Jenkins test result: PENDING#
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 33973: Kerberos service check is named "Create
principals"
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33973/
-----------------------------------------------------------
(Updated May 8, 2015, 7:09 a.m.)
Review request for Ambari, Emil Anca, John Speidel, Robert Nettleton, and Tom Beerbower.
Bugs: AMBARI-11017
https://issues.apache.org/jira/browse/AMBARI-11017
Repository: ambari
Description (updated)
-------
1. Deploy cluster
2. Enable security
3. Run Kerberos service check
In background operations Kerberos service check is named as "Create principals"
#Solution#
Force the request context to be the one indicated in the request by explicity setting it rather than relying on the value from the first stage in the response.
While at it, fixed an error message to help show more information if an error occurs while creating principals in an MIT KDC - ran into an error condtion while testing where this additional information would have been useful.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 7b77bfa
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java cd74c22
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java ebe0763
Diff: https://reviews.apache.org/r/33973/diff/
Testing
-------
Manually tested in cluster.
Updated `org/apache/ambari/server/controller/AmbariManagementControllerTest.java`.
#Jenkins test result: PENDING#
Thanks,
Robert Levas