[GitHub] [lucene-solr] mikemccand commented on a change in pull request #2245: LUCENE-9322: Move old field infos format to backwards-codecs.

[GitBox <gi...@apache.org>]

mikemccand commented on a change in pull request #2245:
URL: https://github.com/apache/lucene-solr/pull/2245#discussion_r564519920



##########
File path: lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene60/TestLucene60FieldInfosFormat.java
##########
@@ -14,17 +14,15 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.apache.lucene.codecs.lucene50;

Review comment:
       Hmm, why did this previously live under `lucene50` sub-package if it was `lucene60` format?

##########
File path: lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene60/Lucene60FieldInfosFormat.java
##########
@@ -311,6 +312,11 @@ private static IndexOptions getIndexOptions(IndexInput input, byte b) throws IOE
     }
   }
 
+  /**
+   * Note: although this format is only used on older versions, we need to keep the write logic

Review comment:
       I don't see how a new vector field would ever be written with this format?  That should use the latest (90) field infos format.
   
   Rather, I think the case that requires writing is when user opens old index/segment, that had used this `FieldInfosFormat`, and then user updates some doc values in the docs in this segment, and then `IndexWriter` needs to write that new doc values field, along with a new `.fnm` (field infos) file.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org