You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/15 18:08:36 UTC
[GitHub] [superset] hughhhh opened a new pull request #12555: fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN
hughhhh opened a new pull request #12555:
URL: https://github.com/apache/superset/pull/12555
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Hotfix #12509 to allow users to choose MAX_SQL_ROW
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12555: fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12555:
URL: https://github.com/apache/superset/pull/12555#issuecomment-761149215
# [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=h1) Report
> Merging [#12555](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=desc) (d607bfe) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **decrease** coverage by `1.44%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12555 +/- ##
==========================================
- Coverage 63.82% 62.37% -1.45%
==========================================
Files 486 1015 +529
Lines 29958 49592 +19634
Branches 0 4839 +4839
==========================================
+ Hits 19120 30932 +11812
- Misses 10838 18462 +7624
- Partials 0 198 +198
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `60.74% <100.00%> (?)` | |
| python | `63.44% <ø> (-0.38%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.67% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-2.82%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.55%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/migrations/shared/security\_converge.py](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvc2VjdXJpdHlfY29udmVyZ2UucHk=) | `86.82% <0.00%> (-0.11%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.57% <0.00%> (-0.02%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.36% <0.00%> (-0.01%)` | :arrow_down: |
| ... and [533 more](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=footer). Last update [fc5e311...d607bfe](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12555: fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12555:
URL: https://github.com/apache/superset/pull/12555#issuecomment-761149215
# [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=h1) Report
> Merging [#12555](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=desc) (d607bfe) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **increase** coverage by `2.92%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12555 +/- ##
==========================================
+ Coverage 63.82% 66.75% +2.92%
==========================================
Files 486 1015 +529
Lines 29958 49626 +19668
Branches 0 4839 +4839
==========================================
+ Hits 19120 33126 +14006
- Misses 10838 16377 +5539
- Partials 0 123 +123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.98% <100.00%> (?)` | |
| javascript | `60.74% <100.00%> (?)` | |
| python | `63.95% <ø> (+0.13%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.07% <100.00%> (ø)` | |
| [.../src/dashboard/util/serializeActiveFilterValues.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUFjdGl2ZUZpbHRlclZhbHVlcy5qcw==) | `100.00% <0.00%> (ø)` | |
| [...ontend/src/dashboard/util/getChartIdsFromLayout.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldENoYXJ0SWRzRnJvbUxheW91dC5qcw==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/filters/utils.ts](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvdXRpbHMudHM=) | `88.88% <0.00%> (ø)` | |
| [superset-frontend/src/components/Loading.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTG9hZGluZy50c3g=) | `100.00% <0.00%> (ø)` | |
| [...et-frontend/src/components/ListView/ActionsBar.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQWN0aW9uc0Jhci50c3g=) | `92.30% <0.00%> (ø)` | |
| [...nd/src/dashboard/util/getDetailedComponentWidth.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERldGFpbGVkQ29tcG9uZW50V2lkdGguanM=) | `100.00% <0.00%> (ø)` | |
| [...hboard/components/gridComponents/new/NewHeader.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdIZWFkZXIuanN4) | `100.00% <0.00%> (ø)` | |
| [...-frontend/src/dashboard/containers/FilterScope.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0ZpbHRlclNjb3BlLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `63.63% <0.00%> (ø)` | |
| ... and [522 more](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=footer). Last update [fc5e311...d607bfe](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12555: fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12555:
URL: https://github.com/apache/superset/pull/12555#issuecomment-761149215
# [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=h1) Report
> Merging [#12555](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=desc) (d607bfe) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **decrease** coverage by `1.22%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12555 +/- ##
==========================================
- Coverage 63.82% 62.60% -1.23%
==========================================
Files 486 1015 +529
Lines 29958 49607 +19649
Branches 0 4839 +4839
==========================================
+ Hits 19120 31055 +11935
- Misses 10838 18354 +7516
- Partials 0 198 +198
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `60.74% <100.00%> (?)` | |
| python | `63.82% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.67% <100.00%> (ø)` | |
| [...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeVByZXZpZXdNb2RhbC50c3g=) | `97.67% <0.00%> (ø)` | |
| [...tend/src/dashboard/util/getDirectPathToTabIndex.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERpcmVjdFBhdGhUb1RhYkluZGV4Lmpz) | `100.00% <0.00%> (ø)` | |
| [...t-frontend/src/dashboard/reducers/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9zbGljZUVudGl0aWVzLmpz) | `100.00% <0.00%> (ø)` | |
| [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `54.23% <0.00%> (ø)` | |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <0.00%> (ø)` | |
| [...explore/components/AdhocMetricEditPopoverTitle.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyVGl0bGUuanN4) | `66.66% <0.00%> (ø)` | |
| [superset-frontend/src/modules/dates.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21vZHVsZXMvZGF0ZXMuanM=) | `100.00% <0.00%> (ø)` | |
| [...rset-frontend/src/components/AsyncEsmComponent.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNFc21Db21wb25lbnQudHN4) | `97.29% <0.00%> (ø)` | |
| ... and [520 more](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=footer). Last update [fc5e311...d607bfe](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12555: fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12555:
URL: https://github.com/apache/superset/pull/12555#issuecomment-761149215
# [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=h1) Report
> Merging [#12555](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=desc) (d607bfe) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **decrease** coverage by `1.22%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12555 +/- ##
==========================================
- Coverage 63.82% 62.60% -1.23%
==========================================
Files 486 1015 +529
Lines 29958 49607 +19649
Branches 0 4839 +4839
==========================================
+ Hits 19120 31055 +11935
- Misses 10838 18354 +7516
- Partials 0 198 +198
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `60.74% <100.00%> (?)` | |
| python | `63.82% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.67% <100.00%> (ø)` | |
| [...tend/src/components/ListView/Filters/DateRange.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy9EYXRlUmFuZ2UudHN4) | `52.17% <0.00%> (ø)` | |
| [superset-frontend/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2FjaGVkTGFiZWwuanN4) | `42.10% <0.00%> (ø)` | |
| [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `70.83% <0.00%> (ø)` | |
| [superset-frontend/src/utils/reducerUtils.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL3JlZHVjZXJVdGlscy5qcw==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Select/utils.ts](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3V0aWxzLnRz) | `94.11% <0.00%> (ø)` | |
| [...hboard/components/gridComponents/new/NewColumn.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdDb2x1bW4uanN4) | `100.00% <0.00%> (ø)` | |
| [...rontend/src/components/ListView/Filters/Search.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy9TZWFyY2gudHN4) | `86.66% <0.00%> (ø)` | |
| [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `62.71% <0.00%> (ø)` | |
| [...rset-frontend/src/components/NavDropdown/index.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTmF2RHJvcGRvd24vaW5kZXgudHN4) | `100.00% <0.00%> (ø)` | |
| ... and [520 more](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=footer). Last update [fc5e311...d607bfe](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12555: fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12555:
URL: https://github.com/apache/superset/pull/12555#issuecomment-761149215
# [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=h1) Report
> Merging [#12555](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=desc) (d607bfe) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **increase** coverage by `2.92%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12555 +/- ##
==========================================
+ Coverage 63.82% 66.75% +2.92%
==========================================
Files 486 1015 +529
Lines 29958 49626 +19668
Branches 0 4839 +4839
==========================================
+ Hits 19120 33126 +14006
- Misses 10838 16377 +5539
- Partials 0 123 +123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.98% <100.00%> (?)` | |
| javascript | `60.74% <100.00%> (?)` | |
| python | `63.95% <ø> (+0.13%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.07% <100.00%> (ø)` | |
| [superset-frontend/src/components/Popover/index.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUG9wb3Zlci9pbmRleC50c3g=) | `100.00% <0.00%> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `86.51% <0.00%> (ø)` | |
| [...tend/src/SqlLab/components/ScheduleQueryButton.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24uanN4) | `10.00% <0.00%> (ø)` | |
| [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <0.00%> (ø)` | |
| [...uperset-frontend/src/components/PopoverSection.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUG9wb3ZlclNlY3Rpb24uanN4) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `100.00% <0.00%> (ø)` | |
| [...end/src/explore/components/ControlPanelSection.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxTZWN0aW9uLmpzeA==) | `95.65% <0.00%> (ø)` | |
| [...d/util/logging/getLoadStatsPerTopLevelComponent.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2xvZ2dpbmcvZ2V0TG9hZFN0YXRzUGVyVG9wTGV2ZWxDb21wb25lbnQuanM=) | `0.00% <0.00%> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `57.89% <0.00%> (ø)` | |
| ... and [522 more](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=footer). Last update [fc5e311...d607bfe](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #12555: fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #12555:
URL: https://github.com/apache/superset/pull/12555#discussion_r558489020
##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -539,9 +539,13 @@ class SqlEditor extends React.PureComponent {
}
renderQueryLimit() {
- const menuDropdown = (
+ // Adding SQL_MAX_ROW value to dropdown
+ const { maxRow } = this.props;
+ LIMIT_DROPDOWN.push(maxRow);
+
+ return (
<AntdMenu>
- {LIMIT_DROPDOWN.map(limit => (
+ {[...new Set(LIMIT_DROPDOWN)].map(limit => (
Review comment:
Thanks, @rusackas!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12555: fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12555:
URL: https://github.com/apache/superset/pull/12555#issuecomment-761149215
# [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=h1) Report
> Merging [#12555](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=desc) (d607bfe) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **increase** coverage by `2.92%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12555 +/- ##
==========================================
+ Coverage 63.82% 66.75% +2.92%
==========================================
Files 486 1015 +529
Lines 29958 49626 +19668
Branches 0 4839 +4839
==========================================
+ Hits 19120 33126 +14006
- Misses 10838 16377 +5539
- Partials 0 123 +123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.98% <100.00%> (?)` | |
| javascript | `60.74% <100.00%> (?)` | |
| python | `63.95% <ø> (+0.13%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.07% <100.00%> (ø)` | |
| [superset-frontend/src/views/CRUD/data/hooks.ts](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9ob29rcy50cw==) | `71.42% <0.00%> (ø)` | |
| [...explore/components/AdhocMetricEditPopoverTitle.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyVGl0bGUuanN4) | `90.00% <0.00%> (ø)` | |
| [...board/util/getSelectedChartIdForFilterScopeTree.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldFNlbGVjdGVkQ2hhcnRJZEZvckZpbHRlclNjb3BlVHJlZS5qcw==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/profile/App.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvQXBwLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...rset-frontend/src/dashboard/util/componentTypes.ts](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbXBvbmVudFR5cGVzLnRz) | `100.00% <0.00%> (ø)` | |
| [...end/src/components/Select/WindowedSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L2luZGV4LnRzeA==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/messageToasts/types.ts](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvdHlwZXMudHM=) | `100.00% <0.00%> (ø)` | |
| [...rontend/src/SqlLab/components/ShareSqlLabQuery.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NoYXJlU3FsTGFiUXVlcnkuanN4) | `92.68% <0.00%> (ø)` | |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <0.00%> (ø)` | |
| ... and [522 more](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=footer). Last update [fc5e311...d607bfe](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12555: fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12555:
URL: https://github.com/apache/superset/pull/12555#issuecomment-761149215
# [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=h1) Report
> Merging [#12555](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=desc) (d607bfe) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **increase** coverage by `2.84%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12555 +/- ##
==========================================
+ Coverage 63.82% 66.66% +2.84%
==========================================
Files 486 1015 +529
Lines 29958 49626 +19668
Branches 0 4839 +4839
==========================================
+ Hits 19120 33083 +13963
- Misses 10838 16416 +5578
- Partials 0 127 +127
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.60% <100.00%> (?)` | |
| javascript | `60.74% <100.00%> (?)` | |
| python | `63.95% <ø> (+0.13%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.07% <100.00%> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <0.00%> (ø)` | |
| [...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXRNb2RhbC50c3g=) | `57.57% <0.00%> (ø)` | |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `60.75% <0.00%> (ø)` | |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `52.22% <0.00%> (ø)` | |
| [superset-frontend/src/components/Loading.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTG9hZGluZy50c3g=) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Popover/index.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUG9wb3Zlci9pbmRleC50c3g=) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | `100.00% <0.00%> (ø)` | |
| [...frontend/src/views/CRUD/alert/AlertReportModal.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRSZXBvcnRNb2RhbC50c3g=) | `46.78% <0.00%> (ø)` | |
| [...t-frontend/src/dashboard/util/setPeriodicRunner.ts](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NldFBlcmlvZGljUnVubmVyLnRz) | `70.00% <0.00%> (ø)` | |
| ... and [522 more](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=footer). Last update [fc5e311...d607bfe](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12555: fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12555:
URL: https://github.com/apache/superset/pull/12555#issuecomment-761149215
# [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=h1) Report
> Merging [#12555](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=desc) (d607bfe) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **decrease** coverage by `1.45%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12555 +/- ##
==========================================
- Coverage 63.82% 62.36% -1.46%
==========================================
Files 486 1015 +529
Lines 29958 49607 +19649
Branches 0 4839 +4839
==========================================
+ Hits 19120 30939 +11819
- Misses 10838 18470 +7632
- Partials 0 198 +198
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `60.74% <100.00%> (?)` | |
| python | `63.43% <ø> (-0.39%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.67% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-2.82%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.55%)` | :arrow_down: |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <0.00%> (ø)` | |
| [...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXRNb2RhbC50c3g=) | `57.57% <0.00%> (ø)` | |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `59.49% <0.00%> (ø)` | |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `51.11% <0.00%> (ø)` | |
| ... and [525 more](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=footer). Last update [fc5e311...d607bfe](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh merged pull request #12555: fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN
Posted by GitBox <gi...@apache.org>.
hughhhh merged pull request #12555:
URL: https://github.com/apache/superset/pull/12555
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a change in pull request #12555: fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #12555:
URL: https://github.com/apache/superset/pull/12555#discussion_r558488596
##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -539,9 +539,13 @@ class SqlEditor extends React.PureComponent {
}
renderQueryLimit() {
- const menuDropdown = (
+ // Adding SQL_MAX_ROW value to dropdown
+ const { maxRow } = this.props;
+ LIMIT_DROPDOWN.push(maxRow);
+
+ return (
<AntdMenu>
- {LIMIT_DROPDOWN.map(limit => (
+ {[...new Set(LIMIT_DROPDOWN)].map(limit => (
Review comment:
Set does not order its contents, just makes sure they're unique, and adds them in the order they're added to the set. So this implementation _should_ _not_ affect the order of the contents of LIMIT_DROPDOWN.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12555: fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12555:
URL: https://github.com/apache/superset/pull/12555#discussion_r558572226
##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -539,9 +539,13 @@ class SqlEditor extends React.PureComponent {
}
renderQueryLimit() {
- const menuDropdown = (
+ // Adding SQL_MAX_ROW value to dropdown
+ const { maxRow } = this.props;
+ LIMIT_DROPDOWN.push(maxRow);
+
+ return (
<AntdMenu>
- {LIMIT_DROPDOWN.map(limit => (
+ {[...new Set(LIMIT_DROPDOWN)].map(limit => (
Review comment:
For the record, JavaScript sets are ordered: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set#iteration_methods
Set iterators returns items in insertion order.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12555: fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12555:
URL: https://github.com/apache/superset/pull/12555#issuecomment-761149215
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12555: fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12555:
URL: https://github.com/apache/superset/pull/12555#issuecomment-761149215
# [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=h1) Report
> Merging [#12555](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=desc) (d607bfe) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **decrease** coverage by `1.22%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12555 +/- ##
==========================================
- Coverage 63.82% 62.60% -1.23%
==========================================
Files 486 1015 +529
Lines 29958 49607 +19649
Branches 0 4839 +4839
==========================================
+ Hits 19120 31055 +11935
- Misses 10838 18354 +7516
- Partials 0 198 +198
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `60.74% <100.00%> (?)` | |
| python | `63.82% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.67% <100.00%> (ø)` | |
| [...rc/explore/components/controls/CheckboxControl.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9DaGVja2JveENvbnRyb2wuanN4) | `85.71% <0.00%> (ø)` | |
| [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `96.00% <0.00%> (ø)` | |
| [...re/components/controls/TimeSeriesColumnControl.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UaW1lU2VyaWVzQ29sdW1uQ29udHJvbC5qc3g=) | `57.40% <0.00%> (ø)` | |
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | `100.00% <0.00%> (ø)` | |
| [...uperset-frontend/src/components/FacePile/utils.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmFjZVBpbGUvdXRpbHMudHN4) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | `57.14% <0.00%> (ø)` | |
| [...end/src/visualizations/TimeTable/SparklineCell.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS9TcGFya2xpbmVDZWxsLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Loading.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTG9hZGluZy50c3g=) | `100.00% <0.00%> (ø)` | |
| [...s/controls/DateFilterControl/frame/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9Db21tb25GcmFtZS50c3g=) | `41.66% <0.00%> (ø)` | |
| ... and [520 more](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=footer). Last update [fc5e311...d607bfe](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12555: fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12555:
URL: https://github.com/apache/superset/pull/12555#issuecomment-761149215
# [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=h1) Report
> Merging [#12555](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=desc) (d607bfe) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **increase** coverage by `2.75%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12555 +/- ##
==========================================
+ Coverage 63.82% 66.58% +2.75%
==========================================
Files 486 1015 +529
Lines 29958 49626 +19668
Branches 0 4839 +4839
==========================================
+ Hits 19120 33042 +13922
- Misses 10838 16457 +5619
- Partials 0 127 +127
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.60% <100.00%> (?)` | |
| javascript | `60.74% <100.00%> (?)` | |
| python | `63.82% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.07% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (ø)` | |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `78.26% <0.00%> (ø)` | |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (ø)` | |
| [...et-frontend/src/dashboard/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC50c3g=) | `80.76% <0.00%> (ø)` | |
| [...perset-frontend/src/middleware/loggerMiddleware.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvbG9nZ2VyTWlkZGxld2FyZS5qcw==) | `95.00% <0.00%> (ø)` | |
| [.../src/explore/components/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyLmpzeA==) | `58.00% <0.00%> (ø)` | |
| [...nd/src/dashboard/util/isInDifferentFilterScopes.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzSW5EaWZmZXJlbnRGaWx0ZXJTY29wZXMuanM=) | `66.66% <0.00%> (ø)` | |
| [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | `75.00% <0.00%> (ø)` | |
| [...et-frontend/src/dashboard/actions/dashboardInfo.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEluZm8uanM=) | `100.00% <0.00%> (ø)` | |
| ... and [520 more](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=footer). Last update [fc5e311...d607bfe](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12555: fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12555:
URL: https://github.com/apache/superset/pull/12555#issuecomment-761149215
# [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=h1) Report
> Merging [#12555](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=desc) (d607bfe) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **decrease** coverage by `1.22%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12555 +/- ##
==========================================
- Coverage 63.82% 62.60% -1.23%
==========================================
Files 486 1015 +529
Lines 29958 49607 +19649
Branches 0 4839 +4839
==========================================
+ Hits 19120 31055 +11935
- Misses 10838 18354 +7516
- Partials 0 198 +198
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `60.74% <100.00%> (?)` | |
| python | `63.82% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.67% <100.00%> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `72.44% <0.00%> (ø)` | |
| [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `70.58% <0.00%> (ø)` | |
| [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `80.35% <0.00%> (ø)` | |
| [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `78.98% <0.00%> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/FormRow.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRm9ybVJvdy5qc3g=) | `92.30% <0.00%> (ø)` | |
| [superset-frontend/src/SqlLab/utils/sqlKeywords.ts](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi91dGlscy9zcWxLZXl3b3Jkcy50cw==) | `100.00% <0.00%> (ø)` | |
| ... and [520 more](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=footer). Last update [fc5e311...d607bfe](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #12555: fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #12555:
URL: https://github.com/apache/superset/pull/12555#discussion_r558482943
##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -539,9 +539,13 @@ class SqlEditor extends React.PureComponent {
}
renderQueryLimit() {
- const menuDropdown = (
+ // Adding SQL_MAX_ROW value to dropdown
+ const { maxRow } = this.props;
+ LIMIT_DROPDOWN.push(maxRow);
+
+ return (
<AntdMenu>
- {LIMIT_DROPDOWN.map(limit => (
+ {[...new Set(LIMIT_DROPDOWN)].map(limit => (
Review comment:
I'm not familiar with `Set` in Javascript, but in Python they're not ordered. Will this affect the order of the elements?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12555: fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12555:
URL: https://github.com/apache/superset/pull/12555#issuecomment-761149215
# [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=h1) Report
> Merging [#12555](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=desc) (d607bfe) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **increase** coverage by `2.92%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12555 +/- ##
==========================================
+ Coverage 63.82% 66.75% +2.92%
==========================================
Files 486 1015 +529
Lines 29958 49626 +19668
Branches 0 4839 +4839
==========================================
+ Hits 19120 33126 +14006
- Misses 10838 16377 +5539
- Partials 0 123 +123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.98% <100.00%> (?)` | |
| javascript | `60.74% <100.00%> (?)` | |
| python | `63.95% <ø> (+0.13%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.07% <100.00%> (ø)` | |
| [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `58.97% <0.00%> (ø)` | |
| [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `58.18% <0.00%> (ø)` | |
| [superset-frontend/src/explore/AdhocMetric.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQWRob2NNZXRyaWMuanM=) | `97.26% <0.00%> (ø)` | |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `100.00% <0.00%> (ø)` | |
| [...rontend/src/components/ListView/CardCollection.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQ2FyZENvbGxlY3Rpb24udHN4) | `76.92% <0.00%> (ø)` | |
| [...board/util/getSelectedChartIdForFilterScopeTree.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldFNlbGVjdGVkQ2hhcnRJZEZvckZpbHRlclNjb3BlVHJlZS5qcw==) | `0.00% <0.00%> (ø)` | |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `78.26% <0.00%> (ø)` | |
| [superset-frontend/src/utils/errorMessages.ts](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Vycm9yTWVzc2FnZXMudHM=) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/modules/dates.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21vZHVsZXMvZGF0ZXMuanM=) | `100.00% <0.00%> (ø)` | |
| ... and [522 more](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=footer). Last update [fc5e311...d607bfe](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a change in pull request #12555: fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #12555:
URL: https://github.com/apache/superset/pull/12555#discussion_r558600100
##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -539,9 +539,13 @@ class SqlEditor extends React.PureComponent {
}
renderQueryLimit() {
- const menuDropdown = (
+ // Adding SQL_MAX_ROW value to dropdown
+ const { maxRow } = this.props;
Review comment:
can we add some tests and check if `maxRow` is undefined? Will it print "undefined" as an option?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12555: fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12555:
URL: https://github.com/apache/superset/pull/12555#issuecomment-761149215
# [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=h1) Report
> Merging [#12555](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=desc) (d607bfe) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **decrease** coverage by `1.22%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12555 +/- ##
==========================================
- Coverage 63.82% 62.60% -1.23%
==========================================
Files 486 1015 +529
Lines 29958 49607 +19649
Branches 0 4839 +4839
==========================================
+ Hits 19120 31055 +11935
- Misses 10838 18354 +7516
- Partials 0 198 +198
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `60.74% <100.00%> (?)` | |
| python | `63.82% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.67% <100.00%> (ø)` | |
| [...rontend/src/SqlLab/components/ShareSqlLabQuery.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NoYXJlU3FsTGFiUXVlcnkuanN4) | `92.68% <0.00%> (ø)` | |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (ø)` | |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (ø)` | |
| [...rset-frontend/src/components/Icon/icon.stories.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pY29uLnN0b3JpZXMuanN4) | `0.00% <0.00%> (ø)` | |
| [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `54.23% <0.00%> (ø)` | |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `8.57% <0.00%> (ø)` | |
| [...uperset-frontend/src/components/PopoverSection.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUG9wb3ZlclNlY3Rpb24uanN4) | `100.00% <0.00%> (ø)` | |
| [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `58.18% <0.00%> (ø)` | |
| [...frontend/src/components/SupersetResourceSelect.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC50c3g=) | `71.42% <0.00%> (ø)` | |
| ... and [520 more](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=footer). Last update [fc5e311...d607bfe](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12555: fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12555:
URL: https://github.com/apache/superset/pull/12555#issuecomment-761149215
# [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=h1) Report
> Merging [#12555](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=desc) (d607bfe) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **increase** coverage by `2.92%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12555 +/- ##
==========================================
+ Coverage 63.82% 66.75% +2.92%
==========================================
Files 486 1015 +529
Lines 29958 49626 +19668
Branches 0 4839 +4839
==========================================
+ Hits 19120 33126 +14006
- Misses 10838 16377 +5539
- Partials 0 123 +123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.98% <100.00%> (?)` | |
| javascript | `60.74% <100.00%> (?)` | |
| python | `63.95% <ø> (+0.13%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.07% <100.00%> (ø)` | |
| [superset-frontend/src/components/Menu/NewMenu.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9OZXdNZW51LnRzeA==) | `78.57% <0.00%> (ø)` | |
| [...rset-frontend/src/common/components/Modal/index.ts](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL01vZGFsL2luZGV4LnRz) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/TableLoader.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVMb2FkZXIudHN4) | `31.57% <0.00%> (ø)` | |
| [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `83.78% <0.00%> (ø)` | |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `52.94% <0.00%> (ø)` | |
| [...frontend/src/components/ListView/Filters/index.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy9pbmRleC50c3g=) | `86.36% <0.00%> (ø)` | |
| [...d/src/views/CRUD/csstemplates/CssTemplateModal.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlTW9kYWwudHN4) | `67.61% <0.00%> (ø)` | |
| [...rontend/src/SqlLab/components/SaveDatasetModal.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVEYXRhc2V0TW9kYWwudHN4) | `87.50% <0.00%> (ø)` | |
| [...d/src/dashboard/components/FiltersBadge/Styles.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9TdHlsZXMudHN4) | `64.10% <0.00%> (ø)` | |
| ... and [522 more](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=footer). Last update [fc5e311...d607bfe](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12555: fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12555:
URL: https://github.com/apache/superset/pull/12555#issuecomment-761149215
# [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=h1) Report
> Merging [#12555](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=desc) (d607bfe) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **increase** coverage by `2.92%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12555 +/- ##
==========================================
+ Coverage 63.82% 66.75% +2.92%
==========================================
Files 486 1015 +529
Lines 29958 49626 +19668
Branches 0 4839 +4839
==========================================
+ Hits 19120 33126 +14006
- Misses 10838 16377 +5539
- Partials 0 123 +123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.98% <100.00%> (?)` | |
| javascript | `60.74% <100.00%> (?)` | |
| python | `63.95% <ø> (+0.13%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.07% <100.00%> (ø)` | |
| [...rset-frontend/src/components/LastUpdated/index.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFzdFVwZGF0ZWQvaW5kZXgudHN4) | `96.00% <0.00%> (ø)` | |
| [...d/src/dashboard/util/updateComponentParentsList.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3VwZGF0ZUNvbXBvbmVudFBhcmVudHNMaXN0Lmpz) | `87.50% <0.00%> (ø)` | |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `100.00% <0.00%> (ø)` | |
| [...rc/views/CRUD/alert/components/AlertStatusIcon.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvY29tcG9uZW50cy9BbGVydFN0YXR1c0ljb24udHN4) | `46.87% <0.00%> (ø)` | |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <0.00%> (ø)` | |
| [...ashboard/components/nativeFilters/ColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvQ29sdW1uU2VsZWN0LnRzeA==) | `60.60% <0.00%> (ø)` | |
| [...uperset-frontend/src/components/AsyncAceEditor.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNBY2VFZGl0b3IudHN4) | `85.71% <0.00%> (ø)` | |
| [...erset-frontend/src/profile/components/UserInfo.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9Vc2VySW5mby50c3g=) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/showSavedQuery/index.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Nob3dTYXZlZFF1ZXJ5L2luZGV4LmpzeA==) | `0.00% <0.00%> (ø)` | |
| ... and [522 more](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=footer). Last update [fc5e311...d607bfe](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12555: fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12555:
URL: https://github.com/apache/superset/pull/12555#issuecomment-761149215
# [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=h1) Report
> Merging [#12555](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=desc) (d607bfe) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **increase** coverage by `2.92%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12555 +/- ##
==========================================
+ Coverage 63.82% 66.75% +2.92%
==========================================
Files 486 1015 +529
Lines 29958 49626 +19668
Branches 0 4839 +4839
==========================================
+ Hits 19120 33126 +14006
- Misses 10838 16377 +5539
- Partials 0 123 +123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.98% <100.00%> (?)` | |
| javascript | `60.74% <100.00%> (?)` | |
| python | `63.95% <ø> (+0.13%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.07% <100.00%> (ø)` | |
| [...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeVByZXZpZXdNb2RhbC50c3g=) | `97.67% <0.00%> (ø)` | |
| [...tend/src/dashboard/util/getDirectPathToTabIndex.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERpcmVjdFBhdGhUb1RhYkluZGV4Lmpz) | `100.00% <0.00%> (ø)` | |
| [...t-frontend/src/dashboard/reducers/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9zbGljZUVudGl0aWVzLmpz) | `100.00% <0.00%> (ø)` | |
| [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `73.72% <0.00%> (ø)` | |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <0.00%> (ø)` | |
| [...explore/components/AdhocMetricEditPopoverTitle.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyVGl0bGUuanN4) | `90.00% <0.00%> (ø)` | |
| [superset-frontend/src/modules/dates.js](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21vZHVsZXMvZGF0ZXMuanM=) | `100.00% <0.00%> (ø)` | |
| [...rset-frontend/src/components/AsyncEsmComponent.tsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNFc21Db21wb25lbnQudHN4) | `97.29% <0.00%> (ø)` | |
| ... and [522 more](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=footer). Last update [fc5e311...d607bfe](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12555: fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12555:
URL: https://github.com/apache/superset/pull/12555#issuecomment-761149215
# [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=h1) Report
> Merging [#12555](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=desc) (d607bfe) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **decrease** coverage by `1.47%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12555 +/- ##
==========================================
- Coverage 63.82% 62.34% -1.48%
==========================================
Files 486 1015 +529
Lines 29958 49592 +19634
Branches 0 4839 +4839
==========================================
+ Hits 19120 30920 +11800
- Misses 10838 18474 +7636
- Partials 0 198 +198
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `60.74% <100.00%> (?)` | |
| python | `63.40% <ø> (-0.42%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.67% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-2.82%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `93.42% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.55%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.68% <0.00%> (-0.47%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| ... and [536 more](https://codecov.io/gh/apache/superset/pull/12555/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=footer). Last update [fc5e311...d607bfe](https://codecov.io/gh/apache/superset/pull/12555?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org