You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/02/15 10:42:00 UTC
[jira] [Commented] (FLINK-8662) FutureUtilsTest#testRetryWithDelay
unstable
[ https://issues.apache.org/jira/browse/FLINK-8662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365354#comment-16365354 ]
ASF GitHub Bot commented on FLINK-8662:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5494
[FLINK-8662] [tests] Harden FutureUtilsTest#testRetryWithDelay
## What is the purpose of the change
This commit moves the start of the time measurement before the triggering of
the retry with delay operation.
This PR is based on #5475.
## Verifying this change
This change is already covered by existing tests, such as `FutureUtilsTest`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixFutureUtilsTest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5494.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5494
----
commit 42f49ac9172fe5c3ff4cc45ccf5d82142351e4e2
Author: Till Rohrmann <tr...@...>
Date: 2018-01-30T14:15:49Z
[FLINK-8529] [flip6] Let Yarn entry points use APPLICATION_MASTER_PORT
Let all Yarn entry points use the YarnConfigOptions.APPLICATION_MASTER_PORT option
to specify the valid port range for the common RpcService.
This closes #5388.
commit b3122f26a8519169ed61e0ce95235a59c677c9bc
Author: Till Rohrmann <tr...@...>
Date: 2018-02-06T15:46:52Z
[FLINK-8603] [flip6] Split submitJob into job submission and execution result retrieval
Split RestClusterClient#submitJob into submitJob and requestJobResult which can
be called individually.
This closes #5428.
commit eeb453af12b5d49e8f49667f93ecc0e9e8093532
Author: Till Rohrmann <tr...@...>
Date: 2018-02-06T18:11:53Z
[hotfix] Change shutdown order in WebMonitorEndpoint to avoid illegal state
commit 2a154173c7914901a6df5b99ff760f1417159bfc
Author: Till Rohrmann <tr...@...>
Date: 2018-02-07T11:35:58Z
[FLINK-8605] [rest] Enable job cancellation from the web UI
In order to support the job cancellation from the web UI, including when using
Yarn, we have to register the JobTerminationHandler under /jobs/:jobid/yarn-cancel
and /jobs/:jobid/yarn-stop. This is just a temporary fix until we can send
arbitrary REST verbs through the Yarn proxy.
This closes #5430.
commit a5105894b981e67631145d1921cd8cbf79fb2308
Author: Till Rohrmann <tr...@...>
Date: 2018-02-08T12:43:09Z
[FLINK-8604] [rest] Move JobTerminationHandler into WebMonitorEndpoint
Register the JobTerminationHandler at the WebMonitorEndpoint to make it accessible to
all REST endpoints.
This closes #5429.
commit c9bc97490ed8a658f03cb65a776fba2053b2d46f
Author: Till Rohrmann <tr...@...>
Date: 2018-02-06T15:47:28Z
[FLINK-8609] [flip6] Enable Flip-6 job mode in CliFrontend
This commit allows to deploy detached job mode clusters via the
CliFrontend. In order to do that, it first extracts the JobGraph
from the PackagedProgram and then uses the ClusterDescriptor to
deploy the job mode cluster.
This closes #5432.
commit 84418d0b9183fbfeb3919fcb0d2f17708f786628
Author: Till Rohrmann <tr...@...>
Date: 2018-02-14T14:44:06Z
[FLINK-8608] [flip6] Implement MiniDispatcher for job mode
The MiniDispatcher is responsible for submitting the single job with which
a job mode cluster is started. Once the job has completed and if the cluster
has been started in detached mode, the MiniDispatcher will terminate.
In order to reduce code duplication, the MiniDispatcher is a sub class of the
Dispatcher which is started with a single job submitted job graph store.
This closes #5431.
commit 879185c8385047b6557db07bc752b95fa7ba9fa0
Author: Till Rohrmann <tr...@...>
Date: 2018-02-07T16:00:40Z
[FLINK-8613] [flip6] [yarn] Return excess containers
Upon notification of newly allocated containers, the YarnResourceManager
will only accept as many containers as there are pending container requests.
All excess containers will be returned.
This closes #5436.
commit e3e601b39492291b5837e58741bf7da46c76404a
Author: zhangminglei <zm...@...>
Date: 2018-02-14T13:58:40Z
[FLINK-8212] [network] Pull EnvironmentInformation out of TaskManagerServices
This closes #5458.
commit 39df56d6aebb3911f19593dbf120d42789e8db5a
Author: gyao <ga...@...>
Date: 2018-02-14T15:48:47Z
[FLINK-7713][flip6] Implement JarUploadHandler
This closes #5442.
commit f57b9833aaf7649f79b72efd4a033fbfb4f8e218
Author: Till Rohrmann <tr...@...>
Date: 2018-02-12T15:33:15Z
[FLINK-8530] [flip6] Enable detached job mode submission to session cluster
This commit makes the RestClusterClient aware whether the user wishes to submit
a job in detached or non-detached mode. If it is detached, then the RestClusterClient
won't poll for the execution result.
This closes #5466.
commit 5ed180c8121992d1b64dc879c9b6d78d00e57c92
Author: Till Rohrmann <tr...@...>
Date: 2018-02-13T13:27:31Z
[FLINK-8644] [flip6] Shut down AkkaRpcActors with PoisonPill
Shutting AkkaRpcActors down with Kill can result in uncompleted futures, if
the mailbox contains requests which will be dropped. Therefore, it is better
to stop AkkaRpcActors with a PoisonPill which assures that all messages before
the pill will be processed.
This closes #5476.
commit 1321c17047daed756ce4216814b8708162a57e83
Author: Till Rohrmann <tr...@...>
Date: 2018-02-13T11:41:44Z
[FLINK-8643] [flip6] Use JobManagerOptions#SLOT_REQUEST_TIMEOUT in ExecutionGraph
This commit changes the initialization of the ExecutionGraph to use the
JobManagerOptions#SLOT_REQUEST_TIMEOUT for the slot allocation. Furthermore,
it changes the behaviour of the SlotPool#ProviderAndOwner implementation such
that the timeout is given to it via the SlotProvider#allocateSlot call.
This closes #5475.
commit 341467dd58e4bdcfe133a31d8cb32b6a6a8d7559
Author: Till Rohrmann <tr...@...>
Date: 2018-02-13T12:18:01Z
[hotfix] [flip6] Remove unnecessary timeout from SlotPool
commit f81ef63eee61419e3a46b14b2721d023abb9f315
Author: Till Rohrmann <tr...@...>
Date: 2018-02-15T10:37:58Z
[FLINK-8662] [tests] Harden FutureUtilsTest#testRetryWithDelay
This commit moves the start of the time measurement before the triggering of
the retry with delay operation.
----
> FutureUtilsTest#testRetryWithDelay unstable
> -------------------------------------------
>
> Key: FLINK-8662
> URL: https://issues.apache.org/jira/browse/FLINK-8662
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Critical
> Fix For: 1.5.0
>
>
> The {{FutureUtilsTes#testRetryWithDelay}} is unstable on Travis:
> [https://travis-ci.org/apache/flink/jobs/341773028]
>
> The problem seems to be that we measure the time in the test case incorrectly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)