You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Yonik Seeley (JIRA)" <ji...@apache.org> on 2010/03/19 16:23:27 UTC
[jira] Created: (SOLR-1835) speed up and improve tests
speed up and improve tests
--------------------------
Key: SOLR-1835
URL: https://issues.apache.org/jira/browse/SOLR-1835
Project: Solr
Issue Type: Improvement
Reporter: Yonik Seeley
Fix For: 3.1
General test improvements.
We should use @BeforeClass where possible to avoid per test method overhead, and reuse lucene test utils where possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1835) speed up and improve tests
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850267#action_12850267 ]
Yonik Seeley commented on SOLR-1835:
------------------------------------
As a further attempt to clean up "example" and make it one server rather than many, I think it makes sense to remove the "multicore" directory. Our standard example is now multicore enabled already.
This will also involve making the multicore example tests not depend on "example", but on a test config (or making them create the cores dynamically from "example").
> speed up and improve tests
> --------------------------
>
> Key: SOLR-1835
> URL: https://issues.apache.org/jira/browse/SOLR-1835
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Fix For: 3.1
>
> Attachments: SOLR-1835-ignoreExceptions.patch, SOLR-1835-ignoreExceptions.patch, SOLR-1835.patch, SOLR-1835_example_junit4.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch
>
>
> General test improvements.
> We should use @BeforeClass where possible to avoid per test method overhead, and reuse lucene test utils where possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1835) speed up and improve tests
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated SOLR-1835:
------------------------------
Attachment: SOLR-1835_parallel.patch
there was a stray slash in the previous version.
this caused some people to mistakenly believe they have a faster computer than me.
> speed up and improve tests
> --------------------------
>
> Key: SOLR-1835
> URL: https://issues.apache.org/jira/browse/SOLR-1835
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Fix For: 3.1
>
> Attachments: SOLR-1835.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch
>
>
> General test improvements.
> We should use @BeforeClass where possible to avoid per test method overhead, and reuse lucene test utils where possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1835) speed up and improve tests
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated SOLR-1835:
------------------------------
Attachment: SOLR-1835_parallel.patch
attached is a patch to parallelize the tests...
improvements can be done, and contrib too (e.g. DIH)
but this drops my test time to 4:42 on the first try.
> speed up and improve tests
> --------------------------
>
> Key: SOLR-1835
> URL: https://issues.apache.org/jira/browse/SOLR-1835
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Fix For: 3.1
>
> Attachments: SOLR-1835.patch, SOLR-1835_parallel.patch
>
>
> General test improvements.
> We should use @BeforeClass where possible to avoid per test method overhead, and reuse lucene test utils where possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1835) speed up and improve tests
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848761#action_12848761 ]
Yonik Seeley commented on SOLR-1835:
------------------------------------
scratch that - it did work from the command line.
> speed up and improve tests
> --------------------------
>
> Key: SOLR-1835
> URL: https://issues.apache.org/jira/browse/SOLR-1835
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Fix For: 3.1
>
> Attachments: SOLR-1835-ignoreExceptions.patch, SOLR-1835.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch
>
>
> General test improvements.
> We should use @BeforeClass where possible to avoid per test method overhead, and reuse lucene test utils where possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1835) speed up and improve tests
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated SOLR-1835:
------------------------------
Attachment: SOLR-1835_parallel.patch
attached is a new patch:
* the output from multiple threads is no longer interleaved
* you need to put ant.jar and ant-junit.jar in example/lib for this patch to work. these need to be ant 1.7.1 (lucene needs this version anyway i think)
> speed up and improve tests
> --------------------------
>
> Key: SOLR-1835
> URL: https://issues.apache.org/jira/browse/SOLR-1835
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Fix For: 3.1
>
> Attachments: SOLR-1835.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch
>
>
> General test improvements.
> We should use @BeforeClass where possible to avoid per test method overhead, and reuse lucene test utils where possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1835) speed up and improve tests
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848586#action_12848586 ]
Robert Muir commented on SOLR-1835:
-----------------------------------
committed revision 926470 to newtrunk.
if you have problems, please just revert and I will help debug them.
for future speedups, we should try to move ant logic to common-build.xml and re-use it for contribs.
this way, DIH tests etc will run in parallel, too.
> speed up and improve tests
> --------------------------
>
> Key: SOLR-1835
> URL: https://issues.apache.org/jira/browse/SOLR-1835
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Fix For: 3.1
>
> Attachments: SOLR-1835.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch
>
>
> General test improvements.
> We should use @BeforeClass where possible to avoid per test method overhead, and reuse lucene test utils where possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1835) speed up and improve tests
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated SOLR-1835:
------------------------------
Attachment: SOLR-1835_parallel.patch
updated patch:
* doesnt do parallel for the -Dtestcase= case, but does for all, -Dtestpackage, -Dtestpackageroot, etc
* you can make the condition for whether to do parallel or not more complex, e.g. nightlies could go sequentially.
> speed up and improve tests
> --------------------------
>
> Key: SOLR-1835
> URL: https://issues.apache.org/jira/browse/SOLR-1835
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Fix For: 3.1
>
> Attachments: SOLR-1835.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch
>
>
> General test improvements.
> We should use @BeforeClass where possible to avoid per test method overhead, and reuse lucene test utils where possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1835) speed up and improve tests
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley updated SOLR-1835:
-------------------------------
Attachment: SOLR-1835-ignoreExceptions.patch
Here's a patch that tries to allow us to avoid spitting out certain expected exceptions during a test.
Seems to work when running from intellij (avoids the logging of the exception), but not from the command line for some reason.
> speed up and improve tests
> --------------------------
>
> Key: SOLR-1835
> URL: https://issues.apache.org/jira/browse/SOLR-1835
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Fix For: 3.1
>
> Attachments: SOLR-1835-ignoreExceptions.patch, SOLR-1835.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch
>
>
> General test improvements.
> We should use @BeforeClass where possible to avoid per test method overhead, and reuse lucene test utils where possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1835) speed up and improve tests
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848792#action_12848792 ]
Yonik Seeley commented on SOLR-1835:
------------------------------------
OK, I've committed the exception logging ignore patch.
> speed up and improve tests
> --------------------------
>
> Key: SOLR-1835
> URL: https://issues.apache.org/jira/browse/SOLR-1835
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Fix For: 3.1
>
> Attachments: SOLR-1835-ignoreExceptions.patch, SOLR-1835-ignoreExceptions.patch, SOLR-1835.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch
>
>
> General test improvements.
> We should use @BeforeClass where possible to avoid per test method overhead, and reuse lucene test utils where possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1835) speed up and improve tests
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley updated SOLR-1835:
-------------------------------
Attachment: SOLR-1835_example_junit4.patch
Attaching patch with the beginnings of migrating some of the example/jetty tests to junit4, and only spinning up a jetty core once per test class.
> speed up and improve tests
> --------------------------
>
> Key: SOLR-1835
> URL: https://issues.apache.org/jira/browse/SOLR-1835
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Fix For: 3.1
>
> Attachments: SOLR-1835-ignoreExceptions.patch, SOLR-1835-ignoreExceptions.patch, SOLR-1835.patch, SOLR-1835_example_junit4.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch
>
>
> General test improvements.
> We should use @BeforeClass where possible to avoid per test method overhead, and reuse lucene test utils where possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1835) speed up and improve tests
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley updated SOLR-1835:
-------------------------------
Attachment: SOLR-1835.patch
Attaching a first cut at a SolrTestCaseJ4 that extends LuceneTestCaseJ4.
Code is pretty much ripped from AbstractSolrTestCase and made static.
Seems to work though. I changed SimpleFacetsTest to use it as an example.
> speed up and improve tests
> --------------------------
>
> Key: SOLR-1835
> URL: https://issues.apache.org/jira/browse/SOLR-1835
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Fix For: 3.1
>
> Attachments: SOLR-1835.patch
>
>
> General test improvements.
> We should use @BeforeClass where possible to avoid per test method overhead, and reuse lucene test utils where possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1835) speed up and improve tests
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850289#action_12850289 ]
Yonik Seeley commented on SOLR-1835:
------------------------------------
Mark pointed out that removing "multicore" is related to (and perhaps already implemented as part of) https://issues.apache.org/jira/browse/SOLR-1770
> speed up and improve tests
> --------------------------
>
> Key: SOLR-1835
> URL: https://issues.apache.org/jira/browse/SOLR-1835
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Fix For: 3.1
>
> Attachments: SOLR-1835-ignoreExceptions.patch, SOLR-1835-ignoreExceptions.patch, SOLR-1835.patch, SOLR-1835_example_junit4.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch
>
>
> General test improvements.
> We should use @BeforeClass where possible to avoid per test method overhead, and reuse lucene test utils where possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1835) speed up and improve tests
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley updated SOLR-1835:
-------------------------------
Attachment: SOLR-1835-ignoreExceptions.patch
Upated exception ignore patch and some converted tests.
> speed up and improve tests
> --------------------------
>
> Key: SOLR-1835
> URL: https://issues.apache.org/jira/browse/SOLR-1835
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Fix For: 3.1
>
> Attachments: SOLR-1835-ignoreExceptions.patch, SOLR-1835-ignoreExceptions.patch, SOLR-1835.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch, SOLR-1835_parallel.patch
>
>
> General test improvements.
> We should use @BeforeClass where possible to avoid per test method overhead, and reuse lucene test utils where possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.